Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp3215624iob; Sun, 1 May 2022 09:55:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydWiJCcBRINwKKQbgWTeSXnG6xzZkk8LR2FAROIHJrYbcoMQzGQ9aaIrPR4ks9ivp6P5dt X-Received: by 2002:a2e:580b:0:b0:24f:4e25:f26d with SMTP id m11-20020a2e580b000000b0024f4e25f26dmr4163016ljb.346.1651424140896; Sun, 01 May 2022 09:55:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651424140; cv=none; d=google.com; s=arc-20160816; b=F1u9jwMNNBI6XJd0d1UXLC1RZEkVtlXOgLWrZGspY+/UwnyR67RHTawIfcqgbWcZT1 YfRmbRLgaFopjU8Qv4mA2olm+hC9By5cp8kdpX5Uvynf7IZ4TyUEsH2voziC0OA5YjZN yDL++2dW8ElZlRnsFaUcneopyg2fq5QIunIxrQBI4Uy54GLmvCC5SMzahQzwV7VLSt+l aHAZwusIiWawD9mwFzRmdPZ8jTD0+Kf3nbMfXeo4TlhzK38jrQacPiAxHSDQ4N/LANLd lH67TJPkrErTItR9LfJZUWcRYYu8sSDZwuUakGiwcC6aQM5nPlyBXK2NdAyc5QqJnyEq FxOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature; bh=21tqyErkdm7cH26OQoWF/VqXYN/cUWjgUiSt8KhywGw=; b=Vz+zv4e6Wfjejd+PZH2xikD83UgLDG1C1RurU5WFrbhRi4bD26jQQkuZGtTPCFvqkP GRT4morG23j+82QBRGtCLztybYFQebfqNSWW6te+VNDSRzzlWXYKnKKo+kmItpEj0YHL sD2GL4COgfHlEDBi+iVJY10qOOopZAhM6ef7gDLtjLEOORQqbfDubDRdXiLpElWWckCt DM++74lH1kQ3PITZR6niq7dOq/eNHL50eFiCwj03MPUdovATQUttb+RMMdOSvU9dS1Ky elKEVdSTAIfXUiW2xerSVccXhtttzVpGwzmHslYYG6Wmy18VgB/t7zRTaovMAlEDQK34 NYRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (expired) header.i=@cerno.tech; dkim=neutral (expired) header.i=@messagingengine.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m11-20020a2e97cb000000b0024f18ac8e98si13343064ljj.200.2022.05.01.09.55.12; Sun, 01 May 2022 09:55:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=neutral (expired) header.i=@cerno.tech; dkim=neutral (expired) header.i=@messagingengine.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355839AbiD2InC (ORCPT + 99 others); Fri, 29 Apr 2022 04:43:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235473AbiD2InA (ORCPT ); Fri, 29 Apr 2022 04:43:00 -0400 Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89487C3EA3; Fri, 29 Apr 2022 01:39:40 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 0E6985813B0; Fri, 29 Apr 2022 04:39:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 29 Apr 2022 04:39:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1651221578; x= 1651228778; bh=21tqyErkdm7cH26OQoWF/VqXYN/cUWjgUiSt8KhywGw=; b=L MXN8A5MT/vJe5if+TACu83PEO4w9U0+/MBcEnFbMmpg93q4/UJCVXfndFGTC5QaI jlLanXOP2eg40bWWYnEfj8ZtymQwgNi7pYTQkTHIKGlkA70B/l6oiha2+9uGOLJd HZyhZpsW9rFS4j3bd/WvtHG6wx6GQGBM0oSl+rNJa4yNHXsSVaAAkkgf1jL242kn NhY7E2e1E0t7KpADVB6gmaaUSwxVLACkwszvyjR86fNdVxoXwpdFLtHDQgjnG3Rq i/PrRukDAxbe0R5nq28MGdPwwjfIN/gT5G9RsVdIduNseseL/tfgdalpuyNX9Vlu eK6pgrqKCjzolnHGHYTNg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1651221578; x=1651228778; bh=21tqyErkdm7cH 26OQoWF/VqXYN/cUWjgUiSt8KhywGw=; b=ABqziAFlc4dK2t1EHBDCCYvQDZVYn 9GjIbxSEltsJgJtFN/MEam2btf4+Nji4H8E5IWgfgvmyt1p4AkXu3IfvTNt1qsuC MFl2cCtDD2o9OASZHClK9VJ3se/v/ArqHeIYV6wfhNki0UiulnhQZXCmZQpW3dKU ONa6VZT2MBR9Mnd6TAYot13qnfOHMXnm/OFavDryXarN6YcCucxb0YJwMA1L6nRb 3L0n1CABD6tQReAzvcxcUdBOZun9Yk1BflyssTR3zrPVxdDgBsNUpJUcP/BvhH0O MA5lwRxSyKcYvmhUjf6YWZr297UUfKq0Gz4+9VxUSyqtOylcootIwc/0g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudelgddthecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtugfgjgesthhqredttddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeetgfelgefggeekkefggfeludeiudffjeffgeevveekjedukedtudeuteef teefgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 29 Apr 2022 04:39:35 -0400 (EDT) Date: Fri, 29 Apr 2022 10:39:33 +0200 From: Maxime Ripard To: Guillaume Ranquet Cc: airlied@linux.ie, angelogioacchino.delregno@collabora.com, chunfeng.yun@mediatek.com, chunkuang.hu@kernel.org, ck.hu@mediatek.com, daniel@ffwll.ch, deller@gmx.de, jitao.shi@mediatek.com, kishon@ti.com, krzk+dt@kernel.org, maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com, p.zabel@pengutronix.de, robh+dt@kernel.org, tzimmermann@suse.de, vkoul@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, markyacoub@google.com, Markus Schneider-Pargmann , kernel test robot Subject: Re: [PATCH v9 18/22] drm/mediatek: Add mt8195 Embedded DisplayPort driver Message-ID: <20220429083933.q3w75q3zuyyuvo4w@houat> References: <20220327223927.20848-1-granquet@baylibre.com> <20220327223927.20848-19-granquet@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220327223927.20848-19-granquet@baylibre.com> X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guillaume, On Mon, Mar 28, 2022 at 12:39:23AM +0200, Guillaume Ranquet wrote: > From: Markus Schneider-Pargmann >=20 > This patch adds a DisplayPort driver for the Mediatek mt8195 SoC. >=20 > It supports the mt8195, the embedded DisplayPort units. It offers > DisplayPort 1.4 with up to 4 lanes. >=20 > The driver shares its iomap range with the mtk-dp-phy driver using > the regmap/syscon facility. >=20 > This driver is based on an initial version by > Jason-JH.Lin . >=20 > Signed-off-by: Markus Schneider-Pargmann > Signed-off-by: Guillaume Ranquet > Reported-by: kernel test robot You don't need to set Reported-by on a patch introducing a new driver. That would be typically done for a fix. > --- > drivers/gpu/drm/mediatek/Kconfig | 8 + > drivers/gpu/drm/mediatek/Makefile | 2 + > drivers/gpu/drm/mediatek/mtk_dp.c | 2221 ++++++++++++++++++++++++ > drivers/gpu/drm/mediatek/mtk_dp_reg.h | 568 ++++++ > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 + > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 1 + > 6 files changed, 2801 insertions(+) > create mode 100644 drivers/gpu/drm/mediatek/mtk_dp.c > create mode 100644 drivers/gpu/drm/mediatek/mtk_dp_reg.h >=20 > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/= Kconfig > index 2976d21e9a34..03ffa9b896c3 100644 > --- a/drivers/gpu/drm/mediatek/Kconfig > +++ b/drivers/gpu/drm/mediatek/Kconfig > @@ -28,3 +28,11 @@ config DRM_MEDIATEK_HDMI > select PHY_MTK_HDMI > help > DRM/KMS HDMI driver for Mediatek SoCs > + > +config MTK_DPTX_SUPPORT > + tristate "DRM DPTX Support for Mediatek SoCs" > + depends on DRM_MEDIATEK > + select PHY_MTK_DP > + select DRM_DP_HELPER > + help > + DRM/KMS Display Port driver for Mediatek SoCs. > diff --git a/drivers/gpu/drm/mediatek/Makefile b/drivers/gpu/drm/mediatek= /Makefile > index 29098d7c8307..d86a6406055e 100644 > --- a/drivers/gpu/drm/mediatek/Makefile > +++ b/drivers/gpu/drm/mediatek/Makefile > @@ -21,3 +21,5 @@ mediatek-drm-hdmi-objs :=3D mtk_cec.o \ > mtk_hdmi_ddc.o > =20 > obj-$(CONFIG_DRM_MEDIATEK_HDMI) +=3D mediatek-drm-hdmi.o > + > +obj-$(CONFIG_MTK_DPTX_SUPPORT) +=3D mtk_dp.o > diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek= /mtk_dp.c > new file mode 100644 > index 000000000000..7cd8459cf719 > --- /dev/null > +++ b/drivers/gpu/drm/mediatek/mtk_dp.c > @@ -0,0 +1,2221 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2019 MediaTek Inc. > + * Copyright (c) 2021 BayLibre 2022? > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include