Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 30 Apr 2022 11:44:43 +0000
From:   Hyeonggon Yoo <42.hyeyoo@gmail.com>
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     Marco Elver <elver@google.com>,
        Matthew WilCox <willy@infradead.org>,
        Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Roman Gushchin <roman.gushchin@linux.dev>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 04/23] mm/slab_common: cleanup kmalloc_track_caller()
Message-ID: <20220430114441.GA24925@ip-172-31-27-201.ap-northeast-1.compute.internal>
References: <20220414085727.643099-1-42.hyeyoo@gmail.com>
 <20220414085727.643099-5-42.hyeyoo@gmail.com>
 <a85a0358-fd42-a269-9bde-216a9b0520c5@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a85a0358-fd42-a269-9bde-216a9b0520c5@suse.cz>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk

On Tue, Apr 26, 2022 at 05:49:08PM +0200, Vlastimil Babka wrote:
> On 4/14/22 10:57, Hyeonggon Yoo wrote:
> > Make kmalloc_track_caller() wrapper of kmalloc_node_track_caller().
> > 
> > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
> > ---
> >  include/linux/slab.h | 17 ++++++++---------
> >  mm/slab.c            |  6 ------
> >  mm/slob.c            |  6 ------
> >  mm/slub.c            | 22 ----------------------
> >  4 files changed, 8 insertions(+), 43 deletions(-)
> > 
> > diff --git a/include/linux/slab.h b/include/linux/slab.h
> > index a3b9d4c20d7e..acdb4b7428f9 100644
> > --- a/include/linux/slab.h
> > +++ b/include/linux/slab.h
> > @@ -639,6 +639,12 @@ static inline __alloc_size(1, 2) void *kcalloc(size_t n, size_t size, gfp_t flag
> >  	return kmalloc_array(n, size, flags | __GFP_ZERO);
> >  }
> >  
> > +extern void *__kmalloc_node_track_caller(size_t size, gfp_t flags, int node,
> > +					 unsigned long caller) __alloc_size(1);
> 
> Update: in v3 remove the extern, it's not necessary and the kernel is slowly
> getting rid of them.

Will do in v3. Thanks!