Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 29 Apr 2022 19:29:19 +0800
From:   Aaron Lu <aaron.lu@intel.com>
To:     Mel Gorman <mgorman@techsingularity.net>
CC:     kernel test robot <oliver.sang@intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Dave Hansen" <dave.hansen@linux.intel.com>,
        Jesper Dangaard Brouer <brouer@redhat.com>,
        Michal Hocko <mhocko@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>, <lkp@lists.01.org>,
        <lkp@intel.com>, <ying.huang@intel.com>, <feng.tang@intel.com>,
        <zhengjun.xing@linux.intel.com>, <fengwei.yin@intel.com>
Subject: Re: [mm/page_alloc]  f26b3fa046:  netperf.Throughput_Mbps -18.0%
 regression
Message-ID: <YmvMDyx05UoPFtQy@ziqianlu-desk1>
References: <20220420013526.GB14333@xsang-OptiPlex-9020>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220420013526.GB14333@xsang-OptiPlex-9020>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+8xPraKc21BJckui78RpmioZ3gKIGblRtR61k3bKW5Ys8Qkj/UOcJ2P550VF?=
 =?us-ascii?Q?Ro3h2PodeB+eSL4B7TSDdTRN+iqRBvUXf/oTRz4MMjs0S2UKYBcLJmUw3n7z?=
 =?us-ascii?Q?kg95ijHc0rzfREK1uYhwD6crISshUQabyqo8E47G+Akz9wBmJBS+lhFSELrA?=
 =?us-ascii?Q?1+ai/748gRFMI6j9Crh0hTU5DLhH0cPQLBADlaRgpUxjDF7yaNJfTW8ls+ZQ?=
 =?us-ascii?Q?GDCs4TDWCWrfK2iaJDiLP0qVS/H6mzyOUHgH+Heqk1jx1iblP0hTIIdnLB10?=
 =?us-ascii?Q?AOgpD2t36VDk98GTmmiqOBjxS6+4+u2KaZ0wTm0tnyS07pM8wlb40cDG9YnW?=
 =?us-ascii?Q?8qIt7OXxn6JaJCiLWP+CbwedU8Ww1Q/Nsqwap6ZzGJnw6SQQWi1mlWVOLne2?=
 =?us-ascii?Q?UZYvnnjnZJL53lHZHlzO22hpIA/7/xAdfYyVb4uvnJ03squHcNtckikuX/44?=
 =?us-ascii?Q?F9Sf9kUUnLvDHlDUU04QVP6uweqRLSQNWu0x22uPrgVSAPbjI80rdqCq0mgR?=
 =?us-ascii?Q?77zmTc1vLoyq25BnG9ehqLml/IXXuFi7AZr0CTsf+4DVGxJe8u+A8VUO8hSI?=
 =?us-ascii?Q?ezITMtWxwdqafuSG7x7k+bAX+UjXuoL8yQ9tcHPC1ouULWYIDCLAapKNA2DW?=
 =?us-ascii?Q?Cdp6TfhyY68/I2K1GPeJrLMV+YkHFtI3KxTd54UcrG4XTUJZCapxgUgm6lBd?=
 =?us-ascii?Q?3AJ39AnXA9rV50BCTzgIoOuo/x5DpBUutPA8s01fOarsihb5rW1+XVPP8Wl4?=
 =?us-ascii?Q?BqVnal1eVTqMPdvSdMJQWNdSZlZzqf6MlNhI6DigyrFxh4pLiQ7x6P9PTrnm?=
 =?us-ascii?Q?T2BKMyjJwc5xiNh6aFF1kPC/WC9eydK1Cs57q/Tf24F2ojB4E1fMifUl+a3L?=
 =?us-ascii?Q?2ujvJdDgJwT28OziKpYXX7id+gFTbELb03JyTGVIUzHU+oo7lsqVNWFEgZRC?=
 =?us-ascii?Q?o81XF+YgM3DOUCGVBC7VGvk+MEsqCA3Opw0vtzONkjLul7E1GJxZzegPi5Sy?=
 =?us-ascii?Q?cCme8KFczUy2d/O4CO9y8LpA23GKakVGz/bP+RCK5TAl7UzwqHQ9/3pjCjAG?=
 =?us-ascii?Q?uY4aTtOu1Fm32SL5Yk0ZxqkEpZB9VfFgQX7iAvrjCBg/AYE2yPKZXO+IlFR7?=
 =?us-ascii?Q?QJSljR8GFabz0LkKvWu6OsptVkxb8MqB6lTcKwGFLL30I/0hJzdqcSYTyct2?=
 =?us-ascii?Q?TNPe579uSwdf1JYXRF9AVrbzvFWOW24nfihcyaml+QwfCa6DFBs3W4Lu/A7u?=
 =?us-ascii?Q?4tRNFOiBb8TFpNemRH0DcuLn+KuDbDXUuuPhG1fY9Rfn4AFVkpzLGPutZ8SP?=
 =?us-ascii?Q?JAsWxX7ADgYBQhFx3/GC4Rp/9FyEATdAxSyS/D66R62a1M+b6wMbI/HvTJ0k?=
 =?us-ascii?Q?qup4lYO1CgMy6+Gd5ytPwyS/a99O2GdxfFA5uFEOqStIakpOrKcdhE/sYs39?=
 =?us-ascii?Q?RjIIU46ha5iaGcBel/vBZlZVHqkf+ng4H8oXaJplvNhYXBGtFeKpkdrDYgAx?=
 =?us-ascii?Q?ypE8uXUd/wY6h4RW6vsg9T2GXBMAxRUV3NYq0F908GXX5VOCJruh1A1g+12a?=
 =?us-ascii?Q?i+Y4iihBqkPujWahb7BMRMCGS4FFsaygmYzUSGnvAabCdsk3YiezbQ2X76ra?=
 =?us-ascii?Q?T4IKEu1l6JoE1aZg52C9zTWx+q5ZlNi+KQIONnG+0a5aobL/BaKEFs3kX3iX?=
 =?us-ascii?Q?HCfvSTIO+xTQPSgsB3YcDp5BlXIxuitXkZXGXDhFaB8Q7G00uNq0Fd/oO/DK?=
 =?us-ascii?Q?fay0wXGTnA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ea908cde-bc29-4660-83bd-08da29d38659
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3062.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 11:29:29.7229
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ymvrlvK5qjbYUlRB9Cqa5ClrhE2+zasbCpJpu78Cvx0tlG+T1dMDu0+Hzi8dTAbn/29WNdeZyDbVr9ji2wfTAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1892
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Mel,

On Wed, Apr 20, 2022 at 09:35:26AM +0800, kernel test robot wrote:
> 
> (please be noted we reported
> "[mm/page_alloc]  39907a939a:  netperf.Throughput_Mbps -18.1% regression"
> on
> https://lore.kernel.org/all/20220228155733.GF1643@xsang-OptiPlex-9020/
> while the commit is on branch.
> now we still observe similar regression when it's on mainline, and we also
> observe a 13.2% improvement on another netperf subtest.
> so report again for information)
> 
> Greeting,
> 
> FYI, we noticed a -18.0% regression of netperf.Throughput_Mbps due to commit:
> 
> 
> commit: f26b3fa046116a7dedcaafe30083402113941451 ("mm/page_alloc: limit number of high-order pages on PCP during bulk free")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> 

So what this commit did is: if a CPU is always doing free(pcp->free_factor > 0)
and if the being freed high-order page's order is <= PAGE_ALLOC_COSTLY_ORDER,
then do not use PCP but directly free the page directly to buddy.

The rationale as explained in the commit's changelog is:
"
Netperf running on localhost exhibits this pattern and while it does not
matter for some machines, it does matter for others with smaller caches
where cache misses cause problems due to reduced page reuse. Pages
freed directly to the buddy list may be reused quickly while still cache
hot where as storing on the PCP lists may be cold by the time
free_pcppages_bulk() is called.
"

This regression occurred on a machine that has large caches so this
optimization brings no value to it but only overhead(skipped PCP), I
guess this is the reason why there is a regression.

I have also tested this case on a small machine: a skylake desktop and
this commit shows improvement:
8b10b465d0e1: "netperf.Throughput_Mbps": 72288.76,
f26b3fa04611: "netperf.Throughput_Mbps": 90784.4,  +25.6%

So this means those directly freed pages get reused by allocator side
and that brings performance improvement for machines with smaller cache.

I wonder if we should still use PCP a little bit under the above said
condition, for the purpose of:
1 reduced overhead in the free path for machines with large cache;
2 still keeps the benefit of reused pages for machines with smaller cache.

For this reason, I tested increasing nr_pcp_high() from returning 0 to
either returning pcp->batch or (pcp->batch << 2):
machine\nr_pcp_high() ret: pcp->high   0   pcp->batch (pcp->batch << 2)
skylake desktop:             72288   90784   92219       91528
icelake 2sockets:           120956   99177   98251      116108

note nr_pcp_high() returns pcp->high is the behaviour of this commit's
parent, returns 0 is the behaviour of this commit.

The result shows, if we effectively use a PCP high as (pcp->batch << 2)
for the described condition, then this workload's performance on
small machine can remain while the regression on large machines can be
greately reduced(from -18% to -4%).

> in testcase: netperf
> on test machine: 128 threads 2 sockets Intel(R) Xeon(R) Platinum 8358 CPU @ 2.60GHz with 128G memory
> with following parameters:
> 
> 	ip: ipv4
> 	runtime: 300s
> 	nr_threads: 1
> 	cluster: cs-localhost
> 	test: UDP_STREAM
> 	cpufreq_governor: performance
> 	ucode: 0xd000331
> 
> test-description: Netperf is a benchmark that can be use to measure various aspect of networking performance.
> test-url: http://www.netperf.org/netperf/
> 
> In addition to that, the commit also has significant impact on the following tests:
>

> +------------------+-------------------------------------------------------------------------------------+
> | testcase: change | netperf: netperf.Throughput_Mbps 13.2% improvement                                  |
> | test machine     | 128 threads 2 sockets Intel(R) Xeon(R) Platinum 8358 CPU @ 2.60GHz with 128G memory |
> | test parameters  | cluster=cs-localhost                                                                |
> |                  | cpufreq_governor=performance                                                        |
> |                  | ip=ipv4                                                                             |
> |                  | nr_threads=25%                                                                      |
> |                  | runtime=300s                                                                        |
> |                  | send_size=10K                                                                       |
> |                  | test=SCTP_STREAM_MANY                                                               |
> |                  | ucode=0xd000331                                                                     |
> +------------------+-------------------------------------------------------------------------------------+
>

And when nr_pcp_high() returns (pcp->batch << 2), the improvement will
drop from 13.2% to 5.7%, not great but still an improvement...

The said change looks like this:
(relevant comment will have to be adjusted)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 505d59f7d4fa..130a02af8321 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3332,18 +3332,19 @@ static int nr_pcp_high(struct per_cpu_pages *pcp, struct zone *zone,
 		       bool free_high)
 {
 	int high = READ_ONCE(pcp->high);
+	int batch = READ_ONCE(pcp->batch);
 
-	if (unlikely(!high || free_high))
+	if (unlikely(!high))
 		return 0;
 
-	if (!test_bit(ZONE_RECLAIM_ACTIVE, &zone->flags))
-		return high;
-
 	/*
 	 * If reclaim is active, limit the number of pages that can be
 	 * stored on pcp lists
 	 */
-	return min(READ_ONCE(pcp->batch) << 2, high);
+	if (test_bit(ZONE_RECLAIM_ACTIVE, &zone->flags) || free_high)
+		return min(batch << 2, high);
+
+	return high;
 }
 
 static void free_unref_page_commit(struct page *page, int migratetype,

Does this look sane? If so, I can prepare a formal patch with proper
comment and changelog, thanks.