Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp3599503iob; Mon, 2 May 2022 00:08:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPrD+ORP+1ZLG8k8tyqs6WsKwjoAV6mwmgkzJLcah3xZgW+QClpmoTvIuesTT+XY/ekTrN X-Received: by 2002:a17:902:b941:b0:14d:af72:3f23 with SMTP id h1-20020a170902b94100b0014daf723f23mr10710734pls.6.1651475311231; Mon, 02 May 2022 00:08:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651475311; cv=none; d=google.com; s=arc-20160816; b=av/4/hWyOFR7esNwEio/snEgahl2owPbZNySJMhykri2ckdrsKCl2JUGQKwPtgDfiJ k6slmTxQTa+Ilj8PD3C+B9OuoV958sOgCm/kKeNWyIac0WGMAbaXiSM5rCF1WkoY/3lk eURshZd12MesoobocCeI2/W28wPkDng+d0Z0kIF4bnu8iXSmPuT9rw2P64SsMYbJCY5v /gKg0d8jzW4s+6Xe/G2Z4Jog4h+s3k9QQ0PDMKj8kKV/KTwuWY0P/L8VSAB5Ld6SxiBd 4arFbad+JIXPYbWJ4CSYiEhl5F9S+kcDbVbNfHZ6wgHWYdqnK1IkoXECwGX3xtrEnX94 OTWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=tAm9X/2RYON5qj2a/6brZ73jzK6/k0cF3Jc0SAiEKzQ=; b=WFO5qHQEejedgpbTiga6IBwjKyH1hohtC4gDMhPvtFnSkyYsMyWi/Em6kyyr46rSzS W6Loa4cFO3dedcBziT/CSVflgAnF8jmq9rYo5esI6hD6I2JswDLZEQn81sEMHA/ELIUg 4JSr5ipR3Ldq/RhPG+eJDbUjxpmF3e7ou690UbHlZc/J33Xn6s3qYQyw1BwvqxfMR9v4 YheEEn+vTlcUFbkoaTZOnHYXKfEXlxzrFFr9NJ4pdzfEjbYeGmCENIOnnAJIn0MYpNwh b+uVCAIv9mdmLqaTSm2wTjZxGHTTfp7QX3JulaCEwN+rOuwAsJGvEqvaiVzT8Z5aflIl HLjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Y3Xi00JK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y10-20020a17090322ca00b00156966c019bsi15777176plg.537.2022.05.02.00.08.16; Mon, 02 May 2022 00:08:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Y3Xi00JK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357901AbiD2KqO (ORCPT + 99 others); Fri, 29 Apr 2022 06:46:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357767AbiD2Kpb (ORCPT ); Fri, 29 Apr 2022 06:45:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45E2EC6665; Fri, 29 Apr 2022 03:42:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D7AD762323; Fri, 29 Apr 2022 10:42:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7571C385A4; Fri, 29 Apr 2022 10:42:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651228927; bh=kO4IqmqhecTTjI1c3QBs2oCIiXGINhsrdjQ9SKOwUmk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y3Xi00JKod735NHm4kAYcoZrLXU5Q2u7D+xvJzQE5SIly1t3abslFrPY9Ct/1zjrl lUv6fySA9nNHuXufiAMZeJbUrYOsMHmZZMLNkgWffj5Ye1xMHpshniVPToAJJEoPj7 PB8uf2OQTTavGQZi+B39uodJTXkMxrLaXNRdJ4KE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Masami Hiramatsu Subject: [PATCH 4.19 08/12] Revert "ia64: kprobes: Fix to pass correct trampoline address to the handler" Date: Fri, 29 Apr 2022 12:41:25 +0200 Message-Id: <20220429104048.703832413@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220429104048.459089941@linuxfoundation.org> References: <20220429104048.459089941@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Masami Hiramatsu This reverts commit f5f96e3643dc33d6117cf7047e73512046e4858b. The commit f5f96e3643dc ("ia64: kprobes: Fix to pass correct trampoline address to the handler") was wrongly backported. It involves another commit which is a part of another bigger series, so it should not be backported to the stable tree. Signed-off-by: Masami Hiramatsu Signed-off-by: Greg Kroah-Hartman --- arch/ia64/kernel/kprobes.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) --- a/arch/ia64/kernel/kprobes.c +++ b/arch/ia64/kernel/kprobes.c @@ -411,8 +411,7 @@ static void kretprobe_trampoline(void) int __kprobes trampoline_probe_handler(struct kprobe *p, struct pt_regs *regs) { - regs->cr_iip = __kretprobe_trampoline_handler(regs, - dereference_function_descriptor(kretprobe_trampoline), NULL); + regs->cr_iip = __kretprobe_trampoline_handler(regs, kretprobe_trampoline, NULL); /* * By returning a non-zero value, we are telling * kprobe_handler() that we don't want the post_handler @@ -428,7 +427,7 @@ void __kprobes arch_prepare_kretprobe(st ri->fp = NULL; /* Replace the return addr with trampoline addr */ - regs->b0 = (unsigned long)dereference_function_descriptor(kretprobe_trampoline); + regs->b0 = ((struct fnptr *)kretprobe_trampoline)->ip; } /* Check the instruction in the slot is break */ @@ -958,14 +957,14 @@ static struct kprobe trampoline_p = { int __init arch_init_kprobes(void) { trampoline_p.addr = - dereference_function_descriptor(kretprobe_trampoline); + (kprobe_opcode_t *)((struct fnptr *)kretprobe_trampoline)->ip; return register_kprobe(&trampoline_p); } int __kprobes arch_trampoline_kprobe(struct kprobe *p) { if (p->addr == - dereference_function_descriptor(kretprobe_trampoline)) + (kprobe_opcode_t *)((struct fnptr *)kretprobe_trampoline)->ip) return 1; return 0;