Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757386AbXEINOP (ORCPT ); Wed, 9 May 2007 09:14:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756047AbXEINN6 (ORCPT ); Wed, 9 May 2007 09:13:58 -0400 Received: from mailer.gwdg.de ([134.76.10.26]:48352 "EHLO mailer.gwdg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753639AbXEINN5 (ORCPT ); Wed, 9 May 2007 09:13:57 -0400 Date: Wed, 9 May 2007 15:06:10 +0200 (MEST) From: Jan Engelhardt To: Evgeniy Polyakov cc: Thomas Gleixner , =?utf-8?B?SsO2cm4=?= Engel , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Dave Kleikamp , David Chinner Subject: Re: [PATCH 1/2] LogFS proper In-Reply-To: <20070508161703.GA18035@2ka.mipt.ru> Message-ID: References: <20070507215913.GA15054@lazybastard.org> <20070507220036.GB15054@lazybastard.org> <1178608950.3042.273.camel@localhost.localdomain> <1178639681.3042.334.camel@localhost.localdomain> <20070508161703.GA18035@2ka.mipt.ru> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Report: Content analysis: 0.0 points, 6.0 required _SUMMARY_ Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 658 Lines: 24 On May 8 2007 20:17, Evgeniy Polyakov wrote: >> > >> +static int __logfs_readdir(struct file *file, void *buf, filldir_t filldir) >> > >> +{ >> > >> + err = read_dir(dir, &dd, pos); >> > >> + if (err == -EOF) >> > >> + break; >> > > >> > > -EOF results in a return code 0 ? >> > >> > Results in a return code -256. >> >> Really ? It breaks out of the loop and returns 0 ! See, it's so confusing! Jan -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/