Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <24c08c1e-e4b5-3731-de33-e75a9b4bdf1f@rock-chips.com>
Date:   Fri, 29 Apr 2022 23:39:53 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] ASoC: hdmi-codec: Add option for ELD bypass
To:     Mark Brown <broonie@kernel.org>
Cc:     Dmitry Osipenko <digetx@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Maxime Ripard <maxime@cerno.tech>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
References: <1651245218-47201-1-git-send-email-sugar.zhang@rock-chips.com>
 <YmwDv7poot/5pcgb@sirena.org.uk>
From:   sugar zhang <sugar.zhang@rock-chips.com>
In-Reply-To: <YmwDv7poot/5pcgb@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Mark,

在 2022/4/29 23:26, Mark Brown 写道:
> On Fri, Apr 29, 2022 at 11:13:38PM +0800, Sugar Zhang wrote:
>
>> So, add this option to allow user to select the manual way
>> to output audio as expected. such as multi-channels LPCM(7.1),
>> or HBR bitstream for these sink devices.
> Please check this with mixer-test, it'll help validate that you've got
> the control interface correct.
Okay, I have found it in the tools/testing/selftests/alsa/mixer-test.c
>
>>   		.info	= hdmi_eld_ctl_info,
>>   		.get	= hdmi_eld_ctl_get,
>>   	},
>> +	HDMI_CODEC_ELD_BYPASS_DECL("ELD Bypass"),
> This is a true/false value so the name should end with Switch.
will do in v2.

-- 
Best Regards!
张学广/Sugar
瑞芯微电子股份有限公司
Rockchip Electronics Co., Ltd.