Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp3745042iob; Mon, 2 May 2022 04:47:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQeEi1qzwDtADV3YxaH2S6RsU4dUsML7/v1k993YSLM9pGyAab+UxK/g5kQUcO+7qJBN+O X-Received: by 2002:a2e:9b57:0:b0:24f:12ea:fd26 with SMTP id o23-20020a2e9b57000000b0024f12eafd26mr7159213ljj.352.1651492051286; Mon, 02 May 2022 04:47:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651492051; cv=none; d=google.com; s=arc-20160816; b=0ztNimjaIG1+8aXIfbNLIGDejbo1IjPyrKiWQLxDvE2RjPafE1tCBWR5guivbZE6Ul 5n/PnlNL9czYxzDEGw2EnNAW83aRP8T+x+IERtw0/NtpCg4OE8NIQkcJI2GvBzaguwxY jgVBG0keRpNmylah/ot5ln7OG6opHPUOxzThZ3sGV5C+nMsK731yTQ9sMczZscpiou5E Ty3i6gPGFk66GTDhPlm/vSO2EPskR2iDW7rYbIA8Jq/HG4I38AWl7gFc1V+CtLDjc3T3 gTkRcxjCZEhB7YUvOSwbEu8CRtud02h58TI5tjIhMpxMau10qkLWGaNx3Cuu74rruYBb 261Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=+okak/87tpOwGWkBiv+nnSu/gb7/SgHWrtmYPSf3hrA=; b=0jRSUMelnK3lbOahKooMjb/lFeHKrSGV1XvbEmxqbulDf9DH723923IOocdriL/6qm xCNnCPRCEMu6PdtYEruuEc8WSMjvMn2qG86UNZKcZ7lJ023cJpicZwfkMFmLA6P4F7Wx fLQTeTNLKPGB6BNgUivYMuBMJYeRmlNCnThslJvcUJivV9EE3rJVnbFe8AMQravW1htu XnLf/hTrHz8OgJMKy33dNCO6x9xnlMn7pY75aFglWt0DAVc57NckltaujuzQvUxDky+5 d+nKOhPR5e2+f2O1tVOz7TxZ7XLJwuk3jFXJrPJ6tRrQ1wd5jNdvUGKERyCOyZNMxUVy kh5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=bfLldcJ+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h13-20020a2eb0ed000000b0024f0845bb09si14224377ljl.188.2022.05.02.04.47.04; Mon, 02 May 2022 04:47:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=bfLldcJ+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351215AbiD1Sos (ORCPT + 99 others); Thu, 28 Apr 2022 14:44:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351204AbiD1Soq (ORCPT ); Thu, 28 Apr 2022 14:44:46 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 576F466F99 for ; Thu, 28 Apr 2022 11:41:31 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 1DB581F45BA9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1651171290; bh=HSr1KCZ5LnslRjGdE29dDFgwDJWDw5RpI+XCM1ThDIE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bfLldcJ+mxw6WfTtItLTOjLcjf0DYyzsn4duwT4V65y2wh/auNP5VbaKcF1uLtb0B iB/cky4I5BR35dO0sBsMH/IMcS2hQcrcukVUN2Se+PPS1Acf+cYw0aWDojUZPfuPr6 lry0gDJpMS6Znk7q4EgkKajPlWGFIbW3IQSsLO06kQYS5k5BW2+iwu3TyC1kW+eE2T ltrTAD36FgqZAog2GI8KGWD5k8oX5TmtV/lGfBCUjyzIl3wf69EgFqlvTSr7MWV/Rl O+vG2kloLrPb0rbCPCkO+207H8MSE6C8OYDbpOG/crx11Q8yVrBAc1ev3YHC1FTzVZ Ke2HvHpsR9S0A== Message-ID: <9647245d-b0b5-12d1-fef2-7a5f759f908b@collabora.com> Date: Thu, 28 Apr 2022 21:41:25 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v5 01/17] drm/panfrost: Put mapping instead of shmem obj on panfrost_mmu_map_fault_addr() error Content-Language: en-US To: Steven Price , David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Daniel Almeida , Gert Wollny , Gustavo Padovan , Daniel Stone , Tomeu Vizoso , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Alyssa Rosenzweig , Rob Clark , Emil Velikov , Robin Murphy , Qiang Yu , Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Dmitry Osipenko References: <20220424190424.540501-1-dmitry.osipenko@collabora.com> <20220424190424.540501-2-dmitry.osipenko@collabora.com> <37dae9fa-dadf-4b80-fbea-689472fd7dce@arm.com> From: Dmitry Osipenko In-Reply-To: <37dae9fa-dadf-4b80-fbea-689472fd7dce@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 28.04.2022 16:19, Steven Price пишет: > On 24/04/2022 20:04, Dmitry Osipenko wrote: >> When panfrost_mmu_map_fault_addr() fails, the BO's mapping should be >> unreferenced and not the shmem object that backs that mapping. >> >> Cc: stable@vger.kernel.org >> Signed-off-by: Dmitry Osipenko > > Fixes: bdefca2d8dc0 ("drm/panfrost: Add the panfrost_gem_mapping concept") > > Reviewed-by: Steven Price Thank you for the fixes tag. It appeared to me that this problem existed since the first addition of the srinker when I was looking up the offending commit, my bad :)