Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fdb13c95-acde-ebac-9864-e661d7daeeb7@oracle.com>
Date:   Fri, 29 Apr 2022 18:25:42 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH v2 0/4] xen/pv-scsi: update header and harden frontend
Content-Language: en-US
To:     Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Stefano Stabellini <sstabellini@kernel.org>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
References: <20220428075323.12853-1-jgross@suse.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220428075323.12853-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVVCWUltK24yS1A1Nm1QUUFOazNPRWRlZnlIdU5WbGp1bnh0MjhZc0ZDS1Uw?=
 =?utf-8?B?SlFpeW9kT0VkSEZVQWlTY1JKK1NyblpIY3dPa01Gd3p1ajNTQ0Y5V1VnQmRm?=
 =?utf-8?B?MHh2Z0d1KzE5ZlNIaVR5T3FUeUQxM2s4THZOMGpQSE9zRUk2ckttUXVvaHhZ?=
 =?utf-8?B?SDZLRkJQTEVWRkRvWmZUdldJNXBrdGl0b1lLQ1lwYVdkb3NYZ2xvRjRJeVJt?=
 =?utf-8?B?ZHVPb1Y2Q2xxR09tVWZyUDcrTktkME1uenpRcytSUHcvMk44S2J1VE9tczhj?=
 =?utf-8?B?dGFGZ2xPd3d6ak1jMmlOajNQQ1ZaWWVhaUVUVDhHTXQrbEVyZlMyb3ZlNEhU?=
 =?utf-8?B?STA2RjM4VXV5V3hGRTZCNWNwM1hvbDJ6eFVaN0NqejY3VktHUVFkK1MxSWR0?=
 =?utf-8?B?M25XaWZDVS9zTHEyUTVDUkp1NjV1ckIxWkxsaHdxaE1ZZ2pXNzY1dEFzQkl0?=
 =?utf-8?B?SkVlNXhmT1RZeTUzUUJjcW9hZ2JHMnpXWUU4bmV6c2phSkgrMDRRZ0NvWTk5?=
 =?utf-8?B?bFhqNnU4UGo5N1dQbjFUYlR5YnhRL3JFMmx1TkYwb1k5aVUwZnVFL2pYbEVS?=
 =?utf-8?B?VUxkbEdsT1ZEK3E2a1dWaVd5WGlvLytKTlVkUG5ZMEtvYkMyQTM5NS94am9x?=
 =?utf-8?B?QTRaVng2U2pCQzhlMnRQNzdBNE9SMG9qMUVidWdoMzZ1WHBjWXpvdHZPVG5M?=
 =?utf-8?B?S3AxYWJRSzJHa1l4dVBiamNIMHFhVE42NllzMkVqd2dQaXNycENkamdQeG5T?=
 =?utf-8?B?K3hHVzM2ZUJJVk1vREwvRFh0alRZWjFmQXBwTm0rZGhCdkVPdE8zM1pWQkhM?=
 =?utf-8?B?VFNwb3QyS0JHaFMzRmRXQnpmK0lBTWpxbUVDSEpnb0c1TFVVeEVWNUhQZTFZ?=
 =?utf-8?B?allGOVlDWnJGVjBZUGxVUi9DR2JwV3BXN0YrektNTFprbWhNMis3THlST0Mv?=
 =?utf-8?B?S1Jqak41UlBxR0hJbkpKTXM1QUhQREpON2Z2Q202dXZiTnQxMDdiWTk0TlJl?=
 =?utf-8?B?Qk1MejFCbEhIZVlVU3BkYy81ajFvQUZPdllsdjZYU3RKWXlvbi9CQnF4QmRS?=
 =?utf-8?B?eUFTa3ZmNktPQmhyQ2Vua3BlTEUvODdmWk9KYmJiUmlRKzEzeVFPK3pvd3Qy?=
 =?utf-8?B?YUZXTnhFOEs1ZFZXaWJmRzM3bjNlYXFSWGxiQ09hUWtSa1ZKSE92c3hHVHVL?=
 =?utf-8?B?Y0x6dVRKdnNKRTJKKzBpb3VaTkxCYU5XM0V0OUQ5TXQ3bVpDZXZiZktSK1Bo?=
 =?utf-8?B?akFVSTg3NlNIbHlxdnAzalFIenZMNkFjNElYbklZUzNWRVdnUFJNWGJjUnBs?=
 =?utf-8?B?S0RQQytkWDhXZG95MUNoS3JYdGJlL0E2V3laelZiWXZyU1ZFQ1NQMjdRUVJt?=
 =?utf-8?B?ancvQUFJakZscUR3bmVkYlkvamtOcWwvRkpQRmdVK3FYbE5rakJaeHJ5Undz?=
 =?utf-8?B?L2xwRGhBd3NLcXF2YUpwOC9peXoyUUxqdUIyTjlBNlFUb3VnNFpNYXhETHE1?=
 =?utf-8?B?Y3RtaDNqRkUybUNxeHRpOWxuZW1qMVRXT0I2dUNjUjU3bVlzcmFGV3lJL3ln?=
 =?utf-8?B?Mi9DY3BtUmRLbFN5Nk9KRUF2YU05ZjNmbFFSN2FJS090bmRIaThPdkVmWnE2?=
 =?utf-8?B?TG83bTJjM2lrR3cwRmoxanc0K0tvbmJFL25aRHVaSEZmem9YSzJRd09KR09Q?=
 =?utf-8?B?b3FIbUljOUxXM3g1TVVaQWNpSkIrUmwzWTVEVWhOK3JreXBXYmF0ZmFFbTVV?=
 =?utf-8?B?SHJhSmNNQlNkR29UK2pkNmMxUXdXNjExdEtlRHJCTGd1RS9VanRvNnEyYktp?=
 =?utf-8?B?TndpUUNnbW9pUkpuWW1rNUI0MTd6eXUyWG5YL1FWdjk3SmpEcERsTWJnbk15?=
 =?utf-8?B?aWhHeFlraEhnSFJqUFN1eUhubkZKUlRXemRtVG0zcVdWeUREbGRUekFmcjRT?=
 =?utf-8?B?Y2lZMGlTbUNvT2lZcW9rN0R3OFB2UG9vTi9KLzJXZHdkeDRJZkJZM1NObkFJ?=
 =?utf-8?B?TUJFMmtya1BUNGxIWi9hNmwxY0FjNlplTzBDWXNSVkViSjduQlFTdFAwRlVH?=
 =?utf-8?B?YUZhNURYVnE5Mk1iRVdkSEV1YTdCOWw2RmZDZ1NDZUEzVkhLMmpkMmpSa2lw?=
 =?utf-8?B?SG9PS1prR1E4bzYrV1Y4RWRhVDFCQU1MMmVNbE92SUNqMVhzU0FkR2xURGli?=
 =?utf-8?B?aVVuVStveU5TQ1NQdGVQa2YyNWhocHREa3R4R0NidUk3em5ZMEhjd29zODVs?=
 =?utf-8?B?S0liQW1rK2h0MURRa00xLzZUTS9jVXlXK3hjbXNNSnJ1SmdnbG1CUHNJK1Zs?=
 =?utf-8?B?cXE5V090NVFLSW9rSlVWdU1Pa0E4bDBlSUJQcGVtcXZqSmNvRjlOSFdHb2pw?=
 =?utf-8?Q?xJBkuFt7PY/ReJqU=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 779b4171-c5cd-4402-fac5-08da2a2f34c7
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 22:25:46.4946
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O7lEWRXoqGSzGscaMZWLhdpSem2r176eqqtQAiFnWjDAgGNra/wmAuZTz4ZKwPLdmOyJ1jPDnj6Q3oD/WoHz3S5cZ5ApNgzo4EmuJVpNQrQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5625
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-29_08:2022-04-28,2022-04-29 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 mlxscore=0
 suspectscore=0 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204290119
X-Proofpoint-ORIG-GUID: n6uDPHv0HCE4EXJNLMHQXfznGGp7wYD0
X-Proofpoint-GUID: n6uDPHv0HCE4EXJNLMHQXfznGGp7wYD0
X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/28/22 3:53 AM, Juergen Gross wrote:
> Update the Xen PV-scsi interface from the Xen tree and adapt the
> related drivers to use the new definitions.
>
> Harden the frontend driver to be no longer vulnerable to a malicious
> backend.
>
> Juergen Gross (4):
>    xen: update vscsiif.h
>    xen/scsiback: use new command result macros
>    xen/scsifront: use new command result macros
>    xen/scsifront: harden driver against malicious backend
>
>   drivers/scsi/xen-scsifront.c       | 168 ++++++++++++++++++++++-------
>   drivers/xen/xen-scsiback.c         |  82 +++++++++++++-
>   include/xen/interface/io/vscsiif.h | 133 ++++++++++++++++++++++-
>   3 files changed, 340 insertions(+), 43 deletions(-)


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>