Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220430090518.3127980-1-chenhuacai@loongson.cn>
 <20220430090518.3127980-11-chenhuacai@loongson.cn> <4dd26d88b807c967dbbc81a7b2e5f4084d9603d7.camel@mengyan1223.wang>
 <2a534c89b3c905a34f947fb2739d58c9373bb915.camel@mengyan1223.wang>
In-Reply-To: <2a534c89b3c905a34f947fb2739d58c9373bb915.camel@mengyan1223.wang>
From:   Huacai Chen <chenhuacai@gmail.com>
Date:   Mon, 2 May 2022 08:01:31 +0800
Message-ID: <CAAhV-H5vviww-h7BuhCitHVGeExjMOuWaap=iAc9ekqJzppgwQ@mail.gmail.com>
Subject: Re: [PATCH V9 10/24] LoongArch: Add exception/interrupt handling
To:     Xi Ruoyao <xry111@mengyan1223.wang>
Cc:     Huacai Chen <chenhuacai@loongson.cn>,
        Arnd Bergmann <arnd@arndb.de>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Airlie <airlied@linux.ie>,
        Jonathan Corbet <corbet@lwn.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-arch <linux-arch@vger.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Xuefeng Li <lixuefeng@loongson.cn>,
        Yanteng Si <siyanteng@loongson.cn>,
        Guo Ren <guoren@kernel.org>, Xuerui Wang <kernel@xen0n.name>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Ruoyao,

On Mon, May 2, 2022 at 1:08 AM Xi Ruoyao <xry111@mengyan1223.wang> wrote:
>
> On Mon, 2022-05-02 at 00:27 +0800, Xi Ruoyao wrote:
> > On Sat, 2022-04-30 at 17:05 +0800, Huacai Chen wrote:
> > > +struct acpi_madt_lio_pic;
> > > +struct acpi_madt_eio_pic;
> > > +struct acpi_madt_ht_pic;
> > > +struct acpi_madt_bio_pic;
> > > +struct acpi_madt_msi_pic;
> > > +struct acpi_madt_lpc_pic;
> >
> > Where are those defined?  I can't find them and the compilation fails
> > with:
> >
> > arch/loongarch/kernel/irq.c: In function =E2=80=98find_pch_pic=E2=80=99=
:
> > arch/loongarch/kernel/irq.c:48:32: error: invalid use of undefined
> > type =E2=80=98struct acpi_madt_bio_pic=E2=80=99
> >    48 |                 start =3D irq_cfg->gsi_base;
> >       |                                ^~
> > arch/loongarch/kernel/irq.c:49:32: error: invalid use of undefined
> > type =E2=80=98struct acpi_madt_bio_pic=E2=80=99
> >    49 |                 end   =3D irq_cfg->gsi_base + irq_cfg->size;
> >       |                                ^~
> > arch/loongarch/kernel/irq.c:49:52: error: invalid use of undefined
> > type =E2=80=98struct acpi_madt_bio_pic=E2=80=99
> >    49 |                 end   =3D irq_cfg->gsi_base + irq_cfg->size;
> >       |                                                    ^~
>
> Alright, my bad... I didn't realize the LoongArch patches are splitted
> into multiple series for multiple lists.  But is this the SOP of kernel
> patch reviewing?  Would it be easier to just send one series and CC all
> relevent lists?
The acpi stuff should go to acpica project first, then Rafael sync the
code to the kernel. The current status is acpica has merged LoongArch
support, but hasn't yet gone to the kernel.
ACPI: Add LoongArch-related definitions by chenhuacai =C2=B7 Pull Request
#757 =C2=B7 acpica/acpica =C2=B7 GitHub

Huacai
>
> --
> Xi Ruoyao <xry111@mengyan1223.wang>
> School of Aerospace Science and Technology, Xidian University