Received: by 2002:a6b:8b52:0:0:0:0:0 with SMTP id n79csp4837304iod; Mon, 2 May 2022 10:09:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxo1qTkuoyw7O/aSi3bZFaXPN9RzbMxZBJcVYYfP4OqnFitaRytA0Mx8410+Z4fdkWjaOzt X-Received: by 2002:a17:90a:a393:b0:1d0:e448:811d with SMTP id x19-20020a17090aa39300b001d0e448811dmr125253pjp.97.1651511366100; Mon, 02 May 2022 10:09:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651511366; cv=none; d=google.com; s=arc-20160816; b=WlzUpTUPxADNd7aNPDb2az5KdPrSjoShEVE5lCxN4ocZ7f3yiDn/n66dra8F+pYWIS UsxOzDmlu8khoYJzCDYMMif1k9MTZjC7xW/IikeB2VGM73OsLqEO9Pk0xgxTpdZySbg1 8TImFUvSlvJ9AlDj9UEDkbw/4qP0dze/k568QgFmHumjF6NU919OA8zUrsXu6GUeUnSU V7ol0C7/McNZbYqdRmZXPkQhH31frKv6oJK14JPOhhpUyDN6ZiU7RPRk/o0wf+5XMJU2 6NJ8l2hTCyP/ZwKs5rwXyqo513sGA3D3ij5jr8ML7oskcsXvIQXfTU+yMV07jbcsQ2EP cRfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=mZrRXivk2wHB6aP0PlOgj0l6NkbmTRIad+kjRkIeDR4=; b=TtmseTzhPkjyOfNcakuegYDDa5Chhy1V2LrTDMVRGqVuW04RB66aVm5wnCrVCBzUub /XqdKYGawIyk9qqgZ0zeRo9ofReRJi8HALTvAKuILS3Zwb/ito84rxtqLixcrMGPdqjL xobv0kTrejnnCpGuzwlLQRscbyXlPhJ4S9T7rL5ZFilpjk2Z/Jb31DzDYRd1Wx7K101F xKhq0/3GNXlFzXBFBay5EDNzF5px6UiRm3jYjFlkzCgKNbMV8xB+9rkiKnvhv/gaTO8G RDTt6P+MD5URYBnfYiAswJpoX/CK2TS0RiKBPnjoRsCrP0LPhKaGOYNsgdJMsZb+ZYV9 bENg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=okvLxUXU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a5-20020a170902ecc500b00153b2d1653asi15529044plh.322.2022.05.02.10.09.09; Mon, 02 May 2022 10:09:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=okvLxUXU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382330AbiD3HwG (ORCPT + 99 others); Sat, 30 Apr 2022 03:52:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1382327AbiD3HwD (ORCPT ); Sat, 30 Apr 2022 03:52:03 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA14212ACE for ; Sat, 30 Apr 2022 00:48:42 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id g20so11365020edw.6 for ; Sat, 30 Apr 2022 00:48:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mZrRXivk2wHB6aP0PlOgj0l6NkbmTRIad+kjRkIeDR4=; b=okvLxUXU58ImUVPXvh6rNI6m4QzadLdDcLGXEGPUyv9KGiS2NPKYVe946bsjLYLXwv YRFTyVmLfH/YWVpfSLJK4i5y+WFUwqBvXi763VpFWdkSmcP9fozdztpG1pzrha91qisc mWE3DAhtx7dhBykXPoQj8qymxGRx1b6nrOZIsDI268dIx+JscS9dy7hMEPkqdRqKl6LA qyYV0Xl7k98kWbe2UhrKXN9VGuF6bAVp4vrgCKhkwo5wzZOODYVyK/4Bb7QjjGj54Uj6 lu2AXLaKYRgnxKTaGfTszgLPOJcTjslJv+lTdPjocdIutm0pH6d1jg9vevfBxJ0d0QZO WRRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mZrRXivk2wHB6aP0PlOgj0l6NkbmTRIad+kjRkIeDR4=; b=1fTlVPl0a0O1MisDh9e87bj0WeSLgODQO+Dndc/tdilflq7GkKh1UjN/7SShScB8Tj 0DRg6AZxrtmZozvrQyp+VJdC2miVpyDWqRsihkPFZTqeyADIGToEZ4RhARl52pqMjgUq BFaEPj26QOf7IHmtUFnpxrq5MUeMPR6ANHnBL/KFo/dDRou4XZvDFwQlF8EHxenidP8R yJmlateK90ngKclQCv5nGBIlGlpj7a2gqC/XhhkxXRzoxTf1FUlcAYTqGu+SnZn9zsi3 K4HQWWdPzTOnuDWWxvnwf3hjFvVrc2qPbMs2sySd+YKedJOfs1gjdu8JYxVT3wd2pFYB UYgA== X-Gm-Message-State: AOAM532msStTHWqD9oH99TOFbbEmYLAmqe9Cd3qLnoIjdx1Tjt1GPiGm lfHOwnYl2r1J+rhlWQ6hZFfZeOfrbYFJreXrytft2f+EPNw32w== X-Received: by 2002:a05:6402:1e8b:b0:41c:59f6:2c26 with SMTP id f11-20020a0564021e8b00b0041c59f62c26mr3397468edf.156.1651304921031; Sat, 30 Apr 2022 00:48:41 -0700 (PDT) MIME-Version: 1.0 References: <20220429181259.622060-1-dlatypov@google.com> <20220429181259.622060-4-dlatypov@google.com> In-Reply-To: <20220429181259.622060-4-dlatypov@google.com> From: Brendan Higgins Date: Sat, 30 Apr 2022 03:48:29 -0400 Message-ID: Subject: Re: [PATCH v2 4/4] kunit: fix debugfs code to use enum kunit_status, not bool To: Daniel Latypov Cc: davidgow@google.com, linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 29, 2022 at 2:13 PM Daniel Latypov wrote: > > Commit 6d2426b2f258 ("kunit: Support skipped tests") switched to using > `enum kunit_status` to track the result of running a test/suite since we > now have more than just pass/fail. > > This callsite wasn't updated, silently converting to enum to a bool and > then back. > > Fixes: 6d2426b2f258 ("kunit: Support skipped tests") > Signed-off-by: Daniel Latypov Reviewed-by: Brendan Higgins