Received: by 2002:a19:651b:0:0:0:0:0 with SMTP id z27csp26984lfb; Mon, 2 May 2022 11:33:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmlUA4+2eRkVKZRX4rIJneO4ykrjcjGEO0xuzE3PZZv83+CVKpsOK4JuH6oKTpGLC0KZTa X-Received: by 2002:a17:90b:380b:b0:1dc:6d24:76ff with SMTP id mq11-20020a17090b380b00b001dc6d2476ffmr554819pjb.42.1651516409407; Mon, 02 May 2022 11:33:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651516409; cv=none; d=google.com; s=arc-20160816; b=WZfOjIEuXg3fyhAJJHFAMYbLg2wxt37wlE+R+aY8suXLMcnxkPUgBE6BoomLceB6Ow +jLAcAdGBNKyu+Z/6K6TC179B3siv63LDw5R8nLL2HeHosn7HgKsm/LlfzTPRZXaOoFN RljQh/IXhf9ht8sjnnQBs3xoX7n3zPbBjNzRwqMZWO9Pgfhjk788iUF04k9Nj+t3nV8x cxuZhrniNlEG8QL1l5OxogQPvqfCtzzYntqYBHCm0plTBZuLrdyBoAtiRZlWQ6QYtTyV K81tISnivy5w7diMw1W/3JoFvXIKhrUYxH8zKfaGBlldn4WbKgYFWD3U7INUeFzVRjD1 nN4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=A+MaIi7QA1OyD7KqkBXFYMu7tXkekT7QWDjHAkHv4Vc=; b=WGiTsjPH8WuUqAZQOhRKUKHdsmSoGLTVft2REh3lmqf4KjxxDlCK+lGnUf2govY5g8 0YKylCekHumsWg/p4AhVlT/iB95QnqL9EuZTcdfaVH71DEpIx38vYD79oJroCjRg/Muq 2Na8J8SIN9r88sAU03DOgV/1JjlpG1ZNCCbwuLm4dAcimIlfy8EH/1fHMvc3kgjcITBH oB1++nguz+wFr87bGUNBBYtTRCpXNSrVo5mg+XjLCB66wcw/3iqBzPwbUe8EskCxpwwc VsXy1GEn82UK5hJPI0qgHHmHn7hZNf4G012sbRiKppr0aD1XC5iQY9KicfGxXbGGj9Kw rQaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x184-20020a6263c1000000b0050d5174ec09si13789178pfb.332.2022.05.02.11.33.11; Mon, 02 May 2022 11:33:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359753AbiD2N1T (ORCPT + 99 others); Fri, 29 Apr 2022 09:27:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232889AbiD2N1R (ORCPT ); Fri, 29 Apr 2022 09:27:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA4C5C8651; Fri, 29 Apr 2022 06:23:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6171F62298; Fri, 29 Apr 2022 13:23:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1EA1C385A4; Fri, 29 Apr 2022 13:23:52 +0000 (UTC) Date: Fri, 29 Apr 2022 09:23:51 -0400 From: Steven Rostedt To: Sergei Shtylyov Cc: "Guilherme G. Piccoli" , akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org Subject: Re: [PATCH 17/30] tracing: Improve panic/die notifiers Message-ID: <20220429092351.10bca4dd@gandalf.local.home> In-Reply-To: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-18-gpiccoli@igalia.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Apr 2022 12:22:44 +0300 Sergei Shtylyov wrote: > > + switch (ev) { > > + case DIE_OOPS: > > + do_dump = 1; > > + break; > > + case PANIC_NOTIFIER: > > + do_dump = 1; > > + break; > > Why not: > > case DIE_OOPS: > case PANIC_NOTIFIER: > do_dump = 1; > break; Agreed. Other than that. Acked-by: Steven Rostedt (Google) -- Steve