Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0b18fbcb-97d6-fb82-25b4-1f288a65b78f@redhat.com>
Date:   Sat, 30 Apr 2022 10:11:56 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v3] KVM: SEV: Mark nested locking of vcpu->lock
Content-Language: en-US
To:     Hillf Danton <hdanton@sina.com>
Cc:     Peter Gonda <pgonda@google.com>,
        Sean Christopherson <seanjc@google.com>,
        LKML <linux-kernel@vger.kernel.org>
References: <20220407195908.633003-1-pgonda@google.com>
 <CAFNjLiXC0AdOw5f8Ovu47D==ex7F0=WN_Ocirymz4xL=mWvC5A@mail.gmail.com>
 <CAMkAt6r-Mc_YN-gVHuCpTj4E1EmcvyYpP9jhtHo5HRHnoNJAdA@mail.gmail.com>
 <CAMkAt6r+OMPWCbV_svUyGWa0qMzjj2UEG29G6P7jb6uH6yko2w@mail.gmail.com>
 <62e9ece1-5d71-f803-3f65-2755160cf1d1@redhat.com>
 <CAMkAt6q6YLBfo2RceduSXTafckEehawhD4K4hUEuB4ZNqe2kKg@mail.gmail.com>
 <4c0edc90-36a1-4f4c-1923-4b20e7bdbb4c@redhat.com>
 <CAMkAt6oL5qi7z-eh4z7z8WBhpc=Ow6WtcJA5bDi6-aGMnz135A@mail.gmail.com>
 <CAMkAt6rmDrZfN5DbNOTsKFV57PwEnK2zxgBTCbEPeE206+5v5w@mail.gmail.com>
 <20220429010312.4013-1-hdanton@sina.com>
 <20220429114012.4127-1-hdanton@sina.com>
 <20220430015008.4257-1-hdanton@sina.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
In-Reply-To: <20220430015008.4257-1-hdanton@sina.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/30/22 03:50, Hillf Danton wrote:
> 	lock for migration
> 	===
> 	kvm_for_each_vcpu(i, vcpu, kvm) {
> 		if (mutex_lock_killable(&vcpu->mutex))
> 			goto out_unlock;
> 		lockdep_copy_map(&vcpu->v_dep_map, &vcpu->mutex.dep_map);
> 		mutex_release(&vcpu->mutex.dep_map, ip);
> 	}
> 
> 
> 	unlock for migration
> 	===
> 	kvm_for_each_vcpu(i, vcpu, kvm) {
> 		lockdep_copy_map(&vcpu->mutex.dep_map, &vcpu->v_dep_map);
> 		/*
> 		 * Or directly acquire without v_dep_map added
> 		 *
> 		mutex_acquire(&vcpu->mutex.dep_map, 0, 1,_RET_IP_);
> 		 */
> 		mutex_unlock(&vcpu->mutex);
> 	}

Yes this is exactly what Peter is doing, except that we're trying to 
keep one lock taken.  Thanks for pointing to lock_sock_nested().

Paolo