Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp70734iob; Mon, 2 May 2022 13:21:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhCAJSQN4EjTZXUYfealkzv8UZ4HgjK48t0M63YAqxMWObERcAY+9ftH4HZVOnX6CGLs89 X-Received: by 2002:a63:d301:0:b0:3c1:7361:b260 with SMTP id b1-20020a63d301000000b003c17361b260mr11334428pgg.367.1651522865485; Mon, 02 May 2022 13:21:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651522865; cv=none; d=google.com; s=arc-20160816; b=GeFhuEgCewyKWlqKRT7za5ycyxio9ESiU3rwWOr0GZeSMge9PXRXXmGXlPVd7BX6eg pP/Iu9cyJVcDVRmue8+TK5b8r5dFBtZ/FLJOD0aDvCdQztthjiVyVUbFMIjoYhNbXQIO GZsMyywjvx0gjhxLZasgnfviQzI9KJpRF5BxWL7g+/2Xw5ByLQ69ZdpNHfaEIwEyuz+d SqcVxJtPZYwUHewDwkxPi0c9E/BIpMJr7Q/1hklSxXVqq5BqSw2PUtNoHvsFvqXbK4z+ rHmMzYLXG1MrMvQJFJLvtrQA6JzpW3tg9TJwDZlXm6/gLZsTgjpFJ6FFduVT+6U8rBim LTmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=W0I4pY7mfAutmHEfxPqDI8zjrs8eBxpGZgryM83yNCk=; b=IC+Grj7+/itpthOJpQRG1LLSYjiFdodZE2F/LXrC4Qb8pCf4rw3djCBxJ9BkgWy2Kh cayA2TMT+7HWh0YZwp7eexalxzvxQzr0/koGZ5c71nXaYepJFROzpe6NCtF+bT2lGMDs MNadZkDIbdf2RnUPZWX+yN+MzEtz4nM5CY98ez7FnOH37LnvyJlccoF1VYG8gK4xpch8 +xXYKCQ1u1WshzuE/y3re5WNNilBaLuzQbOV2Hoi6RN13LtBEC2kGHKAjqrj3BDIEfq4 dGrio5oCVd++eL0MSFS+zkfCgK1XJ9OuACb+kS+ugZM5Jk/Y9XlqCUgRaWRAWKIP/a9o 701Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZZCQGoWv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k12-20020a170902c40c00b00153b2d16437si16520043plk.63.2022.05.02.13.20.48; Mon, 02 May 2022 13:21:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZZCQGoWv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355432AbiD2KuJ (ORCPT + 99 others); Fri, 29 Apr 2022 06:50:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358016AbiD2Kso (ORCPT ); Fri, 29 Apr 2022 06:48:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 525B9C8AA8; Fri, 29 Apr 2022 03:43:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D6C5360B15; Fri, 29 Apr 2022 10:43:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8570C385A4; Fri, 29 Apr 2022 10:43:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651229029; bh=chYWdVCwLYCkoS3s+WNC+GZc3yc/Mii7zUuagoK0GBA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZZCQGoWv2vZY3Wpdobt5rj70ote/+srNFbxZAij5bqhTaMdRjl3L9inN+5rS1/ZiL 8TwGYmOuZjBVPWs2XcBv80zVo7akvp2UE23zogexS1FpE7q8M3noXHil9eGP0vZD/+ 4/paRgtA+NVCk/aEW5gf+orbv3gUE3FVYOKwAWWk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hao Luo , Alexei Starovoitov Subject: [PATCH 5.15 07/33] bpf: Convert PTR_TO_MEM_OR_NULL to composable types. Date: Fri, 29 Apr 2022 12:41:54 +0200 Message-Id: <20220429104052.557380642@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220429104052.345760505@linuxfoundation.org> References: <20220429104052.345760505@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hao Luo commit cf9f2f8d62eca810afbd1ee6cc0800202b000e57 upstream. Remove PTR_TO_MEM_OR_NULL and replace it with PTR_TO_MEM combined with flag PTR_MAYBE_NULL. Signed-off-by: Hao Luo Signed-off-by: Alexei Starovoitov Link: https://lore.kernel.org/bpf/20211217003152.48334-7-haoluo@google.com Cc: stable@vger.kernel.org # 5.15.x Signed-off-by: Greg Kroah-Hartman --- include/linux/bpf.h | 1 - kernel/bpf/btf.c | 2 +- kernel/bpf/verifier.c | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) --- a/include/linux/bpf.h +++ b/include/linux/bpf.h @@ -502,7 +502,6 @@ enum bpf_reg_type { PTR_TO_SOCK_COMMON_OR_NULL = PTR_MAYBE_NULL | PTR_TO_SOCK_COMMON, PTR_TO_TCP_SOCK_OR_NULL = PTR_MAYBE_NULL | PTR_TO_TCP_SOCK, PTR_TO_BTF_ID_OR_NULL = PTR_MAYBE_NULL | PTR_TO_BTF_ID, - PTR_TO_MEM_OR_NULL = PTR_MAYBE_NULL | PTR_TO_MEM, /* This must be the last entry. Its purpose is to ensure the enum is * wide enough to hold the higher bits reserved for bpf_type_flag. --- a/kernel/bpf/btf.c +++ b/kernel/bpf/btf.c @@ -5719,7 +5719,7 @@ int btf_prepare_func_args(struct bpf_ver return -EINVAL; } - reg->type = PTR_TO_MEM_OR_NULL; + reg->type = PTR_TO_MEM | PTR_MAYBE_NULL; reg->id = ++env->id_gen; continue; --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -13135,7 +13135,7 @@ static int do_check_common(struct bpf_ve mark_reg_known_zero(env, regs, i); else if (regs[i].type == SCALAR_VALUE) mark_reg_unknown(env, regs, i); - else if (regs[i].type == PTR_TO_MEM_OR_NULL) { + else if (base_type(regs[i].type) == PTR_TO_MEM) { const u32 mem_size = regs[i].mem_size; mark_reg_known_zero(env, regs, i);