Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 29 Apr 2022 13:47:26 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Kalesh Singh <kaleshsingh@google.com>
Cc:     mark.rutland@arm.com, will@kernel.org, maz@kernel.org,
        qperret@google.com, tabba@google.com, surenb@google.com,
        kernel-team@android.com, James Morse <james.morse@arm.com>,
        Alexandru Elisei <alexandru.elisei@arm.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Peter Collingbourne <pcc@google.com>,
        Alexei Starovoitov <ast@kernel.org>,
        "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com>,
        Andrew Jones <drjones@redhat.com>,
        Zenghui Yu <yuzenghui@huawei.com>,
        Keir Fraser <keirf@google.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] KVM: arm64: Compile stacktrace.nvhe.o
Message-ID: <YmveXly9117jbWKr@sirena.org.uk>
References: <20220427184716.1949239-1-kaleshsingh@google.com>
 <20220427184716.1949239-2-kaleshsingh@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Y3YSke25lSrZY+/w"
Content-Disposition: inline
In-Reply-To: <20220427184716.1949239-2-kaleshsingh@google.com>
Precedence: bulk


--Y3YSke25lSrZY+/w
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Apr 27, 2022 at 11:46:56AM -0700, Kalesh Singh wrote:

> Recompile stack unwinding code for use with the nVHE hypervisor. This is
> a preparatory patch that will allow reusing most of the kernel unwinding
> logic in the nVHE hypervisor.

This is substantially more than just the build change that the changelog
would seem to indicate...  it would I think be clearer to split this up
further with the code changes separated out and explained a bit more.
It's not just recompling the code for nVHE, there's also refactoring to
split out changes that don't apply in nVHE hypervisor like all the task
related code which is needed but not mentioned in the changlog at all.
Possibly a patch or two for the code motion then a separate patch for
the ifdefs and build changes?

I *think* the code is all fine but I'd need to go through it a few more
times to be sure I didn't miss anything.

--Y3YSke25lSrZY+/w
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJr3l0ACgkQJNaLcl1U
h9DBXAf/cLhAZeKbkJs3LEkvnKGiulU0FIY+O9WBWvNL1mfn2AlN4TJrfv6vBsg9
DvcKZBSqLs1cPow78FoQoKxyhXLW93diLBiFnHQbRSpxTRDJNv5dln5BApd/rX1x
UGKUFo2BXhBdes9xUpXQcnbVp3uLHWA7T3kzsr9yz5idTnhWd+51DLQYLHvJRo/n
byZODs7JPbiSyB/28DKkQy+/gVSj9vP+gOsXDRBNDECWr19FDcbXje2TYWfV6aUK
3COthbPNESl1tPvLfUuDTCjPTOhaKCAkIIXt7uDk5ofr74AHqR2r05Tfz+R0o6SB
OMVfgIypmtPQ2B246uUEOGwDwJAJYQ==
=vcwd
-----END PGP SIGNATURE-----

--Y3YSke25lSrZY+/w--