Subject: Re: [PATCH 1/2] leds:arch/sh/boards/landisk LEDs supports
From: Richard Purdie <rpurdie@rpsys.net>
To: kogiidena@eggplant.ddo.jp
Cc: linux-kernel@vger.kernel.org, lethal@linux-sh.org
In-Reply-To: <2490.192.168.1.10.1178720780.squirrel@eggplant.ddo.jp>
References: <1743.192.168.1.10.1178627210.squirrel@eggplant.ddo.jp>
	 <1178628889.6061.33.camel@localhost.localdomain>
	 <2490.192.168.1.10.1178720780.squirrel@eggplant.ddo.jp>
Content-Type: text/plain
Date: Wed, 09 May 2007 16:13:14 +0100
Message-Id: <1178723594.6291.21.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1220
Lines: 42

On Wed, 2007-05-09 at 23:26 +0900, kogiidena wrote:
> Hi Richard-san
> 
> The following three points were corrected.
> 
> 1.
> > You can't do this since the trigger will appear for all LEDs and it only
> > applies to a single LED. There has been previous discussion of LED
> > specific triggers and we'll need that support before you can make
> > something like this work. Nobody has sent me a patch for that yet and I
> > haven't had time to write one...
> The trigger name past "disk" was changed to the name "hard".
> This is to mean the hardware of LANDISK controls LED.
> The problem of "LED specific triggers" is solved.

No, its not solved.

Imagine I connect some device with its own LEDs and LED drivers. I'll
use "corgi:amber" as an example.

I run:

'cat /sys/class/leds/corgi:amber/triggers'

I see "hard" listed.

'echo "hard" > /sys/class/leds/corgi:amber/triggers'

doesn't work though...

If its not going to work, it shouldn't be listed.

Regards,

Richard


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/