Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220429054841.3851915-1-chi.minghao@zte.com.cn>
In-Reply-To: <20220429054841.3851915-1-chi.minghao@zte.com.cn>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 29 Apr 2022 11:16:52 -0400
Message-ID: <CADnq5_Oo4KM+Jjiy8b+42UAP5PhaEMp76zS7gi3iRua2jTyUPQ@mail.gmail.com>
Subject: Re: [PATCH] drm/amdgpu: simplify the return expression of iceland_ih_hw_init
To:     CGEL <cgel.zte@gmail.com>
Cc:     "Deucher, Alexander" <alexander.deucher@amd.com>,
        Dave Airlie <airlied@linux.ie>, Zeal Robot <zealci@zte.com.cn>,
        xinhui pan <Xinhui.Pan@amd.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Christian Koenig <christian.koenig@amd.com>,
        Minghao Chi <chi.minghao@zte.com.cn>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks!

On Fri, Apr 29, 2022 at 1:48 AM <cgel.zte@gmail.com> wrote:
>
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Simplify the return expression.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
>  drivers/gpu/drm/amd/amdgpu/iceland_ih.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/iceland_ih.c b/drivers/gpu/drm/amd/amdgpu/iceland_ih.c
> index ddfe4eaeea05..aecad530b10a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/iceland_ih.c
> +++ b/drivers/gpu/drm/amd/amdgpu/iceland_ih.c
> @@ -308,14 +308,9 @@ static int iceland_ih_sw_fini(void *handle)
>
>  static int iceland_ih_hw_init(void *handle)
>  {
> -       int r;
>         struct amdgpu_device *adev = (struct amdgpu_device *)handle;
>
> -       r = iceland_ih_irq_init(adev);
> -       if (r)
> -               return r;
> -
> -       return 0;
> +       return iceland_ih_irq_init(adev);
>  }
>
>  static int iceland_ih_hw_fini(void *handle)
> --
> 2.25.1
>
>