Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 29 Apr 2022 17:06:04 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Bart Van Assche <bvanassche@acm.org>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org
Subject: [bvanassche:ufs-for-next 6/6] drivers/ufs/core/ufshcd.c:5430
 ufshcd_uic_cmd_compl() error: we previously assumed 'priv->active_uic_cmd'
 could be null (see line 5418)
Message-ID: <202204292110.C5vOQk2e-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nGXCueMCMFDMsjJj9bE4I0Uc020dXL2jrKZ+HRAE3UC4589URqmcqhxTcmy0?=
 =?us-ascii?Q?Z/dqGEcaYh8U6F7I4g7DINPf1P3K3Mr3SyoIB6p0U9CT8Q3Lx2iWQ5n+TG8U?=
 =?us-ascii?Q?7FSCiQeDMBV6ZogM97eQEj7Wwwo7uwqEg37sUFRtJEAqdRfoGLCPKyW7Kv8u?=
 =?us-ascii?Q?VUkMSB0qPzeCIvXv4UAB1bVMYNbTmeudJ/b0lFpWJ+0Na1rnQYmncK9oYxyK?=
 =?us-ascii?Q?wqbDa0TVBlfraSg80i9po3WFtzdFSBsj9atcTXyI1TC4elzKK//Tto8aT22q?=
 =?us-ascii?Q?+YtjzMAbDRVRePcVxtSuIw80NTQgTqXLhnKfEHsNDpWRlUn0SlBg5PwgUYnp?=
 =?us-ascii?Q?HNOOKa3hAsOuoHnus0wB8TSVxxPIz7V6WhAeOaT/Fzq5kMlM8qOGZFWuymM8?=
 =?us-ascii?Q?VJr+9uekoAbIcLx8Dk4yD+wyY8REG3TOZLwM66QFF8XE2mIZtJ0rDnadUhrj?=
 =?us-ascii?Q?7/YHG30Rz2N3m73zGr9wTVny0dlnmCb8GYgEOlGNymJsJelU6QFwfvRWqZsQ?=
 =?us-ascii?Q?XrZ/rkLVx0T5a6Z1P/vs4OuyBzDBOvQJgCG+bCy2D4WYEW7isr5AUN9knmPr?=
 =?us-ascii?Q?v76iu6Sg+aTrkjlEPaU/00qHgsPhnGYsRw+80q5ggvHyf5YSp8nmwdQ2PLUW?=
 =?us-ascii?Q?8RhFa/RjIq4KXJcLG9M6R+hNcvbmNqMJhPtvKJ/Jquq4lgvk/a4NTT4WF3T2?=
 =?us-ascii?Q?09MpKavZq/GiHnYvM1t0jcwmpySBZoMCHWnMIGcpVvwZmHJGo66UfyaC1r4Z?=
 =?us-ascii?Q?nK/Y45Fm81WVGeqAR/t4OnSvkm07Tj8bgaNtaz53TmJOUlADOjc0Z1vZHoFu?=
 =?us-ascii?Q?ROXpLa5RomigeOPuj5VkvFlirMTa8AGhzaUWchrIoVSs0gg6QQLO9vpMnaES?=
 =?us-ascii?Q?cxaGlpZjCmiK/yE/2OQbVBAxEBL0EWs09PBj8WiVWvKivW4jOJ4GvhXQR0Y0?=
 =?us-ascii?Q?7SlrKFXmbInNAaRCiwntn7vCRoYr9DY91n/64MtLR0GXhjMIvuCLtuSqOFwb?=
 =?us-ascii?Q?fotf+HyjfY7su5S/s0MVff9UhCnihe4Lf9U1rB8TRA6DeT0NeMZGjidVHK9Z?=
 =?us-ascii?Q?z1tS9QQabF6/JN9DW8PhzOurM1YDSV+AoJBKJoS9eHnN4/njgAbrPcDYqZj5?=
 =?us-ascii?Q?tM/MnDgK2UtpSJOr5+XnpphcogSvqBLRIMbDPZAemnMfpU7MLU+FuGutm++c?=
 =?us-ascii?Q?r9RhoKMGnbONruDLnEE4RanItCbgrLbgnFyP1ElWEKi3LqI7sbIH2aJeLlK4?=
 =?us-ascii?Q?klcMGTgWeSZhQ55WeSnKfro0mCF0QlbZC2DlOuIINdehBx8fKlhYxnM7JmAK?=
 =?us-ascii?Q?jl7ZJhNS8E7cPulZaRRU5Ai+/cPglxiyiiVm+Y30coHHLpvp17F9yu5W9aql?=
 =?us-ascii?Q?j7mKGtjU4Vjude0zzfWrrKsD81puWf3wJbyjFWVLl2ZbnoqhwxeqK4eUf58/?=
 =?us-ascii?Q?eAHLbMXYXkHnDAW9I7glOADZRx/CXPAgXRx67hMz163cTcx1XZThgrp0lch/?=
 =?us-ascii?Q?7wuKSd56pWYbGcx2Z3zgzF6rwK0rRv+DgPRSn2rWBYGvUYdUgeEXsLtNVlEo?=
 =?us-ascii?Q?0pioxG1V0QN7a1wDwIU2UTyg41nrRVyWEpefLf5gR6/DZL+HD/u4vEgpWfrV?=
 =?us-ascii?Q?c6Xg77N2MI1OcV/mlWNggWRpBrsqJF2JV26lzUpHD421Zx01nNDa6SpsLSw4?=
 =?us-ascii?Q?yT2NlOw6qkVtCfqsNHTXh2MiyBMtUKs8ZzCm//3I3Fct2hCd+TPM3mVqU20b?=
 =?us-ascii?Q?CXRJ5jU1tSXXSI2UivgCmm76Vr26+Aw=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 612a84a4-0c25-4747-4836-08da29e96cc2
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 14:06:15.6543
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DROpe1eVHPdugP26ibsmyrrNc18Qyz+9CN86ZPTaT+2RkIgRVkqGaIz7cA95e/ro7rBo+dlYXfbrRA+oEPGwBlWTx1BP39cNAZZwR5T7es8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4931
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-29_04:2022-04-28,2022-04-29 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0
 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204290079
X-Proofpoint-ORIG-GUID: 2sOVkFSObRWpopI9YyWPDkNRwb996VHw
X-Proofpoint-GUID: 2sOVkFSObRWpopI9YyWPDkNRwb996VHw
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://github.com/bvanassche/linux ufs-for-next
head:   d34bcd2acd8e932a32bf1aac6296ee8ea8d230d3
commit: d34bcd2acd8e932a32bf1aac6296ee8ea8d230d3 [6/6] scsi: ufs: Split struct ufs_hba
config: nios2-randconfig-m031-20220428 (https://download.01.org/0day-ci/archive/20220429/202204292110.C5vOQk2e-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/ufs/core/ufshcd.c:5430 ufshcd_uic_cmd_compl() error: we previously assumed 'priv->active_uic_cmd' could be null (see line 5418)

vim +5430 drivers/ufs/core/ufshcd.c

9333d77573485c8 drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14  5409  static irqreturn_t ufshcd_uic_cmd_compl(struct ufs_hba *hba, u32 intr_status)
6ccf44fe4cd7c45 drivers/scsi/ufs/ufshcd.c Seungwon Jeon         2013-06-26  5410  {
d34bcd2acd8e932 drivers/ufs/core/ufshcd.c Bart Van Assche       2022-03-19  5411  	struct ufs_hba_priv *priv = container_of(hba, typeof(*priv), hba);
9333d77573485c8 drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14  5412  	irqreturn_t retval = IRQ_NONE;
9333d77573485c8 drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14  5413  
d34bcd2acd8e932 drivers/ufs/core/ufshcd.c Bart Van Assche       2022-03-19  5414  	spin_lock(priv->host->host_lock);
a45f937110fa6b0 drivers/scsi/ufs/ufshcd.c Can Guo               2021-05-24  5415  	if (ufshcd_is_auto_hibern8_error(hba, intr_status))
d34bcd2acd8e932 drivers/ufs/core/ufshcd.c Bart Van Assche       2022-03-19  5416  		priv->errors |= (UFSHCD_UIC_HIBERN8_MASK & intr_status);
a45f937110fa6b0 drivers/scsi/ufs/ufshcd.c Can Guo               2021-05-24  5417  
d34bcd2acd8e932 drivers/ufs/core/ufshcd.c Bart Van Assche       2022-03-19 @5418  	if ((intr_status & UIC_COMMAND_COMPL) && priv->active_uic_cmd) {
                                                                                                                                 ^^^^^^^^^^^^^^^^^^^^^
Check for NULL

d34bcd2acd8e932 drivers/ufs/core/ufshcd.c Bart Van Assche       2022-03-19  5419  		priv->active_uic_cmd->argument2 |=
6ccf44fe4cd7c45 drivers/scsi/ufs/ufshcd.c Seungwon Jeon         2013-06-26  5420  			ufshcd_get_uic_cmd_result(hba);
d34bcd2acd8e932 drivers/ufs/core/ufshcd.c Bart Van Assche       2022-03-19  5421  		priv->active_uic_cmd->argument3 =
12b4fdb4f6bccb5 drivers/scsi/ufs/ufshcd.c Seungwon Jeon         2013-08-31  5422  			ufshcd_get_dme_attr_val(hba);
d34bcd2acd8e932 drivers/ufs/core/ufshcd.c Bart Van Assche       2022-03-19  5423  		if (!priv->uic_async_done)
d34bcd2acd8e932 drivers/ufs/core/ufshcd.c Bart Van Assche       2022-03-19  5424  			priv->active_uic_cmd->cmd_active = 0;
d34bcd2acd8e932 drivers/ufs/core/ufshcd.c Bart Van Assche       2022-03-19  5425  		complete(&priv->active_uic_cmd->done);
9333d77573485c8 drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14  5426  		retval = IRQ_HANDLED;
6ccf44fe4cd7c45 drivers/scsi/ufs/ufshcd.c Seungwon Jeon         2013-06-26  5427  	}
53b3d9c3fdda94d drivers/scsi/ufs/ufshcd.c Seungwon Jeon         2013-08-31  5428  
d34bcd2acd8e932 drivers/ufs/core/ufshcd.c Bart Van Assche       2022-03-19  5429  	if ((intr_status & UFSHCD_UIC_PWR_MASK) && priv->uic_async_done) {
d34bcd2acd8e932 drivers/ufs/core/ufshcd.c Bart Van Assche       2022-03-19 @5430  		priv->active_uic_cmd->cmd_active = 0;
                                                                                                ^^^^^^^^^^^^^^^^^^^^^^
Unchecked dereference.

d34bcd2acd8e932 drivers/ufs/core/ufshcd.c Bart Van Assche       2022-03-19  5431  		complete(priv->uic_async_done);
9333d77573485c8 drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14  5432  		retval = IRQ_HANDLED;
9333d77573485c8 drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14  5433  	}
aa5c697988b4c7e drivers/scsi/ufs/ufshcd.c Stanley Chu           2020-06-15  5434  
aa5c697988b4c7e drivers/scsi/ufs/ufshcd.c Stanley Chu           2020-06-15  5435  	if (retval == IRQ_HANDLED)
d34bcd2acd8e932 drivers/ufs/core/ufshcd.c Bart Van Assche       2022-03-19  5436  		ufshcd_add_uic_command_trace(hba, priv->active_uic_cmd,
28fa68fc557a7eb drivers/scsi/ufs/ufshcd.c Bean Huo              2021-01-05  5437  					     UFS_CMD_COMP);
d34bcd2acd8e932 drivers/ufs/core/ufshcd.c Bart Van Assche       2022-03-19  5438  	spin_unlock(priv->host->host_lock);
9333d77573485c8 drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14  5439  	return retval;
6ccf44fe4cd7c45 drivers/scsi/ufs/ufshcd.c Seungwon Jeon         2013-06-26  5440  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp