Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 2 May 2022 12:35:48 +0300
From:   Abel Vesa <abel.vesa@nxp.com>
To:     Miaoqian Lin <linmq006@gmail.com>
Cc:     Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Dong Aisheng <aisheng.dong@nxp.com>, linux-clk@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v2] clk: imx: scu: Use pm_runtime_resume_and_get
 to fix pm_runtime_get_sync() usage
Message-ID: <Ym+l9FiG5byrF9b3@abelvesa>
References: <20220425011117.25093-1-linmq006@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220425011117.25093-1-linmq006@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lOuZk5vm55hKu4hZ09yQ8iOMqOGzSoguP5hNtEkFRGdqxRhohJ85z4HsysFa?=
 =?us-ascii?Q?zepEHPB57t8iz0KfxQdabdPfjFCdoZ37yqLgopHBSKXAJn5L8pfPCk+Q7AAm?=
 =?us-ascii?Q?jYjb6QIlzYZq1N0/+I+cDuYrnC2AHcYFeo/5iXhymiujWXaRPOVEhJ00Igri?=
 =?us-ascii?Q?zF8qPImUjpEIl1A/z1CES0SR3B3gXvdtIJJS8PevUxJ3WgJRAGr6LrForLRX?=
 =?us-ascii?Q?lQJuM1PwqZC/DeYANaJfdmca/Hqg6H8VSz/btI/z++AD7QHSSawCnIYDJkOo?=
 =?us-ascii?Q?az52g5uCuBOoYR/Na+W/s1Vloglj5/WENIckpBHVtK4bHFGM+GcbSBDjQGer?=
 =?us-ascii?Q?ejCswerQLPKbzprRZlPnsfr9Oj+34urmLmXMvB1dMjuKXNxXbsTp7nge12cq?=
 =?us-ascii?Q?+1IxK1k+gfJGQvpe4DN7syetOTd3TIz0Olyp6xI/Kz63q2wY5f6uDy8yJk3x?=
 =?us-ascii?Q?ky+3yl8C9zsAvjh93Pik9YLgSAnfSFBVv/kW75aeifdt59QmwXIhXytk9ryf?=
 =?us-ascii?Q?4odSRcRQ8ONAUTruGmT3k9kRUSYKpaL6xfOkD7RK64Ju/i8dOAiji3uF5lTE?=
 =?us-ascii?Q?A7VYOrjITg+fcXkTrMhd8t3H3yEamFsjCfQ+F3FslknpevngdnRuXazb78/y?=
 =?us-ascii?Q?d0xGjtvsm6TKdmXvdl7EgbPmGl7m3wAbAJChkJkcUTpeV493Ak/2jYtrze12?=
 =?us-ascii?Q?paVcPUJw8GqGTHRbPw6t/Gamc8Z+FENN14s34aYCanCMPni5/Yo/Q0iBcxIA?=
 =?us-ascii?Q?Gm70Y+QtKhvoMfn6x0T+kuzNADn6MepwXod21vvae5F7Z/EPMl3eR9Ryfm+Z?=
 =?us-ascii?Q?9RqLjHj//mjWyJNf+jOnF3cr0hQGOcOR+FrmgqNzv2ZWcWZGeaAAgaJEZBEX?=
 =?us-ascii?Q?xO4Lt6mPJTtdghT0ViCTq2SAUJ9dfSJWYy35YerZn6V9szWsD5Uofx7KeaXA?=
 =?us-ascii?Q?/YzePLR2yhWxT93Z5JRFslJPdlsmuB65iLvcXZq6a7r8t128EYB9BOiZVQnw?=
 =?us-ascii?Q?93UjPOuefe+pSciRn09j7DCWWAVdWr8rd+HnrpCG2Pb722Sq0fnwLDvNac5f?=
 =?us-ascii?Q?N9ke4nms+f4wKbzIs6kDXKyEca54yGASZu6Z9c/jg+vLw/WsSMXegpgHOITK?=
 =?us-ascii?Q?CyLDrwGSs+JGsMG3sJa/I1mvg1XkFvcTb5RUnnKAWEvouHectilocJFuOyPn?=
 =?us-ascii?Q?cEaTrMvHziav0XkAJdEmCaeg55PmiBQE6Dqq9Z73oWW5x1YriBN+paAhpA7O?=
 =?us-ascii?Q?U44NVTQq53qvnuN4+Q12y6aM4aZCPqO+5xhNnYSASHUu96Ax8SF+8wC6N4Rp?=
 =?us-ascii?Q?jbW+7fdjHV2lNLt//+tSlpbrBmA0VsJHYIrAcOrXu9oHzOUOV1afiW3/eFaf?=
 =?us-ascii?Q?FttRpwBU1y0ngAZ+ANSOvps1Zj1dqPdMETkbr39KN+Fak/MgCByl6tw4doHC?=
 =?us-ascii?Q?h0PGYJSfUM+gqkl8rgvITq937tm4pEXoA38qR7xCcHNzTevWmW+wowl27fIh?=
 =?us-ascii?Q?vVJHPrb6e9gPBIJLlA0C1aBdn0tUwc2YMkJinJse/0u7Cr8OsznglNYkhRd2?=
 =?us-ascii?Q?S4onWohdSLzmDLARJhpvt2fEDGAk6NH4YxzXs6S3O2dbvfh5gXvBkBwNtZ/H?=
 =?us-ascii?Q?NFoQnetqoFoif7ZzDQ95ebcYS+65fwp8/GzehA3PfPb4+ubpVSJTGuC83aul?=
 =?us-ascii?Q?reXqBaix+nSeqGfr34mP1+pbF/9tqoLiW4OC+HHqiMRywOR1wHXThIvzM4v/?=
 =?us-ascii?Q?paFt0s2qZg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65d9b82b-46eb-4bd8-999f-08da2c1f24f4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4688.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2022 09:35:50.4933
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ROTJuLQoD/aFjDP90N40zjpC2wbcunkpuRPP39g3bi8/GHuSXhmsNesznfzbAzUa0YuTpv9lpC5fabr1Qf2vGg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6123
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 22-04-25 09:11:17, Miaoqian Lin wrote:
> If the device is already in a runtime PM enabled state
> pm_runtime_get_sync() will return 1.
>
> Also, we need to call pm_runtime_put_noidle() when pm_runtime_get_sync()
> fails, so use pm_runtime_resume_and_get() instead. this function
> will handle this.
>
> Fixes: 78edeb080330 ("clk: imx: scu: add runtime pm support")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

Applied, thanks.

> ---
> changes in v2:
> - change pm_runtime_get_sync to pm_runtime_resume_and_get
> - current check works fine for pm_runtime_resume_and_get() so stay the
> same.
> Link: https://lore.kernel.org/all/20220412065719.17735-1-linmq006@gmail.com/
> ---
>  drivers/clk/imx/clk-scu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c
> index 083da31dc3ea..2044e62980e3 100644
> --- a/drivers/clk/imx/clk-scu.c
> +++ b/drivers/clk/imx/clk-scu.c
> @@ -528,7 +528,7 @@ static int imx_clk_scu_probe(struct platform_device *pdev)
>  		pm_runtime_use_autosuspend(&pdev->dev);
>  		pm_runtime_enable(dev);
>
> -		ret = pm_runtime_get_sync(dev);
> +		ret = pm_runtime_resume_and_get(dev);
>  		if (ret) {
>  			pm_genpd_remove_device(dev);
>  			pm_runtime_disable(dev);
> --
> 2.17.1
>