Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     "Weiny, Ira" <ira.weiny@intel.com>,
        Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
CC:     "outreachy@lists.linux.dev" <outreachy@lists.linux.dev>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "davem@davemloft.net" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH v5] igb: Convert kmap() to
 kmap_local_page()
Thread-Topic: [Intel-wired-lan] [PATCH v5] igb: Convert kmap() to
 kmap_local_page()
Thread-Index: AQHYVEdQ+T0ZohAO50qTE3iliBi8Jaz6p6WAgBC+BhA=
Date:   Mon, 2 May 2022 09:29:56 +0000
Message-ID: <BYAPR11MB3367A2BBE81A95AAEF6D0498FCC19@BYAPR11MB3367.namprd11.prod.outlook.com>
References: <20220419234313.10324-1-eng.alaamohamedsoliman.am@gmail.com>
 <YmGZFfcY/Yz6Iv1Y@iweiny-desk3>
In-Reply-To: <YmGZFfcY/Yz6Iv1Y@iweiny-desk3>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Z9uGFTl7+vZg2TjAtEmuv9XWsF4UtSFKCAjUUl0iwwm1tUfxfKuYOdImpS+F?=
 =?us-ascii?Q?Z4QIVQzQRQFIm9+IBum7ev321izSqX4y3D6PwXruEN2vJvCGQho7mlTJbwEX?=
 =?us-ascii?Q?BWEMY182X0ps9U2sARUJUcmNiTMCHfeJgyJ5mJs6Hr1hMwPwgFnJdvQSYju9?=
 =?us-ascii?Q?rEPg8gWB1jiVubdc8JNk83S0Rw9InDNWHYXfVZ79TbLds7MB3N6+vLPSNiyZ?=
 =?us-ascii?Q?gbmRaU17V32gmVsOz8tlLbQV+7rHiP+z8FKSDwsa+vniOsiVEXI4IDwTTijI?=
 =?us-ascii?Q?bWBNcP6sVlrvY1tQrcjruXYo167/6QYxubsCVD4xMgueW9uAQeQGIYdNfpSs?=
 =?us-ascii?Q?xGz+oxGjz+1psL9tau0BVsnuLLezZvGYN4tzLyvTLTDdkNV8pXwfTUaBVOjT?=
 =?us-ascii?Q?zVzhf+hUYmN4F7Kr0BJTMTCm5GcmFleLDavcGNkZdiFU9++qwGPymTPZHW69?=
 =?us-ascii?Q?Iw0A6X/F2mNk4bfCIn1rg30JnsSsUxYg10U09ChDmU7qSV5heHPAtCpOlgtu?=
 =?us-ascii?Q?iMMqVNJNJXnAjg5ratQ+PCZ0sjbS/CKLXDRfJsIrUpbDzi2YJFeCEM8yg9sA?=
 =?us-ascii?Q?J3XAS7AZQ0hYB9fLPrFiBBmoa1QbhktYkW9U5X3E84skhdz3Rph5n5GUahXi?=
 =?us-ascii?Q?IIkvOmuab9XswFeJQLGp1jX4dtHeyQmRfHHwCsicU1CT0gOul/Lw458d/GWZ?=
 =?us-ascii?Q?iSDDcH2KvwaoKBN4hS3fAGSXATCEfpX7YgZzEu6t8JX8Q/GIpTAho7t9QIvw?=
 =?us-ascii?Q?+Aa48Ivvd9gJ5T9egjcJoyze3x8p0YpfIszDC1Max1hQQwe/b6SCQufhiw2z?=
 =?us-ascii?Q?+E5Io3a/e0g7lFtnbyS2ssBjNr5TCmB4pr1jCNyDXDDgFovrC62Qh49fXfs2?=
 =?us-ascii?Q?R5V1wckea2wtOXXJRjs0WPO3yrN6xouMa89++1X7lv6mvzsxOREavChf82LR?=
 =?us-ascii?Q?XK+i57LePRmRzzt+ptgPZD2N2Rtgf+4zQ8WPKZiClizG4VYAlSwRM0XZbEfo?=
 =?us-ascii?Q?tOa3NepHDaYxWsrEaGChiYLtCvynCW+utLif9eyRwnd3l8mmkhgCQ4FAqoVD?=
 =?us-ascii?Q?aEL9kEya6/DULXE1zTwjLzanKkcnwmR7lFWT/BFZWk9R2IYH0O8FSJMNUmZy?=
 =?us-ascii?Q?yRkIpEKrpQemFKgYt5SRdsEds7Kgfyc/l4t38O3SWL8TP2Qik3Zt2OjxbQYd?=
 =?us-ascii?Q?XF2PWH3t3dzA6w+x/Zwyf6AgSIoL0X8fx6DS7nXixk5Pcf/1bFSVxKrf2rUn?=
 =?us-ascii?Q?t8Qd0tjiK3x+17wOPlrttfH2PibQRWf5sG2RSqRdMW+4B8eEHX8vFGNSvfka?=
 =?us-ascii?Q?ruCpZzZx2TFnx9UEDnQezSHyr/wLmDQkGXtxSFhyrjZU6JWvrHixcaEbz/cu?=
 =?us-ascii?Q?NEIEkVroihkvq88xBubBJi/wcFnlVlB1lBkDIrO2Q4lMPGG/kwUsnrK8ZDfO?=
 =?us-ascii?Q?yqt9jGvaPvIiljb0/DDCiDFXBlpR+/t8bF1PKdE6wunvvHsVtZOqm1pzb0+C?=
 =?us-ascii?Q?RBuIxtSPsScnlO0oC3DvfynzpylizmJYMs6IAWmESOvfvhgQ4Pr4F1twkoVT?=
 =?us-ascii?Q?/DsaCdApg+J/iPye3sMVoO9r4FiVjY2PySNYPcba2t56RpvoQxVCXl1S+zZT?=
 =?us-ascii?Q?o/Eq7IkvtVHEvqkrVjNF2KVpZlFcO+fP/uioIuwgQTEcZ58L5VrPWYdpywsW?=
 =?us-ascii?Q?0hKkzJuqjMJink5SXoBgSUGFNE5+k7LIam1HPbYRop161ajpl5+RdD80wT7A?=
 =?us-ascii?Q?+tDRlHcBgw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3367.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9674d0f4-0b65-4918-6ed8-08da2c1e522e
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2022 09:29:56.5137
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9RQB3CrIRsAlkIqmnxr97TCa58okxHF6Ivw/pJCAEfs6DdxghOS0Lk2yHBg3Bm2Yp/dQocAiVXKW2AmiggtwWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1746
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Ira Weiny
> Sent: Thursday, April 21, 2022 11:19 PM
> To: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> Cc: outreachy@lists.linux.dev; intel-wired-lan@lists.osuosl.org; linux-
> kernel@vger.kernel.org; netdev@vger.kernel.org; kuba@kernel.org;
> pabeni@redhat.com; davem@davemloft.net
> Subject: Re: [Intel-wired-lan] [PATCH v5] igb: Convert kmap() to
> kmap_local_page()
>=20
> On Wed, Apr 20, 2022 at 01:43:13AM +0200, Alaa Mohamed wrote:
> > kmap() is being deprecated and these usages are all local to the
> > thread so there is no reason kmap_local_page() can't be used.
> >
> > Replace kmap() calls with kmap_local_page().
> >
> > Signed-off-by: Alaa Mohamed
> <eng.alaamohamedsoliman.am@gmail.com>
>=20
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
>=20
> > ---
> > changes in V2:
> > 	fix kunmap_local path value to take address of the mapped page.
> > ---
> > changes in V3:
> > 	edit commit message to be clearer
> > ---
> > changes in V4:
> > 	edit the commit message
> > ---
> > changes in V5:
> > 	-edit commit subject
> > 	-edit commit message
> > ---
> >  drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >

Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Int=
el)