Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 2 May 2022 12:18:10 +0200
From:   Heiko Carstens <hca@linux.ibm.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Liam Howlett <liam.howlett@oracle.com>,
        Guenter Roeck <linux@roeck-us.net>,
        "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Yu Zhao <yuzhao@google.com>, Juergen Gross <jgross@suse.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>
Subject: Re: [PATCH v8 23/70] mm/mmap: change do_brk_flags() to expand
 existing VMA and add do_brk_munmap()
Message-ID: <Ym+v4lfU5IyxkGc4@osiris>
References: <20220426150616.3937571-1-Liam.Howlett@oracle.com>
 <20220426150616.3937571-24-Liam.Howlett@oracle.com>
 <20220428201947.GA1912192@roeck-us.net>
 <20220429003841.cx7uenepca22qbdl@revolver>
 <20220428181621.636487e753422ad0faf09bd6@linux-foundation.org>
 <20220502001358.s2azy37zcc27vgdb@revolver>
 <20220501172412.50268e7b217d0963293e7314@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220501172412.50268e7b217d0963293e7314@linux-foundation.org>
Precedence: bulk

On Sun, May 01, 2022 at 05:24:12PM -0700, Andrew Morton wrote:
> (cc S390 maintainers)
> (cc stable & Greg)
> 
> > I have been porting my patches over and hit a bit of a snag. It looked
> > like my patches were not booting on the s390 - but not all the time. So
> > I reverted back to mm-stable (059342d1dd4e) and found that also failed
> > to boot sometimes on my qemu setup.  When it fails it's ~4-5sec into
> > booting.  The last thing I see is:
> > 
> > "[    4.668916] Spectre V2 mitigation: execute trampolines"
> > 
> > I've bisected back to commit e553f62f10d9 (mm, page_alloc: fix
> > build_zonerefs_node())
> > 
> > With the this commit, I am unable to boot one out of three times.  When
> > using the previous commit I was not able to get it to hang after trying
> > 10+ times.  This is a qemu s390 install with KASAN on and I see no error
> > messages.  I think it's likely it is this patch, but no guaranteed.
> > 
> 
> Great, thanks.  So mapletree is absolved.
> 
> Unfortunately 059342d1dd4e was cc:stable.  Greg, you might want to pull
> the plug on that one if it isn't too late.
> 
> I'll await input from the S390 team, but from my reading the issues
> which that patch addresses aren't terribly serious, so perhaps the
> thing to do is to revert 059342d1dd4e (with a cc:stable) while
> 059342d1dd4e gets a redo?

I cannot confirm that Linus' tree currently has problems on s390 with
commit e553f62f10d9 ("mm, page_alloc: fix build_zonerefs_node()").

This commit was applied by Linus on 15th of April, and our CI didn't
report any problems since then. At least nothing that would point to
this commit. Also I just gave e553f62f10d9 a try (defconfig + KASAN):
no problems to report.

Same with 059342d1dd4e (mm-stable): it just works for me.

Liam, could you share your kernel config?