Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
IronPort-SDR: kddDcvBS6R2HfoNAHsUa9V3S0rXmsg/TF4c25Ee7txglgP2WMxnll/B0hlrbZY3ZjXZiXIqRj7
 cwJiAu1P5o5rRojuvlUukjdEfFzpfAstkLqY8mN7B7ZtLvT5KasnM5kpnHfZP/Iq+7xYc82Qli
 Iivg4EHsK/EM6WFutnJTcHxbXZFNMkbf1EoCyPYV4yn8rCP5k6aF37jAJFezk5Ah4KYnBH2MR9
 ODB2Lvwi4Lz9waFYTgSTkmP8Ge8yx4UpFCfXCePQMHIJZB/upsO1svRTPoUDZXSyft1WucWG3s
 XJMbF//aSgjQ90RZNzDkfhwS
IronPort-SDR: k1tLm23ENrgoTVkoVgCXeEXKLoocGfta+SwSFdtjXzqwie+9iY2a9MmTHH59PwRrtmqpvFgHCO
 kmOibrY1sO1PTN4qMMAwdqDqq1vRkL6PkF4h4BQudp3C7Dzn+tBFaL4WhsyX2+e+pbgX++wgsQ
 Ap0C9t2HNZfkLmNsP1JqjvJEfDm+TUj+fyIuPZWoIYjzsl+pykN59rTooBfuMZ7OhTJI4Hta9G
 r139Hd2oIVGMbmhYBjtQ0jA+XFDreNdjK5wesWkyTRpjsLgKn7QpPZ9H/k7Egy6Kd1IhAipIjw
 uo4=
WDCIronportException: Internal
Message-ID: <a6d1c61a-14f2-36dc-5952-4d6897720c7a@opensource.wdc.com>
Date:   Fri, 29 Apr 2022 06:37:18 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v4 00/10] Add Copy offload support
Content-Language: en-US
To:     Nitesh Shetty <nj.shetty@samsung.com>
Cc:     linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
        dm-devel@redhat.com, linux-nvme@lists.infradead.org,
        linux-fsdevel@vger.kernel.org, nitheshshetty@gmail.com,
        linux-kernel@vger.kernel.org
References: <CGME20220426101804epcas5p4a0a325d3ce89e868e4924bbdeeba6d15@epcas5p4.samsung.com>
 <20220426101241.30100-1-nj.shetty@samsung.com>
 <6a85e8c8-d9d1-f192-f10d-09052703c99a@opensource.wdc.com>
 <20220427124951.GA9558@test-zns>
 <c285f0da-ab1d-2b24-e5a4-21193ef93155@opensource.wdc.com>
 <20220428074926.GG9558@test-zns>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220428074926.GG9558@test-zns>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 4/28/22 16:49, Nitesh Shetty wrote:
> On Thu, Apr 28, 2022 at 07:05:32AM +0900, Damien Le Moal wrote:
>> On 4/27/22 21:49, Nitesh Shetty wrote:
>>> O Wed, Apr 27, 2022 at 11:19:48AM +0900, Damien Le Moal wrote:
>>>> On 4/26/22 19:12, Nitesh Shetty wrote:
>>>>> The patch series covers the points discussed in November 2021 virtu=
al call
>>>>> [LSF/MM/BFP TOPIC] Storage: Copy Offload[0].
>>>>> We have covered the Initial agreed requirements in this patchset.
>>>>> Patchset borrows Mikulas's token based approach for 2 bdev
>>>>> implementation.
>>>>>
>>>>> Overall series supports =E2=80=93
>>>>>
>>>>> 1. Driver
>>>>> - NVMe Copy command (single NS), including support in nvme-target (=
for
>>>>>     block and file backend)
>>>>
>>>> It would also be nice to have copy offload emulation in null_blk for=
 testing.
>>>>
>>>
>>> We can plan this in next phase of copy support, once this series sett=
les down.
>>
>> So how can people test your series ? Not a lot of drives out there wit=
h
>> copy support.
>>
>=20
> Yeah not many drives at present, Qemu can be used to test NVMe copy.

Upstream QEMU ? What is the command line options ? An example would be
nice. But I still think null_blk support would be easiest.


--=20
Damien Le Moal
Western Digital Research