Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp188995iob; Mon, 2 May 2022 16:41:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7ixfL96kpEG9yIL/MjDxyAavIeNRpNbCHc3FGRDlsxrKFt+zno9n2SRNn2ToGI3sam06y X-Received: by 2002:a17:90b:4f43:b0:1da:3cba:bd51 with SMTP id pj3-20020a17090b4f4300b001da3cbabd51mr1709893pjb.246.1651534907417; Mon, 02 May 2022 16:41:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651534907; cv=none; d=google.com; s=arc-20160816; b=Ztdu29LrYKYpUxpeCQmdpNTXmGkxJzB7yO2NZvUbI1YOAKahvYZyZZJ9EPH199vFX6 jCMXBwiyE9dJKaSinuDlYuhzalksYZBVMqyIuA96UtypWDf8AuKDjKTy/IF1tHRTN9Re oes+6lyGCLlwDvpeQOKpOMOv4n1+3Cs3T2Nr2lR67z8HwzpWDVWacyF30wdCAVEMDVnK Lsz0reYfbRWWpUKX+wd9dqnK5fhVi1PJKKoA0btlmF2GQz3dXq1JcAQvFvnrM9PTCkQO K2SCszuid+de82iCgivUl+z1HC0pkyNUg7T1KHlibjR3QIwVnnUYFxRkj1zqVuzmzHB5 Y0Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=lxRU4LE3pvOW3ivVzq+FV5/t6uMeAUpHsCxeSXoPW3M=; b=q26lxaTdsGCRNwLxaBO423QKbi2WN3yMK/Rk7bby+e5XIKODvXGKu6p6m6r+vRRs4t UTgXHt9VU89ZT7YVjLc0zADcGPxeqfaUvy1MedgF1mayQmoBI9HqMr4IcUMDJE6LrsZu zZaC2Tkaw4U2d0+NqkaUm+OL8d6VCvlagsjanIvH5DTJ2n3ApetVGMQ+IskCGSxW0TdD GXsLznA0hh7FoO98OOfsJfeTdMIUIGkKPYziDh8ebS7hbsjDkYKVztlMfg8veWWy3Tz1 3EdWn2rSdjfQAlnSbxVB4O+vBW+aAvhloUxtG/KjKH7DSx/ivD/q0zcSwIAWhMVuCZeQ J60g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=jXI2aVt7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id l1-20020a62be01000000b0050a631780bdsi14487161pff.339.2022.05.02.16.41.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 May 2022 16:41:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=jXI2aVt7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BEED465D3; Mon, 2 May 2022 16:41:16 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243003AbiD3P43 (ORCPT + 99 others); Sat, 30 Apr 2022 11:56:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242970AbiD3P41 (ORCPT ); Sat, 30 Apr 2022 11:56:27 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B1CA580C4; Sat, 30 Apr 2022 08:53:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=lxRU4LE3pvOW3ivVzq+FV5/t6uMeAUpHsCxeSXoPW3M=; b=jXI2aVt7bjb5ddwZ6Y5/6fdyjI QCFaK7Z7eTmsXS0W+gvekQj1zhc0LZx0Ufb6Iqm405H4GQNxo8lXVuwvXVaEJAAB4iA6n7QHj8wGn 3siWN5DD3CGDyxm00w0JElWRQpoPsKBkh3JkUivDHE6gRPknVFhPLlUjvh6Kpko6II4g=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nkpOy-000eIR-VZ; Sat, 30 Apr 2022 17:52:56 +0200 Date: Sat, 30 Apr 2022 17:52:56 +0200 From: Andrew Lunn To: Peter Geis Cc: "Russell King (Oracle)" , Heiner Kallweit , "David S. Miller" , Jakub Kicinski , "open list:ARM/Rockchip SoC..." , Linux Kernel Network Developers , Linux Kernel Mailing List Subject: Re: [PATCH v1] net: phy: fix motorcomm module automatic loading Message-ID: References: <20220228233057.1140817-1-pgwipeout@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Good Morning, > > After testing various configurations I found what is actually > happening here. When libphy is built in but the phy drivers are > modules and not available in the initrd, the generic phy driver binds > here. This allows the phy to come up but it is not functional. What MAC are you using? Why is you interface being brought up by the initramfs? Are you using NFS root from within the initramfs? What normally happens is that the kernel loads, maybe with the MAC driver and phylib loading, as part of the initramfs. The other modules in the initramfs allow the root filesystem to be found, mounted, and pivoted into it. The MAC driver is then brought up by the initscripts, which causes phylib to request the needed PHY driver modules, it loads and all is good. If you are using NFS root, then the load of the PHY driver happens earlier, inside the initramfs. If this is you situation, maybe the correct fix is to teach the initramfs tools to include the PHY drivers when NFS root is being used? Andrew