Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 2 May 2022 05:58:10 +0000
From:   Sebastian Ene <sebastianene@google.com>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     linux-kernel@vger.kernel.org,
        Derek Kiernan <derek.kiernan@xilinx.com>,
        Dragan Cvetic <dragan.cvetic@xilinx.com>,
        Arnd Bergmann <arnd@arndb.de>, devicetree@vger.kernel.org,
        qperret@google.com, will@kernel.org, maz@kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v4 2/2] misc: Add a mechanism to detect stalls on guest
 vCPUs
Message-ID: <Ym9y8hwuk41cf7YS@google.com>
References: <20220429083030.3241640-1-sebastianene@google.com>
 <20220429083030.3241640-3-sebastianene@google.com>
 <YmumSgiTrQUWoXsb@kroah.com>
 <e94fdd89-7b8e-eec3-4b2f-dcea55c7f0bc@roeck-us.net>
 <YmzUpr0e+eq0NUYc@kroah.com>
 <4217c96d-2fe2-fdef-3b15-b5368499f1bf@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4217c96d-2fe2-fdef-3b15-b5368499f1bf@roeck-us.net>
Precedence: bulk

On Sat, Apr 30, 2022 at 05:36:50AM -0700, Guenter Roeck wrote:
> On 4/29/22 23:18, Greg Kroah-Hartman wrote:
> > On Fri, Apr 29, 2022 at 09:51:51AM -0700, Guenter Roeck wrote:
> > > On 4/29/22 01:48, Greg Kroah-Hartman wrote:
> > > > On Fri, Apr 29, 2022 at 08:30:33AM +0000, Sebastian Ene wrote:
> > > > > This driver creates per-cpu hrtimers which are required to do the
> > > > > periodic 'pet' operation. On a conventional watchdog-core driver, the
> > > > > userspace is responsible for delivering the 'pet' events by writing to
> > > > > the particular /dev/watchdogN node. In this case we require a strong
> > > > > thread affinity to be able to account for lost time on a per vCPU.
> > > > > 
> > > > > This part of the driver is the 'frontend' which is reponsible for
> > > > > delivering the periodic 'pet' events, configuring the virtual peripheral
> > > > > and listening for cpu hotplug events. The other part of the driver
> > > > > handles the peripheral emulation and this part accounts for lost time by
> > > > > looking at the /proc/{}/task/{}/stat entries and is located here:
> > > > > https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3548817
> > > > > 
> > > > > Signed-off-by: Sebastian Ene <sebastianene@google.com>
> > > > > ---
> > > > >    drivers/misc/Kconfig       |  12 +++
> > > > >    drivers/misc/Makefile      |   1 +
> > > > >    drivers/misc/vm-watchdog.c | 206 +++++++++++++++++++++++++++++++++++++
> > > > >    3 files changed, 219 insertions(+)
> > > > >    create mode 100644 drivers/misc/vm-watchdog.c
> > > > > 
> > > > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> > > > > index 2b9572a6d114..26c3a99e269c 100644
> > > > > --- a/drivers/misc/Kconfig
> > > > > +++ b/drivers/misc/Kconfig
> > > > > @@ -493,6 +493,18 @@ config OPEN_DICE
> > > > >    	  If unsure, say N.
> > > > > +config VM_WATCHDOG
> > > > > +	tristate "Virtual Machine Watchdog"
> > > > > +	select LOCKUP_DETECTOR
> > > > > +	help
> > > > > +	  Detect CPU locks on the virtual machine. This driver relies on the
> > > > > +	  hrtimers which are CPU-binded to do the 'pet' operation. When a vCPU
> > > > > +	  has to do a 'pet', it exits the guest through MMIO write and the
> > > > > +	  backend driver takes into account the lost ticks for this particular
> > > > > +	  CPU.
> > > > > +	  To compile this driver as a module, choose M here: the
> > > > > +	  module will be called vm-wdt.
> > > > 
> > > > You forgot to name the module properly here based on the Makefile change
> > > > you made.
> > > > 
> > > > And again, as this is called a "watchdog", it seems crazy that it is not
> > > > in drivers/watchdog/
> > > > 
> > > 
> > > I disagree. It is not a watchdog driver in the traditional sense (it does
> > > not use, want to use, or need to use the watchdog driver API or ABI).
> > > Its functionality is similar to the functionality of kernel/watchdog.c,
> > > which doesn't belong into drivers/watchdog either.

Hi,

> > 
> > Ah, ok, that makes more sense, the user/kernel api is not the same.
> > Someone should put that in the changelog next time :)
> > 

I will include this in the changelog to fix the confusion.

> 
> Renaming it to "VCPU stall detector" or similar should fix the confusion.
> 

Yes I think that is a better naming.

Thanks,
Seb

> Guenter