Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <alpine.DEB.2.21.2204291523460.9383@angie.orcam.me.uk> <alpine.DEB.2.21.2204291529070.9383@angie.orcam.me.uk>
In-Reply-To: <alpine.DEB.2.21.2204291529070.9383@angie.orcam.me.uk>
From:   Stephen Zhang <starzhangzsd@gmail.com>
Date:   Sat, 30 Apr 2022 13:34:08 +0800
Message-ID: <CANubcdU99rke6AM4bQEyPNTkJbk1kMit1UVyDggTwTciTUeQMA@mail.gmail.com>
Subject: Re: [PATCH 1/2] MIPS: IP27: Remove incorrect `cpu_has_fpu' override
To:     "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Joshua Kinard <kumba@gentoo.org>, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Maciej W. Rozycki <macro@orcam.me.uk> =E4=BA=8E2022=E5=B9=B44=E6=9C=8829=E6=
=97=A5=E5=91=A8=E4=BA=94 22:57=E5=86=99=E9=81=93=EF=BC=9A
>
> Remove unsupported forcing of `cpu_has_fpu' to 1, which makes the `nofpu'
> kernel parameter non-functional, and also causes a link error:
>
> ld: arch/mips/kernel/traps.o: in function `trap_init':
> ./arch/mips/include/asm/msa.h:(.init.text+0x348): undefined reference to =
`handle_fpe'
> ld: ./arch/mips/include/asm/msa.h:(.init.text+0x354): undefined reference=
 to `handle_fpe'
> ld: ./arch/mips/include/asm/msa.h:(.init.text+0x360): undefined reference=
 to `handle_fpe'
>
> where the CONFIG_MIPS_FP_SUPPORT configuration option has been chosen.
>

Sorry, but I have a question. From the code in
arch/mips/kernel/genex.S:567, 'handle_fpe=E2=80=99=E2=80=98s
 definition is controlled by CONFIG_MIPS_FP_SUPPORT. Then how can it
still report such
error when the CONFIG_MIPS_FP_SUPPORT configuration option has been chosen.


Stephen.