Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     "Keller, Jacob E" <jacob.e.keller@intel.com>,
        Xiaomeng Tong <xiam0nd.tong@gmail.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "Raj, Victor" <victor.raj@intel.com>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "davem@davemloft.net" <davem@davemloft.net>
Subject: RE: [PATCH] ice: ice_sched: fix an incorrect NULL check on list
 iterator
Thread-Topic: [PATCH] ice: ice_sched: fix an incorrect NULL check on list
 iterator
Thread-Index: AQHYQs2qcyGuccie4kiSQSnllar1gK0Lc9/Q
Date:   Mon, 2 May 2022 08:17:32 +0000
Message-ID: <BYAPR11MB336781C93921216983F8BE3CFCC19@BYAPR11MB3367.namprd11.prod.outlook.com>
References: <20220327064344.7573-1-xiam0nd.tong@gmail.com>
 <CO1PR11MB5089C7298CC46861FF41D3E3D61D9@CO1PR11MB5089.namprd11.prod.outlook.com>
In-Reply-To: <CO1PR11MB5089C7298CC46861FF41D3E3D61D9@CO1PR11MB5089.namprd11.prod.outlook.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZKjAxYKNrEo2Q9EnLiL/L1SZTETO+wi/mINmBV9KR9ys86/Z4m//9EGxF3Ri?=
 =?us-ascii?Q?+ceUjsOgTaSDdGwNVXEWjfQPb7AzBrMfha2QEuLIPVZRjHPCfCszCGPzg+po?=
 =?us-ascii?Q?TLNUgm+7Tl55mGVlZJEvbQZC69RPWAEzGPui2n2jgVkKG8iqrcCRLCm1q/HN?=
 =?us-ascii?Q?HLN8bueb1YsRI3xuQN1FmbiNp/RQC2WTBtCsWpGuzkKaKUq9UkZXcqE0Enq/?=
 =?us-ascii?Q?NqkOR3EsZaZqhbdLTCDUjY4a6P/tqiZT7DMI6tc46bRr3R8y16wW/AGdyF3t?=
 =?us-ascii?Q?B4G3QdeE/x6RGgUOT6lhQN5weHihbdYDO0/BI/AHmxzjpwMpc7TEE5hLp4Rm?=
 =?us-ascii?Q?CxcPuhi2LKJxcFzYvPRcgVImi1/ycHMa1UBMij5dGD0kjiOqiFUbWqfSKcLg?=
 =?us-ascii?Q?QxdeJFwj8Y//qylNysUPp+lD91qhU6ZQWEnGlZMseKYAEs9kgR+PbMiYxuJV?=
 =?us-ascii?Q?4O+g1BbeGyG5PGdKxb2oz3Yc5wbsqamCv21dNsKdVwK9C3tq/S1bwGFdCHva?=
 =?us-ascii?Q?YtU8u5pUwwUt6NoiVNuQ65pqAaX38ao+g60H2SiPiPCNI4uCjVzGATL72Zvn?=
 =?us-ascii?Q?EYSqMRwvk3BSY38nVwhGCUKLwQQLTHZ/0NNKiq7QdCF5Z1j62BFbr1Og31GG?=
 =?us-ascii?Q?UWh/co//aPwSVFlOmSrma3KyHzi/RH13lPWAyb/OyJKHeGa6IqSlMVBBJin9?=
 =?us-ascii?Q?fPQZGtQVrdnbmnFq4bcebjcjI0AsHiH0WF+z91jXzXFBk5O4HnP0H6hUk7aB?=
 =?us-ascii?Q?EcPhVmj+fW3egoXYrAb6GI1jrolZpZ2cqBf1w6COrbh+SUM6CHami/PO2n89?=
 =?us-ascii?Q?kFBNzH+O3tatZlvaUHJglA+p1hk/ReiulwuHKTfliSuQr+Eqlnof3pPszD2R?=
 =?us-ascii?Q?uPIX5ZHZLm7nJq+OETMdhVjY8kOxWkdfjKzFabnSfQY0idyc1WB6mvsrA5ZZ?=
 =?us-ascii?Q?37AeN8m3NgBHNAMq5y0Fm0wH2YS6ctvoTXvKPqh+7LYZYBJ67G9bj4qBPA2X?=
 =?us-ascii?Q?s65KkfQ5SIGZKTPfkgyzZA5NF3BBSyc24SpJEt8O/ZzKcur4yEPvUY7BvZFn?=
 =?us-ascii?Q?jFM8mgFMHq9BwD+Jk6zmdlLMjGpfirf9tOXzyJ7tDqBma9pX4EGzKWbJbjYJ?=
 =?us-ascii?Q?FkLcqyHpIyW2fPVvqMGdEPgDSuoHE/2OQaVJLEOGzFAridyT9g6sG9mUjDHJ?=
 =?us-ascii?Q?/rlc79mmks4qql04iMkJZMQX3Q0/wZlayjv/CpdY+hrnrNyAqjLu0GLic5hE?=
 =?us-ascii?Q?zWdc7xmfCKepv2r+JYh3a5G1cs5trrzRai7xW8u2jkMuhOG0Gwh6C1Kgwhiv?=
 =?us-ascii?Q?VrD5NV1a7gGcamA/IN6VsgU23PGuIpXSVaQdJzaCV/ekk81uoOelbtKYi6wG?=
 =?us-ascii?Q?eTEEGM1AoCvbyHhaG7gemS6C+LKxg6RnlD47gEK1W+fl0M6SsW+yXXuEr0/f?=
 =?us-ascii?Q?eTIRG6bicxiIxy/YHaRX436RDPc1N8LJgmt5BCicXXB8hUeJ+BVdVn8Grc1+?=
 =?us-ascii?Q?PPTx2cvcGxHAZiCPz53e319wgcPGA0m8n0Yz2Z2avivTMxYW8pgYb3hxCJYQ?=
 =?us-ascii?Q?aOJBbndt25v3MnFKACKOJGEGc47FGEGcDoYPsIc8btCz2qN8XsQPI233Tq2l?=
 =?us-ascii?Q?vbRohcfMRiHPzZJTc04KcYZm2dgSh2YFgrFwfQFYOsDeakF7NQNJmirzSrpK?=
 =?us-ascii?Q?cWdJgQx5jLovHbfY7A5hJc1t1mKUT75r21Gdf5iT9rmqNDAfKrPYvh9/qm0O?=
 =?us-ascii?Q?ldvmjYlGKg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3367.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b6722e0-3082-4080-f633-08da2c1434c2
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2022 08:17:32.1881
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KEaGjIljMtlFIXS7x+Y/jnFBhdECe9ojxGDvNwU70IX1jAXqiRiHBWItxN0kfgjPR1GML3HfQ/WhYBdgqjqDeQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3590
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


-----Original Message-----
> From: Xiaomeng Tong <xiam0nd.tong@gmail.com>
> Sent: Saturday, March 26, 2022 11:44 PM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>
> Cc: Nguyen, Anthony L <anthony.l.nguyen@intel.com>;
> davem@davemloft.net; kuba@kernel.org; pabeni@redhat.com; Raj, Victor
> <victor.raj@intel.com>; intel- wired-lan@lists.osuosl.org;
> netdev@vger.kernel.org; linux- kernel@vger.kernel.org; Xiaomeng Tong
> <xiam0nd.tong@gmail.com>; stable@vger.kernel.org
> Subject: [PATCH] ice: ice_sched: fix an incorrect NULL check on list
> iterator
>
> The bugs are here:
> 	if (old_agg_vsi_info)
> 	if (old_agg_vsi_info && !old_agg_vsi_info->tc_bitmap[0]) {
>
> The list iterator value 'old_agg_vsi_info' will *always* be set and
> non-NULL by list_for_each_entry_safe(), so it is incorrect to assume
> that the iterator value will be NULL if the list is empty or no
> element found (in this case, the check 'if (old_agg_vsi_info)' will
> always be true unexpectly).
>
> To fix the bug, use a new variable 'iter' as the list iterator, while
> use the original variable 'old_agg_vsi_info' as a dedicated pointer to
> point to the found element.
>

Yep. This looks correct to me.

> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
>=20
> Thanks,
> Jake

> Cc: stable@vger.kernel.org
> Fixes: 37c592062b16d ("ice: remove the VSI info from previous agg")
> Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_sched.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>

Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Int=
el)