Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 2 May 2022 15:15:36 -0500
From:   Rob Herring <robh@kernel.org>
To:     Dave Gerlach <d-gerlach@ti.com>
Cc:     Santosh Shilimkar <ssantosh@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Tero Kristo <kristo@kernel.org>, Nishanth Menon <nm@ti.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH 2/6] dt-bindings: ti,sci: Add lpm region and
 ti,lpm-firmware-name
Message-ID: <YnA76FFG0wW1Jzrs@robh.at.kernel.org>
References: <20220421203659.27853-1-d-gerlach@ti.com>
 <20220421203659.27853-3-d-gerlach@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220421203659.27853-3-d-gerlach@ti.com>
Precedence: bulk

On Thu, Apr 21, 2022 at 03:36:55PM -0500, Dave Gerlach wrote:
> Add documentation for the lpm region which tells the ti-sci driver where
> to load the FS Stub low power mode firmware and also the
> ti,lpm-firmware-name which tells the driver which binary to load. Both
> of these are optional for normal system operation but required to
> enabled suspend-to-mem usage of Deep Sleep state.
> 
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> ---
>  .../bindings/arm/keystone/ti,sci.yaml         | 21 +++++++++++++++----
>  1 file changed, 17 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> index ec88aa88a2a0..31c783507cd0 100644
> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> @@ -42,12 +42,19 @@ properties:
>            - const: ti,am654-sci
>  
>    reg-names:
> -    description: |
> -      Specifies the debug messages memory mapped region that is optionally
> -      made available from TI-SCI controller.
> -    const: debug_messages
> +    items:
> +      - const: debug_messages
> +      - const: lpm
> +    minItems: 1
>  
>    reg:
> +    items:
> +      - description: |
> +          Specifies the debug messages memory mapped region that is optionally
> +          made available from TI-SCI controller.
> +      - description: |
> +          Specifies the lpm memory mapped region where the FS Stub low power
> +          firmware is to be loaded.
>      minItems: 1
>  
>    mbox-names:
> @@ -92,6 +99,12 @@ properties:
>      type: object
>      $ref: /schemas/reset/ti,sci-reset.yaml#
>  
> +  ti,lpm-firmware-name:

firmware-name

> +    description: |
> +      Name of binary of FS Stub low power firmware located on the
> +      firmware search path.
> +    $ref: /schemas/types.yaml#/definitions/string
> +
>  required:
>    - compatible
>    - mbox-names
> -- 
> 2.35.0
> 
>