Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp204228iob; Mon, 2 May 2022 17:08:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwuqieobHUHm8jNWOflyGJCfiOGJ+ZMAayu0jJBFqZtFvLrNoKIwgkqwQu6YHuQX1Ea4UkE X-Received: by 2002:a17:902:e886:b0:15e:8ba0:b749 with SMTP id w6-20020a170902e88600b0015e8ba0b749mr14198385plg.95.1651536511510; Mon, 02 May 2022 17:08:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651536511; cv=none; d=google.com; s=arc-20160816; b=l3/FI1VvZDWaW74R/8RC/8+9CI45cTFrkmD4JhqVNM2j+t7VtAHh205yX6Vvu3GIWA WqKTJHmcOlWZjPlBS9TnlCZr62tgKXpyJKtlMi+UhJtuOWQx6xzdS2oavbKojWL1bwX1 zC+Jex1Ud1lCEgmoTkMhAw5d/TpH5Qt1bO4LgMVXPjE6xdkgWNOkpJxJwjxhpFajb6wX h7SCr6YnRdPnBhemKbTD9ObjaAfzWbToTC18Wft7Y9jYFg8gaRfxV5/QfRdK6WblIkIe D3vcqxcRNtWlpM655U0F1ZP9gpFOhxQGHVpUW8S55AWRMtH/B5W5mHuDeBNTuGMFGmid I6Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=w1LhwQNMrIR81pgoGfXdD2VnVhxxrynKD+8D+/tm5Ag=; b=OnQoK+FHAdJopnauF5NyxK17l4nJpPqaGSjYjJQYr+Lq7KV8sHAwjIYYdkn/dQCGV5 3aztjeaAc/mFMqaX34bWSFJT9Zi0Y0bduZyOmibyQYhiYvgf5KmKoy4JvudGr0O9vKeC b5o42tQQzxfIQ47OjujjO8zXQYWpntCkZk+5v6/kDEIm0T86UY4hzD8e8ZJpCxhMIR4l a/raO4m6RqWU1LkTFoGFcRJvykShF6xTHBTCVuD7XrNwQazquPG82Sth8ILFzY3k/DAW JqP5sduvxBOZBYtSQJkaDV9Jap/Fj+ole2hi+PZQwnEvOKocIFk6cejEp2E9MvSj/lrm JJDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mhk2c9C7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id g6-20020a63dd46000000b003aa7173290esi15334760pgj.374.2022.05.02.17.08.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 May 2022 17:08:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mhk2c9C7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D975535DEB; Mon, 2 May 2022 17:07:57 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345444AbiD1LOO (ORCPT + 99 others); Thu, 28 Apr 2022 07:14:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345278AbiD1LOM (ORCPT ); Thu, 28 Apr 2022 07:14:12 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BF89220F7; Thu, 28 Apr 2022 04:10:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651144258; x=1682680258; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=9b/ogsk/Vrw1tCXgALPfQltHHecqX2TfkDingMu31Ak=; b=mhk2c9C72yB955zbYXBUsatsd/v9CuyV1bMzMPdCf+yFCAt6JUwe88Ra U3HCcSQQ+SbQY9ECebFf8F2ncQFq2S4PYQAgLaiqB4CMUkl0OEQ+onmmT qNFg5dtISwqJKWLds6Qtg0triDX0VIlJQuFdWqJLyTD97n00S5K0rNVwQ +AVWbFHqwEoQAtmZTSrpxB5nEMuqYGV4+OpNn6rrbB5CdQGR0Ko4i4NKl Onk9vdUKpTUOd6VQY92RySU4zXUGMI3Mz34OvWgP3qod7ZF+w6DIipbrE CtuqDfqVJJps3z/djpbN3TeLMi9X9B1VwPLAipT9ziIQpelFtT6uz2BLA w==; X-IronPort-AV: E=McAfee;i="6400,9594,10330"; a="291414529" X-IronPort-AV: E=Sophos;i="5.90,295,1643702400"; d="scan'208";a="291414529" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2022 04:10:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,295,1643702400"; d="scan'208";a="706011954" Received: from black.fi.intel.com (HELO black.fi.intel.com.) ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 28 Apr 2022 04:10:55 -0700 From: Heikki Krogerus To: Greg Kroah-Hartman Cc: Felipe Balbi , "Rafael J. Wysocki" , Mathias Nyman , Andy Shevchenko , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/2] usb: core: acpi: Rely on the sysdev pointer Date: Thu, 28 Apr 2022 14:10:54 +0300 Message-Id: <20220428111056.3558-1-heikki.krogerus@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I've added a comment in the first patch explaining that the sysdev pointer is the host controller from firmware perspective like requested by Andy. But please note that I did not make any comments about the location of the sysdev ACPI companion in ACPI namespace on purpose. We don't need to, and we actually can't make any assumptions about that. original cover letter: Since we have that sysdev pointer, we need to use it also when assigning the ACPI companion for the root hub. That should remove the need to "manually" assign the ACPI companion to the controller device in the xhci glue drivers like dwc3-host.c. Assigning the ACPI companion in those glue drivers is very problematic, because it screws up the fwnode->secondary pointer. But as said, since we have that sysdev pointer, there is no need to manually set it. sysdev pointer should always point to the correct physical device from firmware PoW. thanks, Heikki Krogerus (2): usb: core: acpi: Use the sysdev pointer instead of controller device usb: dwc3: host: Stop setting the ACPI companion drivers/usb/core/usb-acpi.c | 7 +++++-- drivers/usb/dwc3/host.c | 2 -- 2 files changed, 5 insertions(+), 4 deletions(-) -- 2.35.1