Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <d58c4881-8a23-bf7b-4845-b2fa50788997@linaro.org>
Date:   Mon, 2 May 2022 22:22:44 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] tty: serial: samsung_tty: Fix suspend/resume on S5L
Content-Language: en-US
To:     Hector Martin <marcan@marcan.st>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Sven Peter <sven@svenpeter.dev>,
        Alyssa Rosenzweig <alyssa@rosenzweig.io>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220502092505.30934-1-marcan@marcan.st>
 <Ym/EAGq3IzW5rYwr@kroah.com> <c5413c42-b728-b88b-4229-9d4e3943413e@marcan.st>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <c5413c42-b728-b88b-4229-9d4e3943413e@marcan.st>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 02/05/2022 14:39, Hector Martin wrote:
> On 02/05/2022 20.44, Greg Kroah-Hartman wrote:
>> On Mon, May 02, 2022 at 06:25:05PM +0900, Hector Martin wrote:
>>> We were restoring the IRQ masks then clearing them again, because
>>> ucon_mask wasn't set properly. Adding that makes suspend/resume
>>> work as intended.
>>>
>>> Signed-off-by: Hector Martin <marcan@marcan.st>
>>> ---
>>>  drivers/tty/serial/samsung_tty.c | 1 +
>>>  include/linux/serial_s3c.h       | 3 +++
>>>  2 files changed, 4 insertions(+)
>>
>> Does this fix a specific older commit?
>>
>> And should it be backported to older stable kernels?
> 
> It does fix the commit that introduced this device support in general; I
> can add a Fixes line for that. I don't think anyone cares about
> backporting though, since there are other fairly critical devices that
> don't have support outright and there's still work to do before
> suspend/resume is generally usable on these machines.

Then please add only Fixes tag.

Best regards,
Krzysztof