Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <b6553cc2-034d-8a70-cf9b-b9d244dc3597@roeck-us.net>
Date:   Mon, 2 May 2022 13:24:40 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 2/2] hwmon: acpi_power_meter: convert to
 hwmon_device_register_with_info
Content-Language: en-US
To:     LABBE Corentin <clabbe@baylibre.com>
Cc:     jdelvare@suse.com, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220502124249.682058-1-clabbe@baylibre.com>
 <20220502124249.682058-2-clabbe@baylibre.com>
 <0b154a30-7765-e3ac-9980-0ecc7447d7ad@roeck-us.net> <YnAqDxfTU27USQI+@Red>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <YnAqDxfTU27USQI+@Red>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 5/2/22 11:59, LABBE Corentin wrote:
> Le Mon, May 02, 2022 at 06:34:44AM -0700, Guenter Roeck a écrit :
>> On 5/2/22 05:42, Corentin Labbe wrote:
>>> Booting lead to a hwmon_device_register() is deprecated. Please convert the driver to use hwmon_device_register_with_info().
>>> So let's convert the driver to use hwmon_device_register_with_info().
>>>
>>> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
>>> ---
>>>    drivers/hwmon/acpi_power_meter.c | 5 ++++-
>>>    1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/hwmon/acpi_power_meter.c b/drivers/hwmon/acpi_power_meter.c
>>> index d2545a1be9fc..98293727f980 100644
>>> --- a/drivers/hwmon/acpi_power_meter.c
>>> +++ b/drivers/hwmon/acpi_power_meter.c
>>> @@ -891,7 +891,10 @@ static int acpi_power_meter_add(struct acpi_device *device)
>>>    	if (res)
>>>    		goto exit_free_capability;
>>>    
>>> -	resource->hwmon_dev = hwmon_device_register(&device->dev);
>>> +	resource->hwmon_dev = hwmon_device_register_with_info(&device->dev,
>>> +							      ACPI_POWER_METER_DEVICE_NAME,
>>> +							      NULL, NULL,
>>> +							      NULL);
>>
>> NACK. That isn't a conversion to the new API, it just abuses the fact
>> that the new API has to accept a NULL info pointer for historic reasons.
>>
> 
> Hello
> 
> I am sorry, I found a driver doing it, so I believed it was okay.

Yeah, that is what happens if an API is flexible: It is prone to
abuse, and once the abuse starts others start to abuse it as well
"because that other driver did it".

> Converting seems not to hard but, by using the new API, how can I convert power1_model_number/power1_is_battery attribute ?
> There are the remaining attributes I dont find how to convert.
> 

It is ok to use the pointer to sysfs attribute groups
for non-standard attributes.

Guenter