Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp211179iob; Mon, 2 May 2022 17:20:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTR1vetcfjx6MqPohknVfd+mfITuyUcRZ/ZjCkMnJjln80/dG/FAMeWMO+iJc8rljLPX+a X-Received: by 2002:a05:6a00:1a46:b0:505:c8a6:fef9 with SMTP id h6-20020a056a001a4600b00505c8a6fef9mr14032451pfv.24.1651537207514; Mon, 02 May 2022 17:20:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651537207; cv=none; d=google.com; s=arc-20160816; b=vn1cb1S7OIEWqA7S7wXgl2bYq8hWN4smGXrZQprYkkqlzMzQevrfwROXrkNs/PC5s6 ZSYlnzHEu6V6ztAsPshLRSAoQXs5CXmU0sJ3sjZ+eFGuRw8m3P80ptoX8Gp7BhZ3blzO 0bxro7UTFj4WCsltF/cNEf45L9GxRvW0LfBvfwquyieWadzmaVa+UASp/5aDA8rDmPO+ 5WkHs89NnpBBbWu+ktdCBni2tHLu/4yl9uw3skpujnl7/FIUwF7X3QHpymY39o3CY8ba E2w/a7N4Rv6BdsAIun/Yp9Abq10ODwpQKohvkmBSJ/SDvRnbzWD9MCGEK0Szj6sNxcQ2 jQCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=GA5+ZlDW8UScyqY3x4qve8GrPLRl+IQSUWiiXSDR3Kw=; b=Q7JYqhvRwz5rB/3tmfvUJXNTBTJRXvmBsiQOKGhMe+q6BPIEoZzWwIQDpkTSd5XtcW 8JetoZz6VDGQBz6m3TGSAcgqPJDbJqpFX0Wak5wD9AisWb9y/FyC9sxIkblYH63Cw5YP Ckrdk+WP8PDJDE+Ma7BKNIEsFQcEEm0BQXTvYT7+beOmi361irk/P7Q9KFNviEaJth1T sO7ckWB03Hpr7IBSCh15PVyKQKevekK7K0rIYlM3p3B+TgsrlwPCbOmddqw7XBv1V5ID uQ3ZsUB6wGy3Umnh9I3T+7o+F/WnmLChBLIiuVJtd+xSSXP9JKPWgvXyxyQK5xx/bP81 QTIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Sd/guOm8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id u1-20020a17090341c100b0015871e5fcefsi1944161ple.164.2022.05.02.17.20.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 May 2022 17:20:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Sd/guOm8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F0DC437022; Mon, 2 May 2022 17:17:10 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1384388AbiEBKG5 (ORCPT + 99 others); Mon, 2 May 2022 06:06:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1384460AbiEBKGN (ORCPT ); Mon, 2 May 2022 06:06:13 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCF27F60 for ; Mon, 2 May 2022 03:02:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 19EC7CE16E0 for ; Mon, 2 May 2022 10:02:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A754C385AC; Mon, 2 May 2022 10:02:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651485749; bh=NguaT+/Q3HuD7q15xEi7PC7PJM/qponU/4ADlpgZs+w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Sd/guOm8G8Ap3pDANr1h6S8iv5TXhnudF/5d2+TgVdbjgGTaqB7A4fh01IW1MpuO7 aVIkzyDHXUXYhBiC8iCISKGyxn271S+bufNaZ+Q1d1jUi1IuwgzmV7HBCns+idAbtq 0xGOpoNsRhhIUU26yFTk2nZNPY63PR3zW2l8HhYjcGMusF3/kSvXImPzRc/uOuhWhb x4AkQh9BhGzjmNZ80NKz0QCXSmJCXHIzHv5t6D2rtt4UH+3Cvvdz47RSXEMWEyKnFu 3YE5/bx7ChsOTrtAR0G5SPi85LZAKnqyW2QD2knP3QqwXqY3yWEnyY+HUXuCK3IkBw 1TbcUr5VHcl9g== Date: Mon, 2 May 2022 11:02:26 +0100 From: Filipe Manana To: Thomas Gleixner Cc: LKML , x86@kernel.org, Filipe Manana Subject: Re: [patch 0/3] x86/fpu: Prevent FPU state corruption Message-ID: References: <20220501192740.203963477@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220501192740.203963477@linutronix.de> X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 01, 2022 at 09:31:42PM +0200, Thomas Gleixner wrote: > The recent changes in the random code unearthed a long standing FPU state > corruption due do a buggy condition for granting in-kernel FPU usage. Thanks for fixing this. I had been reliably hitting that fpu state splat since 5.18-rc1 with fstests, and was annoying because it made a few tests fail (fstests reports a failure whenever there's a splat or warning in dmesg). I confirm that with this patchset applied the issue no longer happens and everything seems to be working fine, so: Tested-by: Filipe Manana > > The following series addresses this issue and makes the code more robust. > > Thanks, > > tglx > --- > arch/um/include/asm/fpu/api.h | 2 > arch/x86/include/asm/fpu/api.h | 21 +------- > arch/x86/include/asm/simd.h | 2 > arch/x86/kernel/fpu/core.c | 92 +++++++++++++++++++----------------- > net/netfilter/nft_set_pipapo_avx2.c | 2 > 5 files changed, 57 insertions(+), 62 deletions(-) > > >