Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Sat, 30 Apr 2022 10:47:35 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        aolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v1 net-next 1/1] net: ethernet: ocelot: remove the need
 for num_stats initializer
Message-ID: <20220430174735.GD3846867@euler>
References: <20220429213036.3482333-1-colin.foster@in-advantage.com>
 <20220429213036.3482333-2-colin.foster@in-advantage.com>
 <20220430151530.zaf7hyagln5jqjyi@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220430151530.zaf7hyagln5jqjyi@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pRONsMIQX3Imgxqce7zQWnu+UA8p0Qi+xXNUxZDChrSlvTBpmM6oHBuljEi6?=
 =?us-ascii?Q?HZVxR9iP3VelTDhw5JL+TS7PjbErNErmxDgQbR3Mz+KjB+pM+OoquB/+Bn5Y?=
 =?us-ascii?Q?0A9Ugt/EI8DYr169VBeR43eA33KMrBlqM65zi5TPlfNGpNsULwPT3zFlr3FK?=
 =?us-ascii?Q?n5AVVcMkSg1vWw8TlkFEa5SQ8gLgibLOsejb8IuoWdTFqgMeknJdoyFvgf94?=
 =?us-ascii?Q?ChK2Lvrq8gO1p44IzgqiD4xVLzuT9P/aPsdHNJJhTSscTxp8HOOTMzyxGqW2?=
 =?us-ascii?Q?250hwhbMH54dLsfIUAOxbEExWSeDHdmsntbzDHKXkbxlCkBYnIvrAfkkMFMl?=
 =?us-ascii?Q?i4yxqX7b0nNpKg6SjzGDJLE2Ss+FUAfbD7VNjXrr2bFsn5Y2o+vR1lVhXxBC?=
 =?us-ascii?Q?HyZm8tUyeRJMpzSSaAVNyBSBTP2bv/+CG7bwgME+l9X9qAsZJhWb1wZilrKy?=
 =?us-ascii?Q?MQ4lCuvO4SS+LXyVAFvjxfu1SGqTxZp6lU6Tl3lBIjQWRsxionWDMS7oazA6?=
 =?us-ascii?Q?g0FOHhewcGoesEIAu6XQSSRCPUAyYwMT4PQz0A42lcIfeGWxgUTeNYGZEx2n?=
 =?us-ascii?Q?wCafaSnsYMFDqNlvJtoQ+t7t4QtfMvlGBr2xWsiNParAK+W5Z0mMY+5urpEc?=
 =?us-ascii?Q?dDAHD3vD+Y2uTIiRIw4juSqy2S0YIaYJ3hwAX1so4g3pQmhWrlL/jQlNvdv6?=
 =?us-ascii?Q?zPZpE6U+/uep2pNgFXY9B0jye9KCF3McEhyhNaYCJWFuORy/B9EiZMCmHHZl?=
 =?us-ascii?Q?tQQeZvMHSuBy9WKs2HS38Dn+1tsNtCPywhS3BQE2FqFdJ1J/+J1H+PRCBEZC?=
 =?us-ascii?Q?FwWXYy9u26tPSqAfV2iTLe05mdUzxgjyqp45thy38MZXeoKQHIlmKamZcjUQ?=
 =?us-ascii?Q?BAOCvHMlwT1slSjrF/yMgwjOj1ulsgaLhq2MGzJ8dAjYDqkh8jMmLfvMsjEC?=
 =?us-ascii?Q?cRPgOJwYZUFYEGy/aCkcpq0HXYsrv2h4DJEF946LjaA/xypNlkT++f1aWnM5?=
 =?us-ascii?Q?gOjDUoETOSRtkOxjfil+Nd41fi7MCTeuof7y0onVqQtWDUZSHrM5iWVQCZ0Z?=
 =?us-ascii?Q?AJi1Q9phs/1EE7t6DN5ZLVAmmAL8R+4hv9os6qikztC3dwWzfD2o0w1T6STH?=
 =?us-ascii?Q?2yPWvIifo0QO1Xjm6AvzZUBu+JX98jwDD2OBlcQhD/1gWHhpdkGJzR1XtVYK?=
 =?us-ascii?Q?dTa6SfPjkMuLFwAuiB8VN5o+FtNsYi37XN6Ttu8swGN8hb/MZfODCpQyYrQ6?=
 =?us-ascii?Q?dwACCBSuw21ZvE1CjXnuKnT6Bq5kdeucJL6sraPLg93RzgEEAKV/ihFsemon?=
 =?us-ascii?Q?JxptQhL2+EN8ofTUT3JCMpJDpYkWJhWbwziu+zc3JAaiUMnEjQorABb5PYyO?=
 =?us-ascii?Q?5QVjFJ0dQfQbrG1IzCn18qwfl6X3O63O8NtxC3EVWyXO3N35stb3xAlYkx2J?=
 =?us-ascii?Q?XxODgF32/NLpLQV4/bCFe7p6sctzZX7DxLoKbp4dkKIyfWRXe4/LVG6R4N6G?=
 =?us-ascii?Q?mpX15/bqAmwiYuWKUDQiqCC4CEoqUIGpp6Cb/HHW6E1nLPhYEysrsV53w6gQ?=
 =?us-ascii?Q?7v2/3KfSFbQqyexRd4rKf53p1iydEg4m1uJoS+HX6/1t12ZbiZbGIXXuSGfi?=
 =?us-ascii?Q?+ttCXa6AsochvMlg4eA/VYODStF7vVy3pmx7phXvy3zjJavCBVeqCG7I/KAQ?=
 =?us-ascii?Q?6tUa9hi6RTVBZehRH2HmcpMULrTmcfSbg1StaInWVW7f5Y5vyIb0sSxwzdqK?=
 =?us-ascii?Q?IpMsM33ksSPDDXWhWUNRjYgNUYLemfMj3uiOTEqPVGU7JSoEHMBr?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7194feff-85ae-46dc-96b5-08da2ad184ea
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2022 17:47:39.4406
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eqHCaOYKIDb7iRtLFv1VItC0Rw/I2hCbYyl5YVmnzFiG2NNHPhR/AApW33pqxV7ypyXyYXCxpBoN5uKjupq03tfsyZ4AcBtb21d04up1JKg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3526
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Vladimir,

On Sat, Apr 30, 2022 at 03:15:31PM +0000, Vladimir Oltean wrote:
> On Fri, Apr 29, 2022 at 02:30:36PM -0700, Colin Foster wrote:
> > There is a desire to share the oclot_stats_layout struct outside of the
> > current vsc7514 driver. In order to do so, the length of the array needs to
> > be known at compile time, and defined in the struct ocelot and struct
> > felix_info.
> > 
> > Since the array is defined in a .c file and would be declared in the header
> > file via:
> > extern struct ocelot_stat_layout[];
> > the size of the array will not be known at compile time to outside modules.
> > 
> > To fix this, remove the need for defining the number of stats at compile
> > time and allow this number to be determined at initialization.
> > 
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > ---
> > diff --git a/include/soc/mscc/ocelot.h b/include/soc/mscc/ocelot.h
> > index 9b4e6c78d0f4..5c4f57cfa785 100644
> > --- a/include/soc/mscc/ocelot.h
> > +++ b/include/soc/mscc/ocelot.h
> > @@ -105,6 +105,13 @@
> >  #define REG_RESERVED_ADDR		0xffffffff
> >  #define REG_RESERVED(reg)		REG(reg, REG_RESERVED_ADDR)
> >  
> > +#define OCELOT_STAT_FLAG_END		BIT(0)
> > +
> > +#define for_each_stat(ocelot, stat)				\
> > +	for ((stat) = ocelot->stats_layout;			\
> > +	     !((stat)->flags & OCELOT_STAT_FLAG_END);		\
> > +	     (stat)++)
> > +
> >  enum ocelot_target {
> >  	ANA = 1,
> >  	QS,
> > @@ -535,9 +542,12 @@ enum ocelot_ptp_pins {
> >  
> >  struct ocelot_stat_layout {
> >  	u32 offset;
> > +	u32 flags;
> 
> Was it really necessary to add an extra u32 to struct ocelot_stat_layout?
> Couldn't you check for the end of stats by looking at stat->name[0] and
> comparing against the null terminator, for an empty string?

I considered this as well. I could either have explicitly added the
flags field, as I did, or implicitly looked for .name == NULL (or
name[0] == '\0' as you suggest).

I figured it might be better to make this an explicit relationship by
way of flags - but I'm happy to change OCELOT_STAT_END and for_each_stat
to rely on .name if you prefer.

> 
> >  	char name[ETH_GSTRING_LEN];
> >  };
> >  
> > +#define OCELOT_STAT_END { .flags = OCELOT_STAT_FLAG_END }
> > +
> >  struct ocelot_stats_region {
> >  	struct list_head node;
> >  	u32 offset;
> > -- 
> > 2.25.1
> >