Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp212032iob; Mon, 2 May 2022 17:21:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz1o8QaWt7ETv4bKeMm7KGx0rb+Oao69EohTAY3si7YJGat8FMm62xjUpmriUj3sy8S7l8u X-Received: by 2002:a17:902:f64e:b0:14d:20db:8478 with SMTP id m14-20020a170902f64e00b0014d20db8478mr14738254plg.158.1651537296790; Mon, 02 May 2022 17:21:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651537296; cv=none; d=google.com; s=arc-20160816; b=EWKRi3Aq3QVEOuahWdT/dSG1xNZMiPJQ/54JdGlHyoAvdfy1dj0k4P9VIV+FxI/QXV zaPw645YZ6FwlVsxcj2KdFD8vHWecu5l4lnDxW+3GZeXCCPFEau0InrDJ0s4DM//6L+p 067h4KF0vwv03HXn92FNNRjG2x4Cu/E0xnp28VsLaGjZxd4HmOA8qkoLctCATLrqbDpE ZlouipkYIZow1HSoi2++k3q6mcm6eQeh7VJ75bV6+6PADf9l0aFRxAsL/4ml0z5UrpGh +Y8zgY1GiRSSaf6rzEzlmU0rc14DXVJ03hmwLli3Sf5iiTs27Xi45ku5sDyKhxvPjJMH ZRJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ul+t6uTHofyRjOEGXVcu4PlOdgwxB5M3MPuVkOzIQ1Y=; b=UoTbELPztWtCVTwPJ6b/QHWpHSkHiebjrKRHBXjh6fCsyKjLwTlk+n4TBjFq+LHztf hDV1m77vcxbH3uWeamqwy2d932I4sxymx1JrwjnOulKGk2rpY1ikXgdPUMnGZSuY2kg0 3CsYaRjkWwto0+XwdBzvKC5i+9QQ9DZXf9YcPXSUXNkDlCZk3pj42/8Rgewcfk3qYyUE /x9fX/4ehn1oiaqwfmvoq0+YaLN1cQZ4e3ji598S+0Dz0XfrJA6CEyYQrxH09VYsx9j3 vfQ78dJp0uIiMgdQFAZsniFc4auACGPCrSvfycu3PKFhXjpakbA5KFfCNqIp6JQ9uj3w H2Ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=lgcr47LY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id j1-20020a056a00174100b0050ad23a8d0esi16452985pfc.113.2022.05.02.17.21.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 May 2022 17:21:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=lgcr47LY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9EF2B3B29D; Mon, 2 May 2022 17:18:16 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345066AbiD1LBk (ORCPT + 99 others); Thu, 28 Apr 2022 07:01:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344973AbiD1LBH (ORCPT ); Thu, 28 Apr 2022 07:01:07 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C73F19682C; Thu, 28 Apr 2022 03:57:48 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id l16-20020a05600c1d1000b00394011013e8so2147183wms.1; Thu, 28 Apr 2022 03:57:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ul+t6uTHofyRjOEGXVcu4PlOdgwxB5M3MPuVkOzIQ1Y=; b=lgcr47LYHuUcL5xQnY6UqV7tiEtYMcg9xL6rPM6qQ5/1kMIpy8uzthRkZYEntaidTQ YTiKzGUDpNJBCvcbaz3sEdAQ/E5kTjL/Tr3PplQZeYeeJP5Rsk+O2UxwGi3myRBQdyuv SWfei+fWGf/UavE/7Djr+3F0SgypLR1JfpYi5Df8m5UU6Wv7MueGkUAJr8G06XxoI6/4 HnoagrX3bSUKfsvoXLenuNrZS0akIBHs3XQ+/5FuynJFOMFLiGi6GhDVnjnOZhY3mRHm mmPTWBPRspM7maLEoUAWUHbpu+zbwLgRFtnVASvmNkWWCuylKyxfjZvINkaJQxS3hVvF kMug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ul+t6uTHofyRjOEGXVcu4PlOdgwxB5M3MPuVkOzIQ1Y=; b=RoJQkn30t1S00L9WMpMxiaLInEX5Z33q0yDr20eEQ2sAvWhnaijTcN71ozfwOkGSLy +iOsipfhkA+B8Lcscr2+YHD0v/OqkasLlGDGiyoZ9PkJbJtqWlAZZi5V/Z/qdH7vBlwR bkPTTRB2IKksEsSSzTGRX5SE5hTnxzARNui4BnTwFv4Xst0C9KDMEgznTxWxRps+B75d 6lXBlYM2mjNS0baHQrRy+0N4wDLdeQOWXaP0sKx924DmATzzUaj/ru6bwfBIh0pIVaHS 8uNJLSlUsa6xtLzsSXagvb0Qu5UCF5olEB35IUrorp30XQ9mpcYueWwzeyGWRIpp7TBU uREw== X-Gm-Message-State: AOAM530tu9b5AsAJGnspFLuBOkOXmQvTUeSaFJsV4p53R9iysIbhrXUb q/FEmPQCNO5Ry3L9TGNekvOk7X1VRg4= X-Received: by 2002:a05:600c:240a:b0:394:18b:d722 with SMTP id 10-20020a05600c240a00b00394018bd722mr7736718wmp.177.1651143466987; Thu, 28 Apr 2022 03:57:46 -0700 (PDT) Received: from 127.0.0.1localhost (82-132-230-8.dab.02.net. [82.132.230.8]) by smtp.gmail.com with ESMTPSA id z11-20020a7bc14b000000b0039419dfbb39sm7547wmi.33.2022.04.28.03.57.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Apr 2022 03:57:46 -0700 (PDT) From: Pavel Begunkov To: netdev@vger.kernel.org, "David S . Miller" , Jakub Kicinski Cc: David Ahern , Eric Dumazet , linux-kernel@vger.kernel.org, Pavel Begunkov Subject: [PATCH net-next 09/11] ipv6: refactor opts push in __ip6_make_skb() Date: Thu, 28 Apr 2022 11:56:42 +0100 Message-Id: X-Mailer: git-send-email 2.36.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Don't preload v6_cork->opt before we actually need it, it likely to be saved on the stack and read again for no good reason. Signed-off-by: Pavel Begunkov --- net/ipv6/ip6_output.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 976554d0fdec..43a541bbcf5f 100644 --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c @@ -1855,7 +1855,6 @@ struct sk_buff *__ip6_make_skb(struct sock *sk, struct ipv6_pinfo *np = inet6_sk(sk); struct net *net = sock_net(sk); struct ipv6hdr *hdr; - struct ipv6_txoptions *opt = v6_cork->opt; struct rt6_info *rt = (struct rt6_info *)cork->base.dst; struct flowi6 *fl6 = &cork->fl.u.ip6; unsigned char proto = fl6->flowi6_proto; @@ -1884,10 +1883,14 @@ struct sk_buff *__ip6_make_skb(struct sock *sk, __skb_pull(skb, skb_network_header_len(skb)); final_dst = &fl6->daddr; - if (opt && opt->opt_flen) - ipv6_push_frag_opts(skb, opt, &proto); - if (opt && opt->opt_nflen) - ipv6_push_nfrag_opts(skb, opt, &proto, &final_dst, &fl6->saddr); + if (v6_cork->opt) { + struct ipv6_txoptions *opt = v6_cork->opt; + + if (opt->opt_flen) + ipv6_push_frag_opts(skb, opt, &proto); + if (opt->opt_nflen) + ipv6_push_nfrag_opts(skb, opt, &proto, &final_dst, &fl6->saddr); + } skb_push(skb, sizeof(struct ipv6hdr)); skb_reset_network_header(skb); -- 2.36.0