Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Davidlohr Bueso <dave@stgolabs.net>,
        Prakash Sangappa <prakash.sangappa@oracle.com>
Cc:     linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
        peterz@infradead.org, manfred@colorfullife.com
Subject: Re: [PATCH v3] ipc: Update semtimedop() to use hrtimer
In-Reply-To: <20220428205001.hiuzwpn5emxtrh4s@offworld>
References: <1651178767-447-1-git-send-email-prakash.sangappa@oracle.com>
 <20220428205001.hiuzwpn5emxtrh4s@offworld>
Date:   Fri, 29 Apr 2022 00:02:25 +0200
Message-ID: <87zgk4ooi6.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Thu, Apr 28 2022 at 13:50, Davidlohr Bueso wrote:
> On Thu, 28 Apr 2022, Prakash Sangappa wrote:
>>-		if (timeout)
>>-			jiffies_left = schedule_timeout(jiffies_left);
>>-		else
>>-			schedule();
>>+		timed_out = !schedule_hrtimeout_range(exp,
>>+				current->timer_slack_ns, HRTIMER_MODE_ABS);
>
> I'm wondering if the slack parameter instead of passing the timer_slack_ns
> value immediately, we should do a rt_task() check and pass zero if so.

We should have a wrapper function which takes care of that instead of
having checks all over the place.

Thanks,

        tglx