Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <dabc2be2-36ce-a9d4-8aa5-ae3f2a57f904@roeck-us.net>
Date:   Mon, 2 May 2022 13:42:33 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Content-Language: en-US
To:     Armin Wolf <W_Armin@gmx.de>, LABBE Corentin <clabbe@baylibre.com>
Cc:     jdelvare@suse.com, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220502124249.682058-1-clabbe@baylibre.com>
 <20220502124249.682058-2-clabbe@baylibre.com>
 <0b154a30-7765-e3ac-9980-0ecc7447d7ad@roeck-us.net> <YnAqDxfTU27USQI+@Red>
 <1b2bf215-faa1-649d-5ab4-85fc0b907ec2@gmx.de>
From:   Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 2/2] hwmon: acpi_power_meter: convert to
 hwmon_device_register_with_info
In-Reply-To: <1b2bf215-faa1-649d-5ab4-85fc0b907ec2@gmx.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 5/2/22 13:31, Armin Wolf wrote:
> Am 02.05.22 um 20:59 schrieb LABBE Corentin:
> 
>> Le Mon, May 02, 2022 at 06:34:44AM -0700, Guenter Roeck a écrit :
>>> On 5/2/22 05:42, Corentin Labbe wrote:
>>>> Booting lead to a hwmon_device_register() is deprecated. Please convert the driver to use hwmon_device_register_with_info().
>>>> So let's convert the driver to use hwmon_device_register_with_info().
>>>>
>>>> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
>>>> ---
>>>>    drivers/hwmon/acpi_power_meter.c | 5 ++++-
>>>>    1 file changed, 4 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/hwmon/acpi_power_meter.c b/drivers/hwmon/acpi_power_meter.c
>>>> index d2545a1be9fc..98293727f980 100644
>>>> --- a/drivers/hwmon/acpi_power_meter.c
>>>> +++ b/drivers/hwmon/acpi_power_meter.c
>>>> @@ -891,7 +891,10 @@ static int acpi_power_meter_add(struct acpi_device *device)
>>>>        if (res)
>>>>            goto exit_free_capability;
>>>>
>>>> -    resource->hwmon_dev = hwmon_device_register(&device->dev);
>>>> +    resource->hwmon_dev = hwmon_device_register_with_info(&device->dev,
>>>> +                                  ACPI_POWER_METER_DEVICE_NAME,
>>>> +                                  NULL, NULL,
>>>> +                                  NULL);
>>> NACK. That isn't a conversion to the new API, it just abuses the fact
>>> that the new API has to accept a NULL info pointer for historic reasons.
>>>
>> Hello
>>
>> I am sorry, I found a driver doing it, so I believed it was okay.
>> Converting seems not to hard but, by using the new API, how can I convert power1_model_number/power1_is_battery attribute ?
>> There are the remaining attributes I dont find how to convert.
>>
>> Regards
> 
> Hi,
> 
> for allowing the driver to provide nonstandard attributes, hwmon_device_register_with_info()
> has the argument "extra_groups" which is an pointer to a list of sysfs attribute groups.
> There are some drivers which are using this functionality, maybe you can use them as an
> inspiration.
> 
> Just a question: what is the name of the driver you originally used as an inspiration?
> 

Originally it was for drivers/thermal/thermal_hwmon.c. Now there is also
drivers/platform/mips/cpu_hwmon.c which is clearly an abuse. I may have
missed others.

Guenter