Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220429032621.674865-1-starzhangzsd@gmail.com>
 <20220429095104.GA11365@alpha.franken.de> <alpine.DEB.2.21.2204291559490.9383@angie.orcam.me.uk>
In-Reply-To: <alpine.DEB.2.21.2204291559490.9383@angie.orcam.me.uk>
From:   Stephen Zhang <starzhangzsd@gmail.com>
Date:   Sat, 30 Apr 2022 11:36:23 +0800
Message-ID: <CANubcdWykz0j5BaGNhYMW16wX9UbfgsLdEs-ebNWCWP+p1OKWw@mail.gmail.com>
Subject: Re: [PATCH v2] MIPS: undefine and redefine cpu_has_fpu when it is overrided
To:     "Maciej W. Rozycki" <macro@orcam.me.uk>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc:     liam.howlett@oracle.com, ebiederm@xmission.com, alobakin@pm.me,
        f.fainelli@gmail.com, paul@crapouillou.net, linux@roeck-us.net,
        anemo@mba.ocn.ne.jp, zhangshida <zhangshida@kylinos.cn>,
        linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Maciej W. Rozycki <macro@orcam.me.uk> =E4=BA=8E2022=E5=B9=B44=E6=9C=8829=E6=
=97=A5=E5=91=A8=E4=BA=94 23:11=E5=86=99=E9=81=93=EF=BC=9A
>
>  Additionally I've thought of adding something like:
>
> #if cpu_has_fpu
> # undef cpu_has_fpu
> #endif
>
> or maybe even:
>
> #if cpu_has_fpu
> # error "Forcing `cpu_has_fpu' to non-zero is not supported"
> #endif
>
> to arch/mips/include/asm/cpu-features.h, but maybe that's an overkill.
>
>   Maciej

Yeah, but why do you think that's an overkill? There is a great chance
people will ignore the note of 'cpu_has_fpu', and it did happen. When
that happens, there should exist a way to point out  or fix that.

Thomas Bogendoerfer <tsbogend@alpha.franken.de> =E4=BA=8E2022=E5=B9=B44=E6=
=9C=8829=E6=97=A5=E5=91=A8=E4=BA=94 18:01=E5=86=99=E9=81=93=EF=BC=9A
>
> I prefer just removing the #defines from ip27/ip30 cpu-feasture-overrides=
.h.
> Or isn't that enough for fixing the problem ?
>
> Thomas.

So maybe that's  why I don't think just removing the #defines from
ip27/ip30 cpu-feasture-overrides.h. is enough for fixing the problem.

Stephen.