Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp219216iob; Mon, 2 May 2022 17:34:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrbHlEMwSvK2FuvigPC4WkuI2rr9ihC/kFSbgTlwitZAUG2m4UVMJ87ctnHUjyQWJkhSBr X-Received: by 2002:aa7:88d6:0:b0:50d:88cf:1c76 with SMTP id k22-20020aa788d6000000b0050d88cf1c76mr13592846pff.2.1651538060688; Mon, 02 May 2022 17:34:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651538060; cv=none; d=google.com; s=arc-20160816; b=fJVqZ9OotIPQWF3WU3BphAoQ9eRhKmzUMXYK/2C5po7rK2dIR4I/S6PEKOE0hhhLm6 budnLO40UMTeaqgf0rnRqGjwZyAXH/9dF3gVG12fvsz9sYusFKOPcBJJsYFx/gs9NB5H X46efLGQt6nNKOSW2JYQmLqvuI3S5tXN69UyopkTmRUj5WBiSYsfSTv0LP+MVAZlL6tv LK2xaAoyUi4B0y6IdHzXTgHjXnbWxrpWUzd0Ztz/iS9biFJCO0bHUlaMTe6DrdXiilJt wGqwdekqu5qf/9XgnnvTTnIhyB9Th2FhbZMZsp0wFn3ZrWB19SMEGNjQV1R9hMDElU0B YyYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ZJbu/LpYyn7j0q1x6o6hxX8kPvuEWXi4HrBdKHx2p8g=; b=J24TqQwMXecIt4dm5MBHFmTTEFcQwx2tq12LCXWf9ZKRcM1AA1qzM5PWbbJCAd+GdF agvmU5s6Tj8JKDOLjwxC/uct8mkcshs3l9Cd8hi0LeD72d0q2hU6GOq5icMlPuVaWjou ZxrhFqGnXILSB0wtLfD6ihW6KgeQYWp+cOKh/MJK8UrPwkRzbym8W1nSWlIJ2thSP7r4 AeuU7AEgWtJ5k+bexpeG014Kzg8b4voDIoJ7YqqPF9wH5KXG9NBBtPgI7T4+WR3/5/qY eD0s3LLzwS2QlwdMOMUoKabF8gX1zF9KsyeLi/osPH0UnvF8zs0I2elN+OkKFhsmC2nO I/xA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id bb19-20020a17090b009300b001dc3a299f5bsi672689pjb.114.2022.05.02.17.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 May 2022 17:34:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 82AFA42EFD; Mon, 2 May 2022 17:27:10 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383716AbiEBISj (ORCPT + 99 others); Mon, 2 May 2022 04:18:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383746AbiEBISb (ORCPT ); Mon, 2 May 2022 04:18:31 -0400 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8132F43EDE; Mon, 2 May 2022 01:15:00 -0700 (PDT) Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4KsG9G6MMjz4ySx; Mon, 2 May 2022 18:14:58 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4KsG992Kv1z4x7Y; Mon, 2 May 2022 18:14:53 +1000 (AEST) From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org Cc: Mark Brown , Tudor Ambarus , Pratyush Yadav , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-aspeed@lists.ozlabs.org, Joel Stanley , Andrew Jeffery , Chin-Ting Kuo , devicetree@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Potin Lai , Jae Hyun Yoo , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH v5 11/11] mtd: spi-nor: aspeed: set the decoding size to at least 2MB for AST2600 Date: Mon, 2 May 2022 10:13:41 +0200 Message-Id: <20220502081341.203369-12-clg@kaod.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220502081341.203369-1-clg@kaod.org> References: <20220502081341.203369-1-clg@kaod.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Potin Lai In AST2600, the unit of SPI CEx decoding range register is 1MB, and end address offset is set to the acctual offset - 1MB. If the flash only has 1MB, the end address will has same value as start address, which will causing unexpected errors. This patch set the decoding size to at least 2MB to avoid decoding errors. Tested: root@bletchley:~# dmesg | grep "aspeed-smc 1e631000.spi: CE0 window" [ 59.328134] aspeed-smc 1e631000.spi: CE0 window resized to 2MB (AST2600 Decoding) [ 59.343001] aspeed-smc 1e631000.spi: CE0 window [ 0x50000000 - 0x50200000 ] 2MB root@bletchley:~# devmem 0x1e631030 0x00100000 Tested-by: Jae Hyun Yoo Signed-off-by: Potin Lai [ clg : Ported on new spi-mem driver ] Signed-off-by: Cédric Le Goater --- drivers/spi/spi-aspeed-smc.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/spi/spi-aspeed-smc.c b/drivers/spi/spi-aspeed-smc.c index 35f6934847b7..496f3e1e9079 100644 --- a/drivers/spi/spi-aspeed-smc.c +++ b/drivers/spi/spi-aspeed-smc.c @@ -474,6 +474,8 @@ static int aspeed_spi_set_window(struct aspeed_spi *aspi, * is correct. */ static const struct aspeed_spi_data ast2500_spi_data; +static const struct aspeed_spi_data ast2600_spi_data; +static const struct aspeed_spi_data ast2600_fmc_data; static int aspeed_spi_chip_adjust_window(struct aspeed_spi_chip *chip, u32 local_offset, u32 size) @@ -497,6 +499,17 @@ static int aspeed_spi_chip_adjust_window(struct aspeed_spi_chip *chip, chip->cs, size >> 20); } + /* + * The decoding size of AST2600 SPI controller should set at + * least 2MB. + */ + if ((aspi->data == &ast2600_spi_data || aspi->data == &ast2600_fmc_data) && + size < SZ_2M) { + size = SZ_2M; + dev_info(aspi->dev, "CE%d window resized to %dMB (AST2600 Decoding)", + chip->cs, size >> 20); + } + aspeed_spi_get_windows(aspi, windows); /* Adjust this chip window */ -- 2.35.1