Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <ea37d4f9-26e2-272a-01d6-fa7e8c62687e@gmail.com>
Date:   Sat, 30 Apr 2022 15:40:42 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] Documentation/vm/page_owner.rst: Fix syntax error and
 Describe details using table
Content-Language: en-US
To:     Shenghong Han <hanshenghong2019@email.szu.edu.cn>, corbet@lwn.net
Cc:     akpm@linux-foundation.org, baihaowen@meizu.com, seakeel@gmail.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        caoyixuan2019@email.szu.edu.cn, yejiajian2018@email.szu.edu.cn,
        yuhongf@szu.edu.cn
References: <20220429181926.10658-1-hanshenghong2019@email.szu.edu.cn>
From:   Akira Yokosawa <akiyks@gmail.com>
In-Reply-To: <20220429181926.10658-1-hanshenghong2019@email.szu.edu.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/04/30 3:19,
Shenghong Han wrote:
> Some syntax errors exist in "page_owner.rst". Thanks to Akira Yokosawa and
> Haowen Bai for tips to help improve the documentation.
> 
> We try to fix them. Hope that the Documentation is showed as we expect.
> 
> Signed-off-by: Shenghong Han <hanshenghong2019@email.szu.edu.cn>
> Fixes: edc93abbcc6d ("tools/vm/page_owner_sort.c: support sorting blocks by multiple keys")
> 
> ---
> Thanks Jonathan's suggestion.
> 
> This fix is a simpler than before.
> And yes, It has built in my machine.
> 
> Best,
> 
> 	Shenghong Han
> ---
> ---
>  Documentation/vm/page_owner.rst | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/vm/page_owner.rst b/Documentation/vm/page_owner.rst
> index 25622c715..0ecb4a739 100644
> --- a/Documentation/vm/page_owner.rst
> +++ b/Documentation/vm/page_owner.rst
> @@ -171,11 +171,12 @@ Usage
>  
>  STANDARD FORMAT SPECIFIERS
>  ==========================
> -::
>  
> -For --sort option:
> +1) For --sort option.
>  
> +	====		==========	===========
>  	KEY		LONG		DESCRIPTION
> +	====		==========	===========
>  	p		pid		process ID
>  	tg		tgid		thread group ID
>  	n		name		task command name
> @@ -183,14 +184,18 @@ For --sort option:
>  	T		txt		full text of block
>  	ft		free_ts		timestamp of the page when it was released
>  	at		alloc_ts	timestamp of the page when it was allocated
> -        ator            allocator       memory allocator for pages
> +	ator		allocator	memory allocator for pages
> +	====		==========	===========
>  
> -For --curl option:
> +2) For --curl option.
>  
> +	====		==========	===========
>  	KEY		LONG		DESCRIPTION
> +	====		==========	===========
>  	p		pid		process ID
>  	tg		tgid		thread group ID
>  	n		name		task command name
>  	f		free		whether the page has been released or not
>  	st		stacktrace	stack trace of the page allocation
> -        ator            allocator       memory allocator for pages
> +	ator		allocator	memory allocator for pages
> +	====		==========	===========

So, I have actually tested this.

Are you OK with the look of

  1) For --sort option.

and

  2) For --curl option.

in generated HTML or PDF docs?

In literal blocks, you would see double dashes of "--".
Now they are converted to so-called endash, which is a single dash
slightly longer than a normal hyphen.  It looks confusing to me.

To remedy this, you need inline literal markers of

  1) For ``--sort`` option.

and

  2) For ``--curl`` option.


By the way, this patch changes ":" to "." at the end of them.
Are they intentional changes?  If so, why?

        Thanks, Akira