Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Sat, 30 Apr 2022 16:17:35 +0200
User-Agent: K-9 Mail for Android
In-Reply-To: <3557249.iIbC2pHGDl@phil>
References: <20220430130347.15190-1-linux@fw-web.de> <20220430130347.15190-5-linux@fw-web.de> <3557249.iIbC2pHGDl@phil>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [RFC v2 4/4] arm64: dts: rockchip: Add mt7531 dsa node to BPI-R2-Pro board
Reply-to: frank-w@public-files.de
To:     linux-rockchip@lists.infradead.org,
        Heiko Stuebner <heiko@sntech.de>,
        linux-mediatek@lists.infradead.org,
        Frank Wunderlich <linux@fw-web.de>
CC:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Sean Wang <sean.wang@mediatek.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Peter Geis <pgwipeout@gmail.com>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
From:   Frank Wunderlich <frank-w@public-files.de>
Message-ID: <40BC9D9E-3E30-4779-9131-E101CDE993BC@public-files.de>
Precedence: bulk

Am 30=2E April 2022 16:05:06 MESZ schrieb Heiko Stuebner <heiko@sntech=2Ede=
>:
>Am Samstag, 30=2E April 2022, 15:03:47 CEST schrieb Frank Wunderlich:

>> --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro=2Edts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro=2Edts
>> @@ -437,6 +437,54 @@ &i2c5 {
>>  	status =3D "disabled";
>>  };
>> =20

>> +			port@5 {
>> +				reg =3D <5>;
>> +				label =3D "cpu";
>> +				ethernet =3D <&gmac0>;
>> +				phy-mode =3D "rgmii";
>- phy-mode: String, the following values are acceptable for port
>labeled
>	"cpu":
>	If compatible mediatek,mt7530 or mediatek,mt7621 is set,
>	must be either "trgmii" or "rgmii"
>	If compatible mediatek,mt7531 is set,
>	must be either "sgmii", "1000base-x" or "2500base-x"
>
>So I guess the phy-mode needs to change?

This results from current (before my cpu-port patches) implementation in d=
river where cpu-port is fixed to port 6=2E

On Mt7530 port 6 supports rgmii and trgmii=2E On mt7531 port6 only support=
s sgmii (which is basicly 2500base-x)=2E Afaik it does not support 1G=2E Po=
rt 5 on mt7531 supports rgmii or sgmii (dual sgmii mode) but seems not refl=
ected yet in txt=2E

On thing more to change when converting txt to yaml=2E

regards Frank