Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Sat, 30 Apr 2022 00:19:15 +0800
From:   kernel test robot <lkp@intel.com>
To:     Vikash Garodia <quic_vgarodia@quicinc.com>,
        linux-media@vger.kernel.org, stanimir.varbanov@linaro.org
Cc:     llvm@lists.linux.dev, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        quic_vgarodia@quicinc.com, frkoenig@chromium.org,
        quic_dikshita@quicinc.com
Subject: Re: [PATCH] media: venus: set ubwc configuration on specific video
 hardware
Message-ID: <202204300037.EcG1kDyl-lkp@intel.com>
References: <1651131248-20313-1-git-send-email-quic_vgarodia@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1651131248-20313-1-git-send-email-quic_vgarodia@quicinc.com>
Precedence: bulk

Hi Vikash,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on media-tree/master]
[also build test ERROR on v5.18-rc4 next-20220429]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Vikash-Garodia/media-venus-set-ubwc-configuration-on-specific-video-hardware/20220428-153510
base:   git://linuxtv.org/media_tree.git master
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20220430/202204300037.EcG1kDyl-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c59473aacce38cd7dd77eebceaf3c98c5707ab3b)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/22d299bea1f679d007cb71b3916bf39bb957ab66
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Vikash-Garodia/media-venus-set-ubwc-configuration-on-specific-video-hardware/20220428-153510
        git checkout 22d299bea1f679d007cb71b3916bf39bb957ab66
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/crypto/ arch/arm64/kernel/ drivers/media/platform/qcom/venus/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/media/platform/qcom/venus/hfi_venus.c:997:35: error: too few arguments to function call, single argument 'hdev' was not specified
                   ret = venus_sys_set_ubwc_config();
                         ~~~~~~~~~~~~~~~~~~~~~~~~~ ^
   drivers/media/platform/qcom/venus/hfi_venus.c:907:12: note: 'venus_sys_set_ubwc_config' declared here
   static int venus_sys_set_ubwc_config(struct venus_hfi_device *hdev)
              ^
   1 error generated.


vim +/hdev +997 drivers/media/platform/qcom/venus/hfi_venus.c

   967	
   968	static int venus_sys_set_default_properties(struct venus_hfi_device *hdev)
   969	{
   970		struct device *dev = hdev->core->dev;
   971		const struct venus_resources *res = hdev->core->res;
   972		int ret;
   973	
   974		ret = venus_sys_set_debug(hdev, venus_fw_debug);
   975		if (ret)
   976			dev_warn(dev, "setting fw debug msg ON failed (%d)\n", ret);
   977	
   978		/*
   979		 * Idle indicator is disabled by default on some 4xx firmware versions,
   980		 * enable it explicitly in order to make suspend functional by checking
   981		 * WFI (wait-for-interrupt) bit.
   982		 */
   983		if (IS_V4(hdev->core) || IS_V6(hdev->core))
   984			venus_sys_idle_indicator = true;
   985	
   986		ret = venus_sys_set_idle_message(hdev, venus_sys_idle_indicator);
   987		if (ret)
   988			dev_warn(dev, "setting idle response ON failed (%d)\n", ret);
   989	
   990		ret = venus_sys_set_power_control(hdev, venus_fw_low_power_mode);
   991		if (ret)
   992			dev_warn(dev, "setting hw power collapse ON failed (%d)\n",
   993				 ret);
   994	
   995		/* For specific venus core, it is mandatory to set the UBWC configuration */
   996		if (res->ubwc_conf) {
 > 997			ret = venus_sys_set_ubwc_config();
   998			if (ret)
   999				dev_warn(dev, "setting ubwc config failed (%d)\n", ret);
  1000		}
  1001	
  1002		return ret;
  1003	}
  1004	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp