Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp223560iob; Mon, 2 May 2022 17:42:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6oVbdQpGsiYzLZ77WmpM3m9Di4cxHnzLV9OSuKG8wccqxjKyGmhjiN2R1BD5eIAuhtoqD X-Received: by 2002:a65:4c0c:0:b0:3c1:5bb1:6701 with SMTP id u12-20020a654c0c000000b003c15bb16701mr11787511pgq.136.1651538577050; Mon, 02 May 2022 17:42:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651538577; cv=none; d=google.com; s=arc-20160816; b=J0b3ikgtx67RAjoKOAYVIkRTBG1vlKhca2eAX4wcMqoP7lnk33QSrIecT8a/yb2zrF guFJqyJffCEHEakpl20AUbM2sNv4FyqdEu5kBJ3Muyk0T14X8t0czjleb3n1tGcIUkH2 QhpPcQeIsCGmRblJAL17fvRzHCkG0ZYw+nCSfF4CgLFYF7y8FYTqXJXBssk++hTuY0Ic WUyJeiraHhw32tjJ6TgHOjoVc92ya5ukg4uhdmRD3a1F3kLbeTf7XuwQcYEBdLt/oUe2 /OwunAxVISgLeCosermmVHk2/nFx1zsSJcPd5uonQs4BQnWzHOq9k3xb7PSpPqJZK4hY AB7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=u1HmvvieFlCfkGXvK05S5+zMzYlMfV0Veo9KAjtkzYQ=; b=HeI+GDzeymX1OOA+xJnpuYsJIOdByKsBs90uUl2Q7leOS9gLx131AA+oxKrgtrwXwu A8HSDxcnitW38VKRKp0L3SoHiSBq8D4VXD10OyzNMz8Pzhixa84uQwa9kxUNlVli28w6 qCRYo2/nqQ7tZSIsFzd8wmV4pmfnYM+klYkUZWOcVLhyFOQ1/EOwmna1DxM/7gXQ3yOk +zxlE+9bwkfLv+e/06/kgrKeYvDLE0rtpKyA66O8aqc1rEKXpie9WeAuiZ4X/yxAbCeL F7Cn12rOZD0kt4Uf54dgL6TppF2QXdvkaSTF5GLrQQYcVnUjR6W3bZXbQMpEDcNr2GjS 0A+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=mG+54AZf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id q15-20020a17090311cf00b00153b2d1659fsi16941494plh.423.2022.05.02.17.42.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 May 2022 17:42:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=mG+54AZf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 82B4849F0A; Mon, 2 May 2022 17:32:58 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237094AbiD2Sxw (ORCPT + 99 others); Fri, 29 Apr 2022 14:53:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380038AbiD2Sxq (ORCPT ); Fri, 29 Apr 2022 14:53:46 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27E1CFD3A for ; Fri, 29 Apr 2022 11:50:27 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id b12so7890049plg.4 for ; Fri, 29 Apr 2022 11:50:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=u1HmvvieFlCfkGXvK05S5+zMzYlMfV0Veo9KAjtkzYQ=; b=mG+54AZfWbeW2iOtvNrKonJxh9Y6EHLlz4NF6ODAGEoXEFRaDwOfhLeMdp1rIQpQfE mLxZTl81cHPvVkWpS02N/atA4xBKvH29QbPVJxa7X3D4LPsCOeyL5L84ZpRn36+dMFpQ zl4k7cpRzsJJfPRt5F2Etc3fm9an44E3ehbSM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=u1HmvvieFlCfkGXvK05S5+zMzYlMfV0Veo9KAjtkzYQ=; b=rAfb8RlYOVnjCAWCPxgveCL5cUT4kkZND2F4nn4U04He9VZLsuiJxVr0BNqzeX3ouN TTMfFASPj3uWNPQXc3BjnOUzNJNhKTJBPybt4t4Tn5wao9R+evMHA4jwna8Ru0xu6u16 ggBOCSFaU8qfWQ0YFnRl3qOKarGc+jSjCNJPPgMgWIDiyWoPMDo3xQoqA9P9rQnkzCOq kPgbOqFuCDi6AN7KfL9e2nEZGHlmZDxlZuBe00QKPRtcS49CrNILbeZ8HwKXceh1fLgV fp3M+pcZZ/BxVO/Augq4gEXxno8IzWeO1Uv8vxJ3PdnHcFHEOg9Dr8wp/a3gFYfFiTTC +pZg== X-Gm-Message-State: AOAM5326/sqPboDcAm00w6dz2vicLnNhIIY6fUA6iTOCpsVPNlZ3DX1y yCSX+iySS0YOmDTzaqZ3pW8lYA== X-Received: by 2002:a17:90a:a82:b0:1da:3763:5cf5 with SMTP id 2-20020a17090a0a8200b001da37635cf5mr514716pjw.55.1651258226674; Fri, 29 Apr 2022 11:50:26 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id j189-20020a62c5c6000000b0050d59986dcdsm3866310pfg.208.2022.04.29.11.50.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Apr 2022 11:50:26 -0700 (PDT) From: Kees Cook To: linux-kernel@vger.kernel.org, sargun@sargun.me, luto@kernel.org, tycho@tycho.pizza Cc: Kees Cook , Christian Brauner Subject: Re: [PATCH 1/2] seccomp: Use FIFO semantics to order notifications Date: Fri, 29 Apr 2022 11:50:00 -0700 Message-Id: <165125819819.3692727.9306925856353932810.b4-ty@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220428015447.13661-1-sargun@sargun.me> References: <20220428015447.13661-1-sargun@sargun.me> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Apr 2022 18:54:46 -0700, Sargun Dhillon wrote: > Previously, the seccomp notifier used LIFO semantics, where each > notification would be added on top of the stack, and notifications > were popped off the top of the stack. This could result one process > that generates a large number of notifications preventing other > notifications from being handled. This patch moves from LIFO (stack) > semantics to FIFO (queue semantics). > > [...] Applied (which comment typo fix) to for-next/seccomp, thanks! [1/2] seccomp: Use FIFO semantics to order notifications https://git.kernel.org/kees/c/4cbf6f621150 [2/2] selftests/seccomp: Ensure that notifications come in FIFO order https://git.kernel.org/kees/c/662340ef9218 -- Kees Cook