Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp224761iob; Mon, 2 May 2022 17:45:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxgmufqMTc3lmS1qDH5HFNwQ3e0j+GS+TLubrNWgddqrx/oaZS8ue1RDmfI8+wT4mG4wxvT X-Received: by 2002:a17:90b:3809:b0:1d2:ab07:484a with SMTP id mq9-20020a17090b380900b001d2ab07484amr1949040pjb.236.1651538710210; Mon, 02 May 2022 17:45:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651538710; cv=none; d=google.com; s=arc-20160816; b=qaqvM7l9r68CTtlfKxGpNrEaDhzjUuNMpoL6HOs9Mx9RcA6MjW/cS/2SZGRCNJq3GT hZ4Qxxtx1yydChq4WrLMrIoJxEgG3tlz2rB4ZB1mSwBq2+SovYHoGD2jXskehYTj93LI Ou5g+XnDE7XU5fEwqJdv4LG8GZ/gSUeLdYXzcc04yaL2OmeJVk9eMLCke63VzMzG1w8G owNXyza+sYSZBTdmtN2yaNd/YUKt4Mz/Fx6RBSBk4vdh/BuxY9CkSD9w8Z6q+C5V5gFk i9piq77ZcrUlZvbyetNI65nPtteDjNz0stJT0apsalBxNrcEEzBa+j5Cy7j3QD8as+8c Hryg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=pxq9WR6UrwnSZiislFEXv8hXtqORJMe8BWzhT5vUNzo=; b=GY3BO+gcxGvM+oM43/D46zmlv0WLvdgExRMNW+A/S4tdQfpxh7XRKHhUu7PoEKbdkA IJs6kxH+GKnELvGqpIugJS+8UBGmysoaMo5qCRr2Ngxhc2izQAsjIH0+LJONZDvgleE4 jxTL9vM+D/Gr27YwnuHtm8424JvnD7UIlImFx1lSs1JdxQJTnR4c8SRnAq0KUcomwLLN k7TlkCzDIXwP5yI6yV/La3J0S2aYj6GlLHddpBQnmEpq92fU/8Q13Hku/p5OAvyg9X3y 20XUW7Px5gv7OOFeNKEDNOPrRPGMrdX4hXNPuuvKVbkQ7/udupv0qBiNjQD9wqjRmlwF vHjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=FYaSw7qV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id mi15-20020a17090b4b4f00b001d1ad44a667si867714pjb.6.2022.05.02.17.45.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 May 2022 17:45:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=FYaSw7qV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D8422326EA; Mon, 2 May 2022 17:34:36 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232842AbiEBLnM (ORCPT + 99 others); Mon, 2 May 2022 07:43:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232611AbiEBLnK (ORCPT ); Mon, 2 May 2022 07:43:10 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5903515FDF; Mon, 2 May 2022 04:39:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 15528B81657; Mon, 2 May 2022 11:39:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9598FC385AF; Mon, 2 May 2022 11:39:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651491579; bh=WSHwriL2NKIWz7/ayg94uts9h/We1ZDjIIHGMTCDU1Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FYaSw7qVeQY/1RjtQHtZyPreRSSvo1ycGJh3qjZdzr/A5eZKYaMBHWrjuLfc9i/2F 4CALcNjkcxrF3NhvN73aoGSSIx2KQyIBPliS9iiZqpyfBSm+TkRwIiHPPvlb0QThky gJI8vxI9Aa3RnD6NmT+8zqmcdTr2uR4ypYYKl+gQ= Date: Mon, 2 May 2022 13:39:38 +0200 From: Greg KH To: Hector Martin Cc: Marc Zyngier , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Alyssa Rosenzweig , Sven Peter , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/3] PCI: apple: GPIO handling nitfixes Message-ID: References: <20220502093832.32778-1-marcan@marcan.st> <20220502093832.32778-2-marcan@marcan.st> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220502093832.32778-2-marcan@marcan.st> X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 02, 2022 at 06:38:30PM +0900, Hector Martin wrote: > - Use devm managed GPIO getter > - GPIO ops can sleep in this context Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. This text does not make any sense. Same for your subject, it needs to be reworked. thanks, greg k-h