Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 2 May 2022 13:21:12 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Icenowy Zheng <icenowy@aosc.io>
Cc:     Ruslan Zalata <rz@fabmicro.ru>, Guenter Roeck <linux@roeck-us.net>,
        Jean Delvare <jdelvare@suse.com>, Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v2] hwmon: (sun4i-lradc) Add driver for LRADC found on
 Allwinner A13/A20 SoC
Message-ID: <20220502112112.3ne7zy4b6gggxzoo@houat>
References: <20220428210906.29527-1-rz@fabmicro.ru>
 <20220502110010.q7vvdkdpaiz5acjl@houat>
 <7433B295-D896-4BF8-87DF-87EB89D7A550@aosc.io>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="mg35qjdbc5ra2hwr"
Content-Disposition: inline
In-Reply-To: <7433B295-D896-4BF8-87DF-87EB89D7A550@aosc.io>
Precedence: bulk


--mg35qjdbc5ra2hwr
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, May 02, 2022 at 07:15:01PM +0800, Icenowy Zheng wrote:
>=20
>=20
> =E4=BA=8E 2022=E5=B9=B45=E6=9C=882=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=887=
:00:10, Maxime Ripard <maxime@cerno.tech> =E5=86=99=E5=88=B0:
> >Hi,
> >
> >On Thu, Apr 28, 2022 at 09:09:03PM +0000, Ruslan Zalata wrote:
> >> Some Allwinner SoCs like A13, A20 or T2 are equipped with two-channel
> >> low rate (6 bit) ADC that is often used for extra keys. There's a driv=
er
> >> for that already implementing standard input device, but it has these
> >> limitations: 1) it cannot be used for general ADC data equisition, and
> >> 2) it uses only one LRADC channel of two available.
> >>=20
> >> This driver provides basic hwmon interface to both channels of LRADC on
> >> such Allwinner SoCs.
> >>=20
> >> Signed-off-by: Ruslan Zalata <rz@fabmicro.ru>
> >> ---
> >>  MAINTAINERS                       |   6 +
> >>  drivers/hwmon/Kconfig             |  13 ++
> >>  drivers/hwmon/Makefile            |   1 +
> >>  drivers/hwmon/sun4i-lradc-hwmon.c | 280 ++++++++++++++++++++++++++++++
> >>  4 files changed, 300 insertions(+)
> >>  create mode 100644 drivers/hwmon/sun4i-lradc-hwmon.c
> >>=20
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> >> index 5e8c2f61176..d9c71e94133 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -18861,6 +18861,12 @@ S:	Maintained
> >>  F:	Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-=
keys.yaml
> >>  F:	drivers/input/keyboard/sun4i-lradc-keys.c
> >> =20
> >> +SUN4I LOW RES ADC HWMON DRIVER
> >> +M:	Ruslan Zalata <rz@fabmicro.ru>
> >> +L:	linux-hwmon@vger.kernel.org
> >> +S:	Maintained
> >> +F:	drivers/hwmon/sun4i-lradc-hwmon.c
> >> +
> >>  SUNDANCE NETWORK DRIVER
> >>  M:	Denis Kirjanov <kda@linux-powerpc.org>
> >>  L:	netdev@vger.kernel.org
> >> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> >> index 68a8a27ab3b..86776488a81 100644
> >> --- a/drivers/hwmon/Kconfig
> >> +++ b/drivers/hwmon/Kconfig
> >> @@ -1691,6 +1691,19 @@ config SENSORS_SIS5595
> >>  	  This driver can also be built as a module. If so, the module
> >>  	  will be called sis5595.
> >> =20
> >> +config SENSORS_SUN4I_LRADC
> >> +	tristate "Allwinner A13/A20 LRADC hwmon"
> >> +	depends on ARCH_SUNXI && !KEYBOARD_SUN4I_LRADC
> >> +	help
> >> +	  Say y here to support the LRADC found in Allwinner A13/A20 SoCs.
> >> +	  Both channels are supported.
> >> +
> >> +	  This driver can also be built as module. If so, the module
> >> +	  will be called sun4i-lradc-hwmon.
> >> +
> >> +	  This option is not compatible with KEYBOARD_SUN4I_LRADC, one
> >> +	  of these must be used at a time.
> >
> >How do you plan on enforcing that?
> >
> >I guess a better path forward would be to either register an hwmon
> >device in the original driver, or convert that driver to iio and use
> >iio-hwmon.
>=20
> I think this driver should be use IIO, and then try to probe an IIO input
> if possible.

It's been a while, but if I remember well we couldn't use IIO for that
driver because it's not generating interrupts all the time but only when
it goes over a given threshold:

https://lore.kernel.org/all/52C5E9F1.9010700@redhat.com/

I'm not sure if it's still relevant, so we might just need to add an
hwmon driver to the existing driver

Maxime

--mg35qjdbc5ra2hwr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYm++qAAKCRDj7w1vZxhR
xZfzAP45baOfMHgE07gDuTms0R435nh6idYPLh86SZXpVD1x0wEA0e2PYbOvaM4Q
hel2Z4Gtv0wdzACyM6T9aRjdarTmdww=
=z935
-----END PGP SIGNATURE-----

--mg35qjdbc5ra2hwr--