Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
IronPort-SDR: ISx7bbVZS5keDKf7JX7oqXXE9Xho5CeaDGl6RUqxnl61DR32TcUCodIwsfdiDGefkb+TTC8emw
 NLZwvprb8daOK2Dq8VThbDLHRaUFHk58JRUCjDJ+5gsPWndy4KnAXgtKDb1E9gw+44z/gGyd6F
 PI1YdnLjUrUBHgtR5MiPl9ydld2AhGGuoO4+aRsaL6XLm0hioleep7pQwU/K6kMCqcxcNM9wTb
 IsOaQv9AHow3xw2xwqyN426pRbJOeJEWn2u3aDeDm15X2II+g4ePjO69rmIRe3u5vAFXRsMbGr
 O544QCktnOd0chWKUFQ/4srT
IronPort-SDR: 3grF/NDXUQQgyxlHUsJ7HuwPZMOczzbjSXfd7hosS6IAjh3KKOWkYCVK+RpMkIJm6tsgv3ebAM
 CDaB+/KkaEADGxQ4/HpN9LVoQtJQrXn24uHCQ9pEIoR7LSQaa6dS4tVv5QSHCs8jAzqUr/rWj9
 1lnUxHZnSGPBJ41LSotAFAg1UIeFerXbeGfBUv8FmN29nbVvVCfbu45ii1rzroqZemWivf9DSW
 6OOVeVFOGsGxWuRX0+G992eNR+9GtbEiSpbQqRR6lT10M4dJZX0tdM7fw79IoIeXVfpz2yCO0o
 YY4=
WDCIronportException: Internal
Message-ID: <260b95e8-74bf-9460-cf0d-7e3df1b1a3c7@opensource.wdc.com>
Date:   Mon, 2 May 2022 21:14:34 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [dm-devel] [PATCH v4 00/10] Add Copy offload support
Content-Language: en-US
To:     Nitesh Shetty <nj.shetty@samsung.com>
Cc:     linux-scsi@vger.kernel.org, nitheshshetty@gmail.com,
        linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
        linux-block@vger.kernel.org, dm-devel@redhat.com,
        linux-fsdevel@vger.kernel.org
References: <CGME20220426101804epcas5p4a0a325d3ce89e868e4924bbdeeba6d15@epcas5p4.samsung.com>
 <20220426101241.30100-1-nj.shetty@samsung.com>
 <6a85e8c8-d9d1-f192-f10d-09052703c99a@opensource.wdc.com>
 <20220427124951.GA9558@test-zns>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220427124951.GA9558@test-zns>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 2022/04/27 21:49, Nitesh Shetty wrote:
> O Wed, Apr 27, 2022 at 11:19:48AM +0900, Damien Le Moal wrote:
>> On 4/26/22 19:12, Nitesh Shetty wrote:
>>> The patch series covers the points discussed in November 2021 virtual=
 call
>>> [LSF/MM/BFP TOPIC] Storage: Copy Offload[0].
>>> We have covered the Initial agreed requirements in this patchset.
>>> Patchset borrows Mikulas's token based approach for 2 bdev
>>> implementation.
>>>
>>> Overall series supports =E2=80=93
>>>
>>> 1. Driver
>>> - NVMe Copy command (single NS), including support in nvme-target (fo=
r
>>>     block and file backend)
>>
>> It would also be nice to have copy offload emulation in null_blk for t=
esting.
>>
>=20
> We can plan this in next phase of copy support, once this series settle=
s down.

Why ? How do you expect people to test simply without null_blk ? Sutre, y=
ou said
QEMU can be used. But if copy offload is not upstream for QEMU either, th=
ere is
no easy way to test.

Adding that support to null_blk would not be hard at all.


--=20
Damien Le Moal
Western Digital Research