Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Sender: Minchan Kim <minchan.kim@gmail.com>
Date:   Mon, 2 May 2022 11:11:51 -0700
From:   Minchan Kim <minchan@kernel.org>
To:     Aleksey Romanov <AVRomanov@sberdevices.ru>
Cc:     Sergey Senozhatsky <senozhatsky@chromium.org>,
        "ngupta@vflare.org" <ngupta@vflare.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "axboe@chromium.org" <axboe@chromium.org>,
        kernel <kernel@sberdevices.ru>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "mnitenko@gmail.com" <mnitenko@gmail.com>,
        Dmitry Rokosov <DDRokosov@sberdevices.ru>
Subject: Re: [PATCH v2] zram: remove double compression logic
Message-ID: <YnAe52Eg60tjeBNK@google.com>
References: <20220427100345.29461-1-avromanov@sberdevices.ru>
 <YmkpSC/gJf7Cg2Ym@google.com>
 <20220428200107.hz65qvxf2aoz27q2@cab-wsm-0029881>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220428200107.hz65qvxf2aoz27q2@cab-wsm-0029881>
Precedence: bulk

Hi Aleksey,

On Thu, Apr 28, 2022 at 08:01:12PM +0000, Aleksey Romanov wrote:
> Thanks for the reply!
> 
> On Wed, Apr 27, 2022 at 08:30:16PM +0900, Sergey Senozhatsky wrote:
> > On (22/04/27 13:03), Alexey Romanov wrote:
> > > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> > > index cb253d80d72b..4be6caf43b1d 100644
> > > --- a/drivers/block/zram/zram_drv.c
> > > +++ b/drivers/block/zram/zram_drv.c
> > > @@ -1153,9 +1153,8 @@ static ssize_t debug_stat_show(struct device *dev,
> > >  
> > >  	down_read(&zram->init_lock);
> > >  	ret = scnprintf(buf, PAGE_SIZE,
> > > -			"version: %d\n%8llu %8llu\n",
> > > +			"version: %d\n%8llu\n",
> > >  			version,
> > > -			(u64)atomic64_read(&zram->stats.writestall),
> > >  			(u64)atomic64_read(&zram->stats.miss_free));
> > >  	up_read(&zram->init_lock);
> > 
> > I think this also has to bump `version` to 2, since format of the
> > file has changed.
> 
> Yes, I'll do that in the next patch.
> 
> Minchan, do you have any suggestions on this patch? 
> I want to fix Sergey suggestion and sumbit next patch.

You need to remove zs_free in the path "Compression failed"

Since we don't have double compression, we don't need QUEUE_FLAG_STABLE_WRITES
so you could remove QUEUE_FLAG_STABLE_WRITES, too.

Thanks.