Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <dd494b32-c374-888f-b7e3-24cc388a9717@roeck-us.net>
Date:   Thu, 28 Apr 2022 10:13:02 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v8 23/70] mm/mmap: change do_brk_flags() to expand
 existing VMA and add do_brk_munmap()
Content-Language: en-US
To:     Liam Howlett <liam.howlett@oracle.com>
Cc:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Yu Zhao <yuzhao@google.com>
References: <20220426150616.3937571-1-Liam.Howlett@oracle.com>
 <20220426150616.3937571-24-Liam.Howlett@oracle.com>
 <20220428160949.GA2923383@roeck-us.net>
 <20220428163512.kmx3yvghn3txpjee@revolver>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <20220428163512.kmx3yvghn3txpjee@revolver>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/28/22 09:35, Liam Howlett wrote:
> * Guenter Roeck <linux@roeck-us.net> [220428 12:10]:
>> On Tue, Apr 26, 2022 at 03:06:35PM +0000, Liam Howlett wrote:
>>> From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
>>>
>>> Avoid allocating a new VMA when it a vma modification can occur.  When a
>>> brk() can expand or contract a VMA, then the single store operation will
>>> only modify one index of the maple tree instead of causing a node to split
>>> or coalesce.  This avoids unnecessary allocations/frees of maple tree
>>> nodes and VMAs.
>>>
>>> Move some limit & flag verifications out of the do_brk_flags() function to
>>> use only relevant checks in the code path of bkr() and vm_brk_flags().
>>>
>>> Set the vma to check if it can expand in vm_brk_flags() if extra criteria
>>> are met.
>>>
>>> Drop userfaultfd from do_brk_flags() path and only use it in
>>> vm_brk_flags() path since that is the only place a munmap will happen.
>>>
>>> Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
>>
>> This patch results in boot failures on alpha. Trying to revert it results
>> in conflicts, so I was unable to cross-check. Bisect log attached. The failure
>> is silent - boot simply stalls after "random: crng init done", so attaching
>> a boot log doesn't add value.
> 
> Thanks.  I can only find Gentoo iso for testing, is there any other
> options?
> 

You could try with images from https://github.com/groeck/linux-build-test.

Guenter