Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp233636iob; Mon, 2 May 2022 18:01:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyX9GL9rRct/c35rhE59gt0fEGiGoZLcENRmhvqFFVpjhDPqG49RvVj8on+6ctixVjg+pGE X-Received: by 2002:a63:2b91:0:b0:3ab:3da7:b5ac with SMTP id r139-20020a632b91000000b003ab3da7b5acmr11905524pgr.36.1651539687866; Mon, 02 May 2022 18:01:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651539687; cv=none; d=google.com; s=arc-20160816; b=zg6yXY+bEFvKgYUcAmmNPWLKsWs7ut2wwZr7wjkCMBZOBuVaeh4Bn1gdfRbpOC+1J4 zyv7tO7m5h1/5yPYX6VS8oXVkz3zH43MEKfKm26+kqQPBJEEpSIJxJ92VAa2so0BiT7u YBEg2jUwcWL07A1HlxTHNIWWbTEDYVJLKhf08jFY/GspDj4EvFErigl07ZehticGJf6K xCLiX4/JITcZrlBL9ZhL6sZq42MyT5uiPXNgzqCL6GwCKBw/9SoRxixWipSI0DE+cAuZ rRxhky1LscKx2eQvuwjpZ/ColI65Pb4nMVQ13XfuXV0m6HnFoDGl0G0usCTa0YDu6I+q UeaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:sender:dkim-signature; bh=UBP7y2RvEXxVN92BvqAi7m+pLWAZ5atsFjO8+tg56fk=; b=jcnbvvVpUcj0a0V26jKoyfFLkI/QaDrIykAwQHS+khowCGpIcp+7h8FaU86EwAkSrH 72Q5e+45PaHDsUj1hSliD7TS4I8cMhUcGus6DjSkMRhjm3xWYamHoEvelLfJ6NNRoTiI tFDeSKv26Q4dPl+RFiUSa/RPt5MWEO+uUS6Z85QdfvpsRGkCVzm425gvd5zIpXMLIopx oiNt9FfYoHyVuimGYjT7h+zlBop7GUc7C6ov0KSZaf6dMU9/AV7Z5LRruovyn/eCOPi0 xVCg9cn6NjHw9vac7BurrmIbBg2Ud89ftlm91Pra1BXrmaPY17O7ZCLgXLkkPinPpM/A +jqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Vcv2k97R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id o128-20020a625a86000000b0050d28930dbcsi14381830pfb.192.2022.05.02.18.01.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 May 2022 18:01:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Vcv2k97R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DC1C64348B; Mon, 2 May 2022 17:45:40 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235346AbiD1RQX (ORCPT + 99 others); Thu, 28 Apr 2022 13:16:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232392AbiD1RQV (ORCPT ); Thu, 28 Apr 2022 13:16:21 -0400 Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 294B05B3CB for ; Thu, 28 Apr 2022 10:13:06 -0700 (PDT) Received: by mail-ot1-x32d.google.com with SMTP id k25-20020a056830169900b00605f215e55dso187835otr.13 for ; Thu, 28 Apr 2022 10:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UBP7y2RvEXxVN92BvqAi7m+pLWAZ5atsFjO8+tg56fk=; b=Vcv2k97RR1epKhR1NUb5TDyl7ffQ1Gs/U2EaOWViBSxBV2K5mnoTB5Dk7V8rgEsnzA Xh9twu69XPL3owjHPgs5K57Dq1UH4/7JUWsjLn98QLs43+U7mAUW0/33O7buWhhnvVjw HjYfxbtbuBtzNqyn1y39tXpMn6AU+Gz3C/FmVTUCX4mKHO3TETxqe2xtUOOEBdansDGm 2+kdDl/4yRszPMS5PVPaOz+IXghdzI9Hie1E4xFN5jT97E71Ma+JvES94/1S99h/VKor EPl23NnvKb1SrBAZIuHoSwWcIVwPdaC0aOfjdJu61qAGz+4bQH1bE7KOoGL14zd2HHig pnTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UBP7y2RvEXxVN92BvqAi7m+pLWAZ5atsFjO8+tg56fk=; b=2mXfyFHFMDbYQF0iafnG3GnIlQHxRI8ARLMv/qV7gGaVhR5z7+WJGjXn/nFLeOhgDQ 5EBxBptWXMaq0a7V2uoztOWF9GbHE4zS0nc2rblxhZ8EOf6DkSHCWd7uqyoQzCfIn+eP CJhFvESZWtvs3kF1O807qNa8rj0mNhhi0JzdGMAIYwcqjIKL1j9ukDrbZzCOw7NghlcZ sMpM4mGcmTWw57DTHSE4qkcluKrEbf/c9AwtVlv81JWg0703z8lp8Ad/v+lIecgsuh4t 1SC6KPLxSpoDFYLqKfqhNa3h2mIH5r6s8Vec2F1OIhIboiXgPPpQeCecmUz1ffFp+lxk 9oQA== X-Gm-Message-State: AOAM533exvUvElxMJ9gLA9oBcmhAUlhQdFZSzO4rz7qR3PakFp3teJVA NsnwcwdGHJ9absp8JTdn880Nf7UI8iw= X-Received: by 2002:a05:6830:1d55:b0:5ff:7c6f:ba6a with SMTP id p21-20020a0568301d5500b005ff7c6fba6amr12302592oth.240.1651165985510; Thu, 28 Apr 2022 10:13:05 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id g2-20020a9d6b02000000b00605e077186asm196392otp.11.2022.04.28.10.13.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 10:13:04 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Thu, 28 Apr 2022 10:13:02 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v8 23/70] mm/mmap: change do_brk_flags() to expand existing VMA and add do_brk_munmap() Content-Language: en-US To: Liam Howlett Cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , Yu Zhao References: <20220426150616.3937571-1-Liam.Howlett@oracle.com> <20220426150616.3937571-24-Liam.Howlett@oracle.com> <20220428160949.GA2923383@roeck-us.net> <20220428163512.kmx3yvghn3txpjee@revolver> From: Guenter Roeck In-Reply-To: <20220428163512.kmx3yvghn3txpjee@revolver> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/28/22 09:35, Liam Howlett wrote: > * Guenter Roeck [220428 12:10]: >> On Tue, Apr 26, 2022 at 03:06:35PM +0000, Liam Howlett wrote: >>> From: "Liam R. Howlett" >>> >>> Avoid allocating a new VMA when it a vma modification can occur. When a >>> brk() can expand or contract a VMA, then the single store operation will >>> only modify one index of the maple tree instead of causing a node to split >>> or coalesce. This avoids unnecessary allocations/frees of maple tree >>> nodes and VMAs. >>> >>> Move some limit & flag verifications out of the do_brk_flags() function to >>> use only relevant checks in the code path of bkr() and vm_brk_flags(). >>> >>> Set the vma to check if it can expand in vm_brk_flags() if extra criteria >>> are met. >>> >>> Drop userfaultfd from do_brk_flags() path and only use it in >>> vm_brk_flags() path since that is the only place a munmap will happen. >>> >>> Signed-off-by: Liam R. Howlett >> >> This patch results in boot failures on alpha. Trying to revert it results >> in conflicts, so I was unable to cross-check. Bisect log attached. The failure >> is silent - boot simply stalls after "random: crng init done", so attaching >> a boot log doesn't add value. > > Thanks. I can only find Gentoo iso for testing, is there any other > options? > You could try with images from https://github.com/groeck/linux-build-test. Guenter