Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <ee3feb13-fbf8-6651-76ff-1324878d72e8@digikod.net>
Date:   Mon, 2 May 2022 21:13:05 +0200
MIME-Version: 1.0
User-Agent: 
Content-Language: en-US
From:   =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= <mic@digikod.net>
To:     Miguel Ojeda <ojeda@kernel.org>,
        Andy Whitcroft <apw@canonical.com>,
        Joe Perches <joe@perches.com>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc:     Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, llvm@lists.linux.dev,
        linux-kernel@vger.kernel.org
References: <8b6b252b-47a6-9d52-f0bd-10d3bc4ad244@digikod.net>
Subject: Re: clang-format inconsistencies with checkpatch.pl
In-Reply-To: <8b6b252b-47a6-9d52-f0bd-10d3bc4ad244@digikod.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 23/04/2022 13:45, Mickaël Salaün wrote:
> Hi,
> 
> I would like to use clang-format (with a pinned version, probably 14) to 
> keep a consistent coding style, or at least start with one. However, 
> there is some inconsistencies with the checkpatch.pl script:
> 
> In some cases, goto labels are indented, which checkpatch.pl doesn't like.

This can be fixed with SplitEmptyFunction: false. I'll send a patch for 
that if it's OK with you.

> 
> checkpatch.pl complains about some functions (e.g. FIXTURE or 
> FIXTURE_VARIANT_ADD) that get an open brace just after but without a space.

Miguel, do you know how/if clang-format can enforce that style? FIXTURE 
macros are struct declarations though.