Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp241598iob; Mon, 2 May 2022 18:14:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVoj9vQL0u3JNb7sXkgiofrXdsIy6kNryvxYSxYfO+8vygKr7U2L3M4lZJ8zll8eMwh2PO X-Received: by 2002:a17:902:6bc9:b0:158:a0d3:d080 with SMTP id m9-20020a1709026bc900b00158a0d3d080mr14602554plt.24.1651540495844; Mon, 02 May 2022 18:14:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651540495; cv=none; d=google.com; s=arc-20160816; b=SLl5gtzYvjgJQsDl+xUhgV3UMWC6BuxYu2BFUAK97Dl82HxsxdURhFiWiuleviMSX8 mXs5stdTEgkHTmWiIsUkDu1kGdzdypqD5zGHT8O6R13BsrVVVylMXD+LQuSlJdsoft2H n+YPJgwidPBaMGZZfrvbfPZ14q3XRJdplG3DNa+BIEkB0eMA1HaX3RFyHtXkvsE3hy+A QXPU6AYfmbz9Hx9UmzVCOkaw+2ERxDG+b4sG2CmjcBOJ49+klbiroYyu2Q4eNLlMoLcW J1zUndxRSjyAudHRuyHf+KLBtqASF9gfm1pzby2IZ1acKoUsu7RYRZGLg0uLF3t/KM3p LjYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=/Ntv7zv1FrmWHb+PvRkaGud3vEWnl0ReBjk0xBH+pec=; b=yyBeTYo68IGVVdCmdKWJsfbL1QGd8gLhVwyq/LKo6mduEAUnwynAilQlDyMFaGmrwX A0SwBI2ytOPKFUIyIbTz2LGflwVFCOBrrZMhhhQKb6lXI/Vy+DccQfx0uf/uRvRpTboS haO8WiH1ZIltSCrB6Be4S7eJ35ltsx/EbSdUs9ec6hZ4q9sriWGHMHoj2v57SId2Onr1 /wEoqN3H5hCp25WcgFYWOXFlm1N/nImAsUQRUkZDFQPjZv2xxgRQ9Vq4DU2Y4B2Gv66s LCwgcYzHfD+Dqo+3/X5JtWjHGtQbaIVUOZmFNRFD4oiPBkpkN1rObSuwPdQFwLtQAHFT 1mrw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id 189-20020a6215c6000000b0050d3f057ea9si14669873pfv.235.2022.05.02.18.14.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 May 2022 18:14:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AC665473AE; Mon, 2 May 2022 17:55:14 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234470AbiEBUAN (ORCPT + 99 others); Mon, 2 May 2022 16:00:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbiEBUAK (ORCPT ); Mon, 2 May 2022 16:00:10 -0400 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54F48BC39; Mon, 2 May 2022 12:56:40 -0700 (PDT) Received: by mail-oi1-f170.google.com with SMTP id a10so16226065oif.9; Mon, 02 May 2022 12:56:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/Ntv7zv1FrmWHb+PvRkaGud3vEWnl0ReBjk0xBH+pec=; b=oI4uw+2RFPN9b4EnFnSII/con/7rOKKCOV3yeDqZ2P44mBTzAN5g1wAJWuPBXI4MUL yA6np3Bj6kDx167nxodKlIjWcBhvynGq9OEvbGccO6Y68z4X532cwwV77iRz1JURON8R R1R8MWzEEOcK43mZ7yCJcWLU9NrXq9QNFvU1erUrtD/I9mwXd2vmd/ZyN6ITSHAe8fcB 8Hj/hNBohHMwT6GtgtY2+8qMb/TxErCzxO0a/432IBqshk7NuQY1p4yzq825IqNQNSTL 40rNwp0lJFCG+6yEyupzix0gdpHK9b1cO0C17leiyL26pwhi+SsIHvefVdm+ENFjNNu9 K5Iw== X-Gm-Message-State: AOAM531UofO/etTDnfouy62MFLquqjrspStK8+YEENYAOEONVcqkruc7 1NMTcOWz8E6LtvLpr1B1mw== X-Received: by 2002:aca:5b45:0:b0:2fa:7d3b:6997 with SMTP id p66-20020aca5b45000000b002fa7d3b6997mr365355oib.258.1651521399580; Mon, 02 May 2022 12:56:39 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id w2-20020a056830110200b006060322127esm3205340otq.78.2022.05.02.12.56.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 May 2022 12:56:39 -0700 (PDT) Received: (nullmailer pid 1633203 invoked by uid 1000); Mon, 02 May 2022 19:56:38 -0000 Date: Mon, 2 May 2022 14:56:38 -0500 From: Rob Herring To: Puranjay Mohan Cc: linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, mathieu.poirier@linaro.org, krzysztof.kozlowski+dt@linaro.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, nm@ti.com, ssantosh@kernel.org, s-anna@ti.com, linux-arm-kernel@lists.infradead.org, rogerq@kernel.org, grygorii.strashko@ti.com, vigneshr@ti.com, kishon@ti.com Subject: Re: [PATCH v3 1/5] dt-bindings: remoteproc: Add PRU consumer bindings Message-ID: References: <20220418104118.12878-1-p-mohan@ti.com> <20220418104118.12878-2-p-mohan@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220418104118.12878-2-p-mohan@ti.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 18, 2022 at 04:11:14PM +0530, Puranjay Mohan wrote: > From: Suman Anna > > Add a YAML binding document for PRU consumers. The binding includes > all the common properties that can be used by different PRU consumer > or application nodes and supported by the PRU remoteproc driver. > These are used to configure the PRU hardware for specific user > applications. > > The application nodes themselves should define their own bindings. > > Co-developed-by: Tero Kristo > Signed-off-by: Tero Kristo > Signed-off-by: Suman Anna > Co-developed-by: Grzegorz Jaszczyk > Signed-off-by: Grzegorz Jaszczyk > Signed-off-by: Puranjay Mohan > --- > .../bindings/remoteproc/ti,pru-consumer.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml > > diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml > new file mode 100644 > index 000000000000..5b1f1cb2f098 > --- /dev/null > +++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/remoteproc/ti,pru-consumer.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Common TI PRU Consumer Binding > + > +maintainers: > + - Suman Anna > + > +description: | > + A PRU application/consumer/user node typically uses one or more PRU device > + nodes to implement a PRU application/functionality. Each application/client > + node would need a reference to at least a PRU node, and optionally define > + some properties needed for hardware/firmware configuration. The below > + properties are a list of common properties supported by the PRU remoteproc > + infrastructure. > + > + The application nodes shall define their own bindings like regular platform > + devices, so below are in addition to each node's bindings. > + > +properties: > + ti,prus: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: phandles to the PRU, RTU or Tx_PRU nodes used > + minItems: 1 > + maxItems: 6 > + items: > + maxItems: 1 > + > + firmware-name: > + $ref: /schemas/types.yaml#/definitions/string-array > + description: | > + firmwares for the PRU cores, the default firmware for the core from > + the PRU node will be used if not provided. The firmware names should > + correspond to the PRU cores listed in the 'ti,prus' property So should be the name number of entries?: minItems: 1 maxItems: 6 > + > + ti,pruss-gp-mux-sel: > + $ref: /schemas/types.yaml#/definitions/uint32-array minItems: 1 > + maxItems: 6 > + items: > + enum: [0, 1, 2, 3, 4] > + description: | > + array of values for the GP_MUX_SEL under PRUSS_GPCFG register for a PRU. > + This selects the internal muxing scheme for the PRU instance. Values > + should correspond to the PRU cores listed in the 'ti,prus' property. The > + GP_MUX_SEL setting is a per-slice setting (one setting for PRU0, RTU0, > + and Tx_PRU0 on K3 SoCs). Use the same value for all cores within the > + same slice in the associative array. If the array size is smaller than > + the size of 'ti,prus' property, the default out-of-reset value (0) for the > + PRU core is used. > + > +required: > + - ti,prus > + > +dependencies: > + firmware-name: [ 'ti,prus' ] > + ti,pruss-gp-mux-sel: [ 'ti,prus' ] This doesn't make sense because 'ti,prus' is already required. Should all 3 properties always be required? > + > +additionalProperties: true > + > +examples: > + - | > + /* PRU application node example */ > + pru-app { > + ti,prus = <&pru0>, <&pru1>; > + firmware-name = "pruss-app-fw0", "pruss-app-fw1"; > + ti,pruss-gp-mux-sel = <2>, <1>; This example never validates, but okay I guess. > + }; > -- > 2.17.1 > >