Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp243190iob; Mon, 2 May 2022 18:17:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTzLvRdTNwRK6GgzgwxEcTA7FpH3iBEz1Te2qwOFFxmk9ll2gme66Y2BY4su6bDdINIB9F X-Received: by 2002:a05:6a02:182:b0:374:5a57:cbf9 with SMTP id bj2-20020a056a02018200b003745a57cbf9mr11501354pgb.616.1651540677029; Mon, 02 May 2022 18:17:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651540677; cv=none; d=google.com; s=arc-20160816; b=X/1d3sqSJTA6hgvBr5IdrP+3k2Cb1H+JzxTzPWxOIHDmRw2VLD2FpgfIdePCQ8Hd0R T+9qIfGSoiynZpvr6LRMRw3wD210Eu3lhIdTmXM5YZESKlhu0Q39lZKL1NO19sF/Rgv/ NpBBxicDjSsJgKcSL4L6tszWDgNlelC10olG52mM7wD6LVreQitDWi8p2SCEkBQgT3Rn 1xHlNnGCJ7kldiNHIlkEJjs8+aHDPsc1MYNw6ZcwiDdYnsLNU8OmgDJ3nDTKQH119SCU S+MLoA9bfEdRsSPyEpBJAkWvMtH0GBf7h44KyV+PiiiLxh2SvN7k0XCoyyDgdNAg7adb B0LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ftw/6Pk4qbemIBSil+khGkXsfOxW2R3zaTxbYT7tF+A=; b=aC9Jk8zh2W0Blchzc3VEpU+hMnkStt0A/TR8V/Vj/fVTDr7IhrMs6WgEH74axUCiGp 0dLpAbofMqpMk9YviqIvdO68VfF2SeTX4Gmz0JLq/T8OPIZVH10qx586659g+G0nlUTj lbm+pwqaAfex4ujBTksq7Z1D0gJMDKlf28f5IY4iHhwwmMhDEbzSpjjeAJcCeiitnAtJ mrXV8D/MJf7q07CR3Wjt9e+PqwpVr/G8Xdec80adP6AgmZqX5XdFKJ691v33ikiLzwWM KoapEa8OvOqYUMzMLVXUGn9NOb3/o4jyt4UXf85hteeeBT+rkvzEfwzG3PpPV1oY6hX2 TUYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=g9I5NVSJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id 11-20020a630f4b000000b003ab65457f62si15027840pgp.876.2022.05.02.18.17.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 May 2022 18:17:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=g9I5NVSJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 302F042483; Mon, 2 May 2022 17:57:27 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238652AbiD2JFg (ORCPT + 99 others); Fri, 29 Apr 2022 05:05:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230300AbiD2JFf (ORCPT ); Fri, 29 Apr 2022 05:05:35 -0400 Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D534EC42DD for ; Fri, 29 Apr 2022 02:02:15 -0700 (PDT) Received: by mail-qv1-xf32.google.com with SMTP id b17so4915764qvf.12 for ; Fri, 29 Apr 2022 02:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ftw/6Pk4qbemIBSil+khGkXsfOxW2R3zaTxbYT7tF+A=; b=g9I5NVSJ9ufUt1fbkyLlV3mWDiV9nFd2/RUyQGVUzcNDw9sl0UmRAWosE4/J4sazEZ 8iWEoZ8Xx7QFktAcdgQJkezZLP6ZjvM5iVoHlj98+CHXnP7mm2DgzQNe79yqXjJt3B5l d9xYEkwbCpoMZ93dZXAvm5yNgaMjz5CiT4YLxKRTXCktZ8h+NLc9NbndeS5CkVnzr9eA SbJA2+Ryiq7ZFqqFlu9eBmDsUqDmRplRCb+SWSY6HcaIUHMDruLqyGVjEe2p8LYlrbtI hcoogv5MEsakduy4A1uIgDuKKYKEkt0VmtRAEJAhMh8hsjciDgAEjPwJd6iqnAIKg+sK g3sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ftw/6Pk4qbemIBSil+khGkXsfOxW2R3zaTxbYT7tF+A=; b=N9N7TzjEJppZxEwX69sN6gDHCZp0iRiSUJJH69j/pC8fkNE7pjFCVd5SkXZcZvUuPY sr5mqAPEoz+LfFaJSE1JWqUJyKbT45PMNWgYj/oLjzcSGmW68VH/x7RZdqQoqsvL+Y7r Iz07vNmHg+8jnN99V/jXUefe0qFz0Ucd9TK40ZFTdEdO2OlfaIPfok16S6T9yPkp6uaZ P369hkkAsPb5AOmCKEz1e4/uDTwa0xB0HMhU8sPTIZy1QFgSG1PF+t3fbFZ6BQx1x0Sw yJDZ+ocOmXw9CvZ1hvwZW6pM5jJpPYxgfkGkCaNmGUjz0BP/l8JK0/DoeiYq20XW8HhY +lZw== X-Gm-Message-State: AOAM531aWqyvdctCdgCJWfcgahdIQQuttQFqqCBvNFRLTNP2vv6pXYBl Y4bHkw0+7mDF57L3ir7RK3A= X-Received: by 2002:a05:6214:2485:b0:452:ce7c:2dc3 with SMTP id gi5-20020a056214248500b00452ce7c2dc3mr15545677qvb.9.1651222935039; Fri, 29 Apr 2022 02:02:15 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id o21-20020a05620a0d5500b0069c59fae1a5sm1106657qkl.96.2022.04.29.02.02.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Apr 2022 02:02:14 -0700 (PDT) From: cgel.zte@gmail.com X-Google-Original-From: chi.minghao@zte.com.cn To: emma@anholt.net Cc: mripard@kernel.org, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Minghao Chi , Zeal Robot Subject: [PATCH] drm/vc4: simplify the return expression of vc4_grab_bin_bo() Date: Fri, 29 Apr 2022 09:02:08 +0000 Message-Id: <20220429090208.3852879-1-chi.minghao@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Minghao Chi Simplify the return expression. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/gpu/drm/vc4/vc4_bo.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c index e451cc5bcfac..49c0f2ac868b 100644 --- a/drivers/gpu/drm/vc4/vc4_bo.c +++ b/drivers/gpu/drm/vc4/vc4_bo.c @@ -738,19 +738,13 @@ static const struct drm_gem_object_funcs vc4_gem_object_funcs = { static int vc4_grab_bin_bo(struct vc4_dev *vc4, struct vc4_file *vc4file) { - int ret; - if (!vc4->v3d) return -ENODEV; if (vc4file->bin_bo_used) return 0; - ret = vc4_v3d_bin_bo_get(vc4, &vc4file->bin_bo_used); - if (ret) - return ret; - - return 0; + return vc4_v3d_bin_bo_get(vc4, &vc4file->bin_bo_used); } int vc4_create_bo_ioctl(struct drm_device *dev, void *data, -- 2.25.1