Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <dab1dd94-71af-e17c-cf90-662615c4a9f3@linaro.org>
Date:   Mon, 2 May 2022 09:28:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 1/9] ARM: dts: zynq-7000: drop useless
 'dma-channels/requests' properties
Content-Language: en-US
To:     Michal Simek <michal.simek@xilinx.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Dinh Nguyen <dinguyen@kernel.org>,
        Liviu Dudau <liviu.dudau@arm.com>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        Broadcom Kernel Team <bcm-kernel-feedback-list@broadcom.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Rob Herring <robh@kernel.org>
References: <20220430121902.59895-1-krzysztof.kozlowski@linaro.org>
 <20220430121902.59895-2-krzysztof.kozlowski@linaro.org>
 <a838f962-354c-9dcf-c0dc-80d1a6cd4fc3@xilinx.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <a838f962-354c-9dcf-c0dc-80d1a6cd4fc3@xilinx.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 02/05/2022 09:27, Michal Simek wrote:
> 
> 
> On 4/30/22 14:18, Krzysztof Kozlowski wrote:
>> The pl330 DMA controller provides number of DMA channels and requests
>> through its registers, so duplicating this information (with a chance of
>> mistakes) in DTS is pointless.  Additionally the DTS used always wrong
>> property names which causes DT schema check failures - the bindings
>> documented 'dma-channels' and 'dma-requests' properties without leading
>> hash sign.
>>
>> Reported-by: Rob Herring <robh@kernel.org>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> Not adding acquired review tag because of significant change.
>> ---
>>   arch/arm/boot/dts/zynq-7000.dtsi | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
>> index 47c2a4b14c06..c193264a86ff 100644
>> --- a/arch/arm/boot/dts/zynq-7000.dtsi
>> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
>> @@ -343,8 +343,6 @@ dmac_s: dmac@f8003000 {
>>   			             <0 40 4>, <0 41 4>,
>>   			             <0 42 4>, <0 43 4>;
>>   			#dma-cells = <1>;
>> -			#dma-channels = <8>;
>> -			#dma-requests = <4>;
>>   			clocks = <&clkc 27>;
>>   			clock-names = "apb_pclk";
>>   		};
> 
> Acked-by: Michal Simek <michal.simek@amd.com>
> 
> If you can take it via your tree that would be great (easier for me than sending 
> pull request with just one patch) but I can also take it.

Thanks, I will take it.


Best regards,
Krzysztof