Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <0ab679ea506b3955bd2787aa8dcb000dd718f76b.camel@intel.com>
Subject: Re: [PATCH v5 3/3] x86/tdx: Add Quote generation support
From:   Kai Huang <kai.huang@intel.com>
To:     "Kirill A. Shutemov" <kirill@shutemov.name>
Cc:     Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H . Peter Anvin" <hpa@zytor.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Wander Lairson Costa <wander@redhat.com>,
        Isaku Yamahata <isaku.yamahata@gmail.com>,
        marcelo.cerri@canonical.com, tim.gardner@canonical.com,
        khalid.elmously@canonical.com, philip.cox@canonical.com,
        linux-kernel@vger.kernel.org
Date:   Tue, 03 May 2022 15:36:15 +1200
In-Reply-To: <20220503024508.qjh4nfygfstb3ls3@box.shutemov.name>
References: <20220501183500.2242828-1-sathyanarayanan.kuppuswamy@linux.intel.com>
         <20220501183500.2242828-4-sathyanarayanan.kuppuswamy@linux.intel.com>
         <243e918c523320ba3d216cbe22d24fe5ce33f370.camel@intel.com>
         <20220503012721.ok7fbvxmnvsr6qny@box.shutemov.name>
         <4cf22a0799cc13fa6f09ffbf0e5d83ed7eeb32ad.camel@intel.com>
         <20220503024508.qjh4nfygfstb3ls3@box.shutemov.name>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2022-05-03 at 05:45 +0300, Kirill A. Shutemov wrote:
> On Tue, May 03, 2022 at 02:18:10PM +1200, Kai Huang wrote:
> > On Tue, 2022-05-03 at 04:27 +0300, Kirill A. Shutemov wrote:
> > > On Mon, May 02, 2022 at 02:40:26PM +1200, Kai Huang wrote:
> > > > 
> > > > > +
> > > > > +	/* Get order for Quote buffer page allocation */
> > > > > +	order = get_order(quote_req.len);
> > > > > +
> > > > > +	/*
> > > > > +	 * Allocate buffer to get TD Quote from the VMM.
> > > > > +	 * Size needs to be 4KB aligned (which is already
> > > > > +	 * met in page allocation).
> > > > > +	 */
> > > > > +	tdquote = (void *)__get_free_pages(GFP_KERNEL | __GFP_ZERO, order);
> > > > > +	if (!tdquote) {
> > > > > +		ret = -ENOMEM;
> > > > > +		goto quote_failed;
> > > > > +	}
> > > > 
> > > > You can use alloc_pages_exact().
> > > > 
> > > > > +
> > > > > +	/*
> > > > > +	 * Since this buffer will be shared with the VMM via GetQuote
> > > > > +	 * hypercall, decrypt it.
> > > > > +	 */
> > > > > +	ret = set_memory_decrypted((unsigned long)tdquote, 1UL << order);
> > > > > +	if (ret)
> > > > > +		goto quote_failed;
> > > > 
> > > > 
> > > > Again, Dave and Andi already commented you should use vmap() to avoid breaking
> > > > up the direct-mapping.  Please use vmap() instead.
> > > > 
> > > > https://lore.kernel.org/all/ce0feeec-a949-35f8-3010-b0d69acbbc2e@linux.intel.com/
> > > > 
> > > > Will review the rest later.
> > > 
> > > I would rather convert it to use DMA API for memory allocation. It will
> > > tap into swiotlb buffer that already converted and there's no need to
> > > touch direct mapping. Both allocation and freeing such memory is cheaper
> > > because of that.
> > > 
> > 
> > Does each DMA allocation and free internally do the actual private/shared
> > conversion?  Or the swiotlb is converted at the beginning at boot and DMA
> > allocation will always get the shared buffer automatically?
> 
> It can remap as fallback, but usually it allocates from the pool.
> 
> > The problem of using DMA API is it will need to bring additional code to use
> > platform device, which isn't necessary.
> 
> Heh? DMA is in the kernel anyway. Or do you mean some cost from the header
> for the compilation unit? That's strange argument. Kernel provides
> infrastructure for a reason.

I mean using platform device is more complicated than using misc_register()
directly.  You can compare the code between v4 and v5.

> 
> > Using vmap() we can still (almost) avoid private/shared conversion at IOCTL time
> > by allocating a default size buffer (which is large enough to cover 99% cases,
> > etc) at driver initialization time:
> > 
> > https://lore.kernel.org/lkml/20220422233418.1203092-2-sathyanarayanan.kuppuswamy@linux.intel.com/T/#maf7e5f6894548972c5de71f607199a79645856ff
> 
> I don't see a reason to invent ad-hoc solution if there's an establised
> API for the task.
> 

DMA API can fit this job doesn't mean it fits better.  And I don't see why using
vmap() as I described above is a ad-hoc.

1) There's no real DMA involved in attestation.  Using DMA API is overkill.
2) DMA buffers are always shared, but this is only true for now.  It's not
guaranteed to be true for future generation of TDX.

It's just a little bit weird to use DMA API when there's no real device and no
real DMA is involved.  It's much more like using DMA API for convenience
purpose. 


-- 
Thanks,
-Kai